From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f100.google.com (mail-ot1-f100.google.com [209.85.210.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789433A6EE2 for ; Fri, 22 May 2026 08:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779437243; cv=none; b=ZkYIMC0X1F5sSgUb6LOPTWi9zAiGMYGe6qC5WnSdnRKj2Zly5qvnlRbC4PFKiEQP8teX2A0i3UCKPh8TSiRrCH+wVnBiFaNOQrRuRG/I2JK2ggeohN88rY+0ZlsySG/XRuCAc2F4NRnIxWhMDGCKj9cmrJEotsjkEG829DVefjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779437243; c=relaxed/simple; bh=q6KH67+fpx0WZf6tA5LamIU0daI/Yq8DWIJzzgIs13o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SrHb3tQoFRqQpFMybLdKBUzvGx0nojjn7T06iKY0vlqRimPB1zJKHmk0+97ct4B1W/I4EaYGQSgDtf1yeuewmhSzZ1y0Ng7gqZxFu6dSkoqZNzab0yETf1FiEoiIVn3GUqyJNiIycfzAfpUwmbPbzOzWZolDpGQvZSc1HY4+jEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=eWyZKDyc; arc=none smtp.client-ip=209.85.210.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eWyZKDyc" Received: by mail-ot1-f100.google.com with SMTP id 46e09a7af769-7de46b8e432so6865475a34.1 for ; Fri, 22 May 2026 01:07:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779437240; x=1780042040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dK3E9ytJ6v6hFLrtKrLvT/ECVsmN9q554UP0S7mjyfE=; b=n+epuavdUHejslFV74im5Zp7K9v/papnqzYOSg9RkeH+6X1dgr6RybUkqrVl+v3F2+ C9Cg9dOOGHNc37zTTLsx9aDbVwztmFJnDvwZlpn5PcwaZk8cJPB4GH0eJ0r7KSOfpU9u Ny6rNZ7ms53xHHfTjDtd2JArqL+GrSyQv3JLQM8Cs6YcNBdj4ewBp5JPVRoa+R+IfbT+ J920UsFKzb3vjZJA6WThqOREsMqzewcb/HilVxFtns+DeoUQFhMETqFEchhA6OzSapoD Gmpy56LhPZt4r9rQFngqW/VOUbrYxA0OxsqfI2PZt8e2yxvknRtpqzP3DaW1u2brFns0 Ht/Q== X-Gm-Message-State: AOJu0Ywi1slVgcJ/xZemLMt4jY5hiOpzxNp7G9AwW+3NQo+wvPFtOQ75 XbbvQkfyca8qHz15nfFAmnlcbfGeRVi03plRZpFt9/iAYJqFEWMyoLwvwIj8eHrKjFqTiN/JzDh kqd6RLnEt5YwdEe/UKatQ5yFIylt4u4KkaMVccJmWDnKVoqXZZdHuqH33Oj8f1hmMlAUQnZOzHu NR0DeAMLMxiM1UD7ESTAb+Ago1eCDHtCtfqgy5LzSeoeEUqmDGPhJoj9GWY3EbH2w/VT/2jzlTM F5rKUt2t0d6i22Wr2c= X-Gm-Gg: Acq92OHhX1CXId47GrJA1hQf5CRO8Xh+BdSBWrjfrcGtK4nqzthPLD98z8PhtjiIlin KdDlgszSVGMf0nHZepSxj76AlbPufckxh5yspaX94ztOwG16rlB528w8+W8MQBUWT+oKgkzfVkk ZZ6QjDIiv73A+WUpBpJjDIyujtO+fULnYF7yppuckbpaYh5szBKoicn1B0iviuaQ6E3uJAJYSNM 4OxMduWcE+QN3Eg0Sd5qxf3VvHFj19XM34IJB3GJGGiaBEE/QW1+mL4BcQM6sO2VtPh9kj3x4yb lhf4yTntRBVQimCjZWYIJ2KTQGizI4gI4uvv4L0jtLVHtv0SnU4wXqunW4pba11dLpUuY03fVpe Bv+ZK/VVsybkwNDDelyxFv63/WRZu/fO/kvObU94oJZgSV6Wm+MQaYq2E9Iw9pkS4iwca6Q8vtg cEnTcHqsikulwD+QQyjwo3MCnbUGoA7ZS3OGlSyldB4qkeXe0JLFqqFFVM60gIUPaiyuY= X-Received: by 2002:a05:6830:620a:b0:7d7:e59c:80e6 with SMTP id 46e09a7af769-7e5fee9afc3mr1496940a34.12.1779437240370; Fri, 22 May 2026 01:07:20 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-18.dlp.protect.broadcom.com. [144.49.247.18]) by smtp-relay.gmail.com with ESMTPS id 46e09a7af769-7e60645a31dsm52475a34.2.2026.05.22.01.07.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 May 2026 01:07:20 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ba718173d1so122863605ad.0 for ; Fri, 22 May 2026 01:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1779437239; x=1780042039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dK3E9ytJ6v6hFLrtKrLvT/ECVsmN9q554UP0S7mjyfE=; b=eWyZKDycfNA0e5Urfb9zFkALcy0z8WgaZ/AVMMOsVzkDYQ6zE25f0B1k3W0vWa9b6o 8fwH3IWaAY9Y7Fv3qzFxmPco7dY3EvXRjmR9WNZ0t2OTxFQQoGjA64Ib6/LzDWVOEShH ytdpXZO/Am+Z19p6JxpACMGuzpO4L8DgfAHHE= X-Received: by 2002:a17:902:e78e:b0:2bc:8359:66f with SMTP id d9443c01a7336-2beb06db375mr28733935ad.35.1779437238812; Fri, 22 May 2026 01:07:18 -0700 (PDT) X-Received: by 2002:a17:902:e78e:b0:2bc:8359:66f with SMTP id d9443c01a7336-2beb06db375mr28733555ad.35.1779437238324; Fri, 22 May 2026 01:07:18 -0700 (PDT) Received: from pc-hpe-top-git-sendmail-server.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58b386esm10927905ad.44.2026.05.22.01.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 01:07:17 -0700 (PDT) From: Pavan Chebbi To: jgg@ziepe.ca, michael.chan@broadcom.com Cc: linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com, Pavan Chebbi Subject: [PATCH fwctl 1/3] fwctl: Add driver_data field to fwctl_rpc Date: Fri, 22 May 2026 13:38:28 +0530 Message-ID: <20260522080830.162740-2-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260522080830.162740-1-pavan.chebbi@broadcom.com> References: <20260522080830.162740-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Add a driver_data field to struct fwctl_rpc in the UAPI and thread the value through the fw_rpc() ops callback as a new __u64 parameter. The field is opaque and driver-defined. Drivers that do not define a driver_data format may return -EOPNOTSUPP. Update the existing mlx5 and pds fw_rpc implementations to enforce this. Signed-off-by: Pavan Chebbi --- drivers/fwctl/main.c | 3 ++- drivers/fwctl/mlx5/main.c | 6 +++++- drivers/fwctl/pds/main.c | 6 +++++- include/linux/fwctl.h | 8 ++++++-- include/uapi/fwctl/fwctl.h | 3 +++ 5 files changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/fwctl/main.c b/drivers/fwctl/main.c index 098c3824ad75..32c4c66dd7d5 100644 --- a/drivers/fwctl/main.c +++ b/drivers/fwctl/main.c @@ -122,7 +122,8 @@ static int fwctl_cmd_rpc(struct fwctl_ucmd *ucmd) out_len = cmd->out_len; void *outbuf __free(kvfree) = fwctl->ops->fw_rpc( - ucmd->uctx, cmd->scope, inbuf, cmd->in_len, &out_len); + ucmd->uctx, cmd->scope, inbuf, cmd->in_len, &out_len, + cmd->driver_data); if (IS_ERR(outbuf)) return PTR_ERR(outbuf); if (outbuf == inbuf) { diff --git a/drivers/fwctl/mlx5/main.c b/drivers/fwctl/mlx5/main.c index e86ab703c767..2a5105769126 100644 --- a/drivers/fwctl/mlx5/main.c +++ b/drivers/fwctl/mlx5/main.c @@ -304,7 +304,8 @@ static bool mlx5ctl_validate_rpc(const void *in, enum fwctl_rpc_scope scope) } static void *mlx5ctl_fw_rpc(struct fwctl_uctx *uctx, enum fwctl_rpc_scope scope, - void *rpc_in, size_t in_len, size_t *out_len) + void *rpc_in, size_t in_len, size_t *out_len, + __u64 driver_data) { struct mlx5ctl_dev *mcdev = container_of(uctx->fwctl, struct mlx5ctl_dev, fwctl); @@ -313,6 +314,9 @@ static void *mlx5ctl_fw_rpc(struct fwctl_uctx *uctx, enum fwctl_rpc_scope scope, void *rpc_out; int ret; + if (driver_data) + return ERR_PTR(-EOPNOTSUPP); + if (in_len < MLX5_ST_SZ_BYTES(mbox_in_hdr) || *out_len < MLX5_ST_SZ_BYTES(mbox_out_hdr)) return ERR_PTR(-EMSGSIZE); diff --git a/drivers/fwctl/pds/main.c b/drivers/fwctl/pds/main.c index 08872ee8422f..bb61e60843cf 100644 --- a/drivers/fwctl/pds/main.c +++ b/drivers/fwctl/pds/main.c @@ -348,7 +348,8 @@ static int pdsfc_validate_rpc(struct pdsfc_dev *pdsfc, } static void *pdsfc_fw_rpc(struct fwctl_uctx *uctx, enum fwctl_rpc_scope scope, - void *in, size_t in_len, size_t *out_len) + void *in, size_t in_len, size_t *out_len, + __u64 driver_data) { struct pdsfc_dev *pdsfc = container_of(uctx->fwctl, struct pdsfc_dev, fwctl); struct device *dev = &uctx->fwctl->dev; @@ -362,6 +363,9 @@ static void *pdsfc_fw_rpc(struct fwctl_uctx *uctx, enum fwctl_rpc_scope scope, void *out = NULL; int err; + if (driver_data) + return ERR_PTR(-EOPNOTSUPP); + err = pdsfc_validate_rpc(pdsfc, rpc, scope); if (err) return ERR_PTR(err); diff --git a/include/linux/fwctl.h b/include/linux/fwctl.h index 5d61fc8a6871..afb7f72d0cb1 100644 --- a/include/linux/fwctl.h +++ b/include/linux/fwctl.h @@ -51,10 +51,14 @@ struct fwctl_ops { * @fw_rpc: Implement FWCTL_RPC. Deliver rpc_in/in_len to the FW and * return the response and set out_len. rpc_in can be returned as the * response pointer. Otherwise the returned pointer is freed with - * kvfree(). + * kvfree(). driver_data is the opaque value from fwctl_rpc, passed + * verbatim from userspace. The driver is responsible for interpreting + * and validating it. Drivers that do not define a driver_data format + * must return -EOPNOTSUPP if driver_data is non-zero. */ void *(*fw_rpc)(struct fwctl_uctx *uctx, enum fwctl_rpc_scope scope, - void *rpc_in, size_t in_len, size_t *out_len); + void *rpc_in, size_t in_len, size_t *out_len, + __u64 driver_data); }; /** diff --git a/include/uapi/fwctl/fwctl.h b/include/uapi/fwctl/fwctl.h index 2d6d4049c205..2e07425402a3 100644 --- a/include/uapi/fwctl/fwctl.h +++ b/include/uapi/fwctl/fwctl.h @@ -120,6 +120,8 @@ enum fwctl_rpc_scope { * @out_len: Length of the out memory * @in: Request message in device specific format * @out: Response message in device specific format + * @driver_data: Opaque userspace pointer passed verbatim to the driver. + * Must be 0 for drivers that do not define a driver_data format. * * Deliver a Remote Procedure Call to the device FW and return the response. The * call's parameters and return are marshaled into linear buffers of memory. Any @@ -136,6 +138,7 @@ struct fwctl_rpc { __u32 out_len; __aligned_u64 in; __aligned_u64 out; + __aligned_u64 driver_data; }; #define FWCTL_RPC _IO(FWCTL_TYPE, FWCTL_CMD_RPC) -- 2.52.0