From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9D23A782B for ; Fri, 22 May 2026 08:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779438054; cv=none; b=XJnAquet4JeP8Pkcq3PF+GFsdL1/5k/YqvH07xMwnvGum6zIkZW/HsTI82up/PcEJz/O/aicynfTyssp2qWZrN8ll2iBF65yxC8zVQ2XROeCOcT2uMtjuDxsp+G3jRTVwMDizVUd77/lwsDKvxokJoYorLDtkHirjq17BZ7C/No= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779438054; c=relaxed/simple; bh=y3gO1/IRDX9AoOFixAaefYA8zXXxRvfVy4cVwEKXiFY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g8DPII8JGFNbuuwwRhAEWTSnM9sAD7YqGAnvXMfDVWaA+cH/5xPI2Pe3czoTPHAj5smmOvuwsp6hXbK26htcB8pBtLDkpP+xRS01cKycLwVob8+z+DMZ9DUbgRissruej70TWBqKQX9i/vuh2dTD69sUHMHHjZI1T+5npeLCamI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b5DcLO9G; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b5DcLO9G" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-44b330c5cc6so5283087f8f.1 for ; Fri, 22 May 2026 01:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779438049; x=1780042849; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FtBUHZ5NTfzEhm+9SPa+wbOEFPDSpIs8MinMBuqfMJM=; b=b5DcLO9GA8hDubB2tbBsRUXaFsFbl1WJwxLjAHY0kKjfVRFzFKiqtC8OBwSWwa4fwC Yhw4Zwpj/cA9sWKHopD+O1Q9XcVI19WDQhoXFNHVGD3dTg8rKwYfkQrERm1AcHbSkPp+ 4vgS6f7No46dqCt6Cy/aI3Ix4RbVvYlZjY1Lp9+21rzVC3rmtxPrvLY7Zkm3LYWYwX8e oiAFAEyWCw+rf7SUb2TvL7gH6k+dVvJqJJgjjWyF79vNk82YECPtchi8AsL9nS6Jfxjy RWJUXUxBqa8UU+EIiCd27YVkg/QBmC47SZDRvQZUTOB0PUsk3cSVFL9KNHbmj/ql1iGM wx2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779438049; x=1780042849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FtBUHZ5NTfzEhm+9SPa+wbOEFPDSpIs8MinMBuqfMJM=; b=GG1lULWizJKz/7wLuRBOOk4WGhOt9PEG8PnAxHSr6DholmjwEEp9/tDb0I6pxjp17M Rc7WxnjrQndPtzb6n0TjPMD9A61ZcyP9jEo75N6eAsY7Qlh16rza68AsNySSgdRsM3gf k2ecf+0O5VlrFjjLjavyOhTPqkjq9LXvjc+yZsfXr0onBvuEbDkiU8mJQ3BD7pV7RZiL y11gdkKJ6fsNA0aMdFRhTA0bIGKMTNMc2ioI97BxXWxsO6c4O4GyJ7aHfoDqWS+itkPx etuwWSslu3ohSZ1lMxeirPCQgaDYXYYCqmcHRwmsx2PrBs53RpmhcKaELbpIMhQcKdZB Gvuw== X-Forwarded-Encrypted: i=1; AFNElJ8kInVQrxbymzV22UhZzli57Au0Fsy/9T3+l1hMmyRJhrbCFZ8QWafCo2FKqn1J4MbKC/Z2pD8iqDz4qPg=@vger.kernel.org X-Gm-Message-State: AOJu0YzmoJ58mo6HrW07ue+Wkl+yqq+a7SlbB3A/e8nQpMN1PAUpLUxP YlBXJg92OgSq860JEbcJUp2PDIcaNnxHpjHQZQscZGv+1WbLQGT7EchN X-Gm-Gg: Acq92OH4issn235nvvNO2pGaOv6tnyvz6aVjT4gLfqgcVdUpMGOG6yQwZ28fCdYu9DE gErLcTkI4emokHRsIQZtPXt9IVmV+3rChzUTPVzSOrcPJPtLf9BO4Z/doLPAh7QtpIpmp3hhFy/ FF3swwdDKoXa04Xdg4Jx8ZZEnxFjR3Q6U0cnhAmGIMlIKwL0kDWHmQJW9w3vt5zwVWa1rcN+ESC 16E4H1tBkcEXbLc9CR1QOBo8/o5oFWQb+WcKxnRH96cHTvea/kWJfvlWqRWeIamQAs8gkwg6fDT eIZJgG0uMgCGKZ0PX+Y/zVuAeVm8ydloqqzVWo8CW0KF2Y8bl14fetoPKcAv91Me3SHHYbVac9v Ujqo56ZnYsVUN37m/iaLPJhF0dqEO7DtNDRoq0NmVzzPVjJO7Rq1uMXB2sDclokN8LvBVMn51kh grcEmaDqcgmKP+0MGOp1v5XAATe+9m4LO5jYikaKt12n/MFqJ+CcJKbs4PXb1/rEN0pJe0QQM1E +A= X-Received: by 2002:a05:6000:1446:b0:43d:7a97:78af with SMTP id ffacd0b85a97d-45eb38e04e3mr3459686f8f.42.1779438048957; Fri, 22 May 2026 01:20:48 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d49132sm2187929f8f.24.2026.05.22.01.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 01:20:48 -0700 (PDT) Date: Fri, 22 May 2026 09:20:42 +0100 From: David Laight To: Ashwin Gundarapu Cc: "anthonylnguyen" , "anthony.l.nguyen@intel.com" , "andrewnetdev" , "davem" , "edumazet" , "kuba" , "pabeni" , "intel-wired-lan" , "netdev" , "linux-kernel" Subject: Re: [PATCH net-next] net: e100: remove redundant static variable initializations Message-ID: <20260522092042.5773213f@pumpkin> In-Reply-To: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in> References: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 22 May 2026 12:22:30 +0530 Ashwin Gundarapu wrote: > From: Ashwin Gundarapu > Date: Fri, 22 May 2026 12:20:23 +0530 > Subject: [PATCH] net: e100: remove redundant static variable initializations > > Remove '= 0' from static variables eeprom_bad_csum_allow and use_io. > Static variables are zero-initialized by default. > > Found by checkpatch.pl Not worth the churn for existing code. -- David > > Signed-off-by: Ashwin Gundarapu > --- > drivers/net/ethernet/intel/e100.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c > index bfacf877ca40..bdddd4315cbb 100644 > --- a/drivers/net/ethernet/intel/e100.c > +++ b/drivers/net/ethernet/intel/e100.c > @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S); > MODULE_FIRMWARE(FIRMWARE_D102E); > > static int debug = 3; > -static int eeprom_bad_csum_allow = 0; > -static int use_io = 0; > +static int eeprom_bad_csum_allow; > +static int use_io; > module_param(debug, int, 0); > module_param(eeprom_bad_csum_allow, int, 0444); > module_param(use_io, int, 0444); > -- > 2.43.0 >