From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Chuyi Zhou <zhouchuyi@bytedance.com>
Cc: tglx@linutronix.de, mingo@redhat.com, luto@kernel.org,
peterz@infradead.org, paulmck@kernel.org, muchun.song@linux.dev,
bp@alien8.de, dave.hansen@linux.intel.com, pbonzini@redhat.com,
clrkwllms@kernel.org, rostedt@goodmis.org, nadav.amit@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v5 00/12] Allow preemption during IPI completion waiting to improve real-time performance
Date: Fri, 22 May 2026 12:57:04 +0200 [thread overview]
Message-ID: <20260522105704.Vd1FdOA_@linutronix.de> (raw)
In-Reply-To: <20260513124524.2569867-1-zhouchuyi@bytedance.com>
On 2026-05-13 20:45:12 [+0800], Chuyi Zhou wrote:
> Introduction
> ============
>
> The vast majority of smp_call_function*() callers block until remote CPUs
> complete the IPI function execution. As smp_call_function*() runs with
> preemption disabled throughout, scheduling latency increases dramatically
> with the number of remote CPUs and other factors (such as interrupts being
> disabled).
…
Thank you for working on this.
I went through the series and I don't see anything wrong with it
conceptionally. I made a few comments on how to get
smp_call_function_many_cond() a bit improved/ readable but this is about
it.
For 1-3, 6-12:
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
I am not too keen about that smp_processor_id() change, not sure if
flush_tlb_kernel_range() could get its own structure. Don't want to make
this series too complicated, that is the call of the x86 folks here.
Sebastian
next prev parent reply other threads:[~2026-05-22 10:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 12:45 Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 01/12] smp: Disable preemption explicitly in __csd_lock_wait Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 02/12] smp: Enable preemption early in smp_call_function_single Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 03/12] smp: Refactor remote CPU selection in smp_call_function_any() Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 04/12] smp: Use task-local IPI cpumask in smp_call_function_many_cond() Chuyi Zhou
2026-05-21 15:26 ` Sebastian Andrzej Siewior
2026-05-21 16:00 ` Chuyi Zhou
2026-05-22 7:22 ` Sebastian Andrzej Siewior
2026-05-13 12:45 ` [RESEND PATCH v5 05/12] smp: Alloc percpu csd data in smpcfd_prepare_cpu() only once Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 06/12] smp: Enable preemption early in smp_call_function_many_cond Chuyi Zhou
2026-05-22 10:08 ` Sebastian Andrzej Siewior
2026-05-22 15:16 ` Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 07/12] smp: Remove preempt_disable from smp_call_function Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 08/12] smp: Remove preempt_disable from on_each_cpu_cond_mask Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 09/12] scftorture: Remove preempt_disable in scftorture_invoke_one Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 10/12] x86/mm: Move flush_tlb_info back to the stack Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 11/12] x86/mm: Enable preemption during native_flush_tlb_multi Chuyi Zhou
2026-05-13 12:45 ` [RESEND PATCH v5 12/12] x86/mm: Enable preemption during flush_tlb_kernel_range Chuyi Zhou
2026-05-22 10:48 ` Sebastian Andrzej Siewior
2026-05-26 3:25 ` Chuyi Zhou
2026-05-20 12:44 ` [RESEND PATCH v5 00/12] Allow preemption during IPI completion waiting to improve real-time performance Chuyi Zhou
2026-05-22 10:57 ` Sebastian Andrzej Siewior [this message]
2026-05-22 14:11 ` Steven Rostedt
2026-05-22 14:45 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522105704.Vd1FdOA_@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=clrkwllms@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=muchun.song@linux.dev \
--cc=nadav.amit@gmail.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhouchuyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®