From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA73A394781 for ; Fri, 22 May 2026 13:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779455114; cv=none; b=qNgsdFWCGL/GnZC6gxrrNJJ2uvfF5FwYji4PtjrSquz782iJ+Rj9frWUINe89NYPTeVJKcLOn9ap8G35AC1Ybtg1DN3NIKaOd/kxQ4rkhueCnKY7Wr4Qb2cxuSHmTc/PdDK1Gkx8inixFR5NMhaj2FEG+ymea1S4WM5GZupQxAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779455114; c=relaxed/simple; bh=TZ5Gbdy8MpD0BkDYauXmi2P3QUkOwpzPVQi/b1SuMMU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sW57KWrwVzUkW7/J2tWyBEQw1M19/1QRl+AqAgI+1I0ZAiC+LKOWWv7zsVHinnOSfe0trsL3m3RWWxnmngEpDR8r6WlhL6y2uVFo+4NY0Ox9hasTnQTM7laUPUpgfF5j0GupbeYhQORuocG7q+30vkSMi6n5TnGpcCpv7oyJC/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Nb25CypZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JKglJFw4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Nb25CypZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JKglJFw4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MA4A4w3947414 for ; Fri, 22 May 2026 13:05:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=LU+3o0EUymr NGBvYnnfmtFWJLYjR5wRDEMuCtrEycf4=; b=Nb25CypZwbUqsUc7tdjwjjwNkQ+ bBsaMBdfol9M8d28egxJ8jv0POZtQU9FcD8sj2SvMFm+Mep/m0M5kU44K6pa2vVq JS6K3PyQHd8j8Xxmxns3JMF2+L+VgDpQVnAuRKPqwsjPbJrnjImFbTpCfdrA6u68 sqqxmcsTcoheKnskeV8Ua50qlyMp8AdEdHjpuejMf7Kbiu3sN+jY1tnZZ+/j9JOP AvaTaFUjlbS4KHgqvRJGG0viAGlmDaELLReoKBlo0ZLOOz36dfdZPwMT5SKSM/XY iPjlmbns8f9LvBaPRq2Da+tf48zAO6GnjOykTG1yVcCy5VItzxIlF+mbs2Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ean2ngkbm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 13:05:11 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-366ded5ab5fso14694086a91.0 for ; Fri, 22 May 2026 06:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779455111; x=1780059911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LU+3o0EUymrNGBvYnnfmtFWJLYjR5wRDEMuCtrEycf4=; b=JKglJFw4JJzaq/dM3OjAxPw9Lo5OqwaAC91XanMZ2ItjZKb+3irPF/nSaDTia5uz9Y xFi1/9z1VGv385Amw+cVUn1cNk3qxdqhik+NTZRCRDr0pwRAHKRv4x5Yq4Mw7RpcVB07 hcaEg2ulJUcO/CE86QZ37sxd8PKXOrsgnBZZpgnKseBIJ5tOgxq4WVLBckdoF/Qc5e3O moNOe4UtiWZ5/kteHSkhX/G5jBTkpv75jTRH/UYNGD740vqFae6L6ucIZ+9IfVp5OsXd 2fVeZu2EgukbYEU9dDTPfRjaWfryAFtNh+W7NvkuHRr2kVX2wkxmUpeU+048Vqmlpcv3 ybVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779455111; x=1780059911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LU+3o0EUymrNGBvYnnfmtFWJLYjR5wRDEMuCtrEycf4=; b=NqBMMlJYtuM4/BhmFbUF6/WVBK+riMVR2rSElOitbYneHfCsQUgtOZ01nXbhV55xwa s1O3ZAW2maZLqAMZ7knpUaftmjxloyBGXnjw3l9ur3N9XHKvbE6xSlwSvmPHssYVkp4G SiG6K1AebYWlHmBHkyvqECEE53eCv6Hv0JO7xSco4ugcHNQlcAzjhWvo2jzqJpMfyksk lZgJaxHaNkYoJnnzO2r/d7JLIR5TJJ/J/pfyaOIx8TG/EZzqSCX1gV5gt8GIi03zNaSw SXTNIg4nDoQA7N3VIBwdYnC58sxqDJZlNzLQW3zEOxHVXjbzp8RPfyng7sJKKTyp2VmT FIJA== X-Forwarded-Encrypted: i=1; AFNElJ8P2Hu7IHFDUfO2zTZI5NSCMs5IsznuE4B6/yIXiknFjXp1eAVNUHLhuQ5Q67LxmWP9aF82ZaqX4hznGkA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+vea3u3+XggHnBb+vpyboOVdTGop7zcRqTDwd7k5MgqzicNd9 HFUUUW2SLN8KU+ULIlfRWG7DeuUrPukLIOF8UvuDF3eP8+kTFTNcudWtX0cdyFo41jYGpi6ccwH XLKYhkzBnnxNB+iLjU3iy0AyIMdzCmsPe0GFFtWLYvOAzmCh4uKXOyAVoS2dsmpzn2+w= X-Gm-Gg: Acq92OHtYNwgI1sd3T2Frq6OoiBO58K3N8ogE+2Dznqz0hca+lOZgdXArd/RJjFwYI+ mhOEEvMVCmixVFSvWOp9l8+Zgd2lA71Vii6lOeWZzHifGQDQhWZDhRYAbw/Udwba8dtHAFXpGft rsFj4AwcdoiWFvbhOOpx0jgup9/VC3Vvg5Dio7gvUkdhIq1rqu1Dr6dc9gd8W25IF1d8UjcG6D+ sUNfALSR94CdHstmbJVHccm744o+Va8gDpQka+FdVv2bhMTDb0xQ/Sri4ttrKRtPt3E8opsGojF tm4p6Y+I3zeLb6YD67GgFU1UAZx1BMZl7NoB4aNFAua/Z3f0pBsy3Pfa5vAibJV+PpWkgqfS+J/ 01cuy8J4eDaO9d4dfBjUthWKWzf3Y6+gJEB2KnCXqPddfZvxjJQ== X-Received: by 2002:a17:90b:578c:b0:368:b176:c5a8 with SMTP id 98e67ed59e1d1-36a675ff469mr3717469a91.15.1779455111365; Fri, 22 May 2026 06:05:11 -0700 (PDT) X-Received: by 2002:a17:90b:578c:b0:368:b176:c5a8 with SMTP id 98e67ed59e1d1-36a675ff469mr3717425a91.15.1779455110919; Fri, 22 May 2026 06:05:10 -0700 (PDT) Received: from hu-nandam-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a72c98b95sm2069980a91.16.2026.05.22.06.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 06:05:10 -0700 (PDT) From: Ajay Kumar Nandam To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com, Konrad Dybcio Subject: [PATCH v5 3/3] ASoC: codecs: lpass-wsa-macro: Use devm_clk_hw_register() for MCLK output Date: Fri, 22 May 2026 18:34:42 +0530 Message-Id: <20260522130459.3411038-3-ajay.nandam@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260522073324.e18bb240b6f6@oss.qualcomm.com> References: <20260522073324.e18bb240b6f6@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=XvDK/1F9 c=1 sm=1 tr=0 ts=6a105488 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=E7064k5JgmqFsk_8azIA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: QjwxyaG3PnotCwbkyMrsNsjYT7wK78S1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDEzMCBTYWx0ZWRfX4l203BeOL9cU Shj4GHUu/xOb2H8ROSv9EBXDAKD8cq2E4OONaJJmDV7uVYKTHW76Mszxx2OYCQCL9XQSrZlf9vI Y9aq0n+/VOY2yFcDVyhmHKe7z21tkMxAku6Ue306SkVmSc/CPj2JCbmiK32yF9dcTd2KZMFCSPX yLnQY/gtlbgdW9iXPo3VVr5IwjhjcQT9QhT2wxYAW07/WEDzni8Jb4k/Zggcn+GJoXz02ZB5ndd YJ8QPuFXY5xt49rd5mIh2oPzKg9/qptwwDIahMraMWr1mWb127Y9AlHp+L6Vft8BUhSiJDSpEEQ 95BPtye6AlNApH/JULqykFQJ3Y/jRjF6Rme5OYSUEnBGMiThkqcqh3iDv50XM5jfmd1mMR8JcVi duAAP8QGJVcvS1J0l3B9Nl0n1QpDRxeA/Bk9uzzWHeegnI5tr5dzpXFllDN7sCsTv5Umdl/2EcK Ti9kUzxnaGeSADsyPiA== X-Proofpoint-ORIG-GUID: QjwxyaG3PnotCwbkyMrsNsjYT7wK78S1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220130 The WSA macro driver registers the MCLK output clock using clk_hw_register(), but does not explicitly unregister it in the remove path or on probe failure. Switch to devm_clk_hw_register() to make the registration resource-managed so the clk_hw is automatically unregistered when the device is unbound or probe fails. This fixes the missing unregister cleanup in remove/probe-fail paths and simplifies error handling. Reviewed-by: Konrad Dybcio Signed-off-by: Ajay Kumar Nandam --- sound/soc/codecs/lpass-wsa-macro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index 598292fe3219..3081c115d584 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2658,7 +2658,7 @@ static int wsa_macro_register_mclk_output(struct wsa_macro *wsa) init.num_parents = 1; wsa->hw.init = &init; hw = &wsa->hw; - ret = clk_hw_register(wsa->dev, hw); + ret = devm_clk_hw_register(wsa->dev, hw); if (ret) return ret; -- 2.34.1