From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C3F4403E90 for ; Fri, 22 May 2026 13:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779458241; cv=none; b=KkVkLja9GF2oRyzfrfhAzmIwxDQ/UuJiqkCcU4Yl39f9Wr0ZZRWgZ3SqSVHOQkLY61folrgCd4NgEy+zpleg8C8a22o6KZeVnv7te3m2OAl6NL7flayx71b3QZ1qFY543VQCPteRr2ox6Rn81PoMkzQmm1yEDuhlxiwd2VjE8aA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779458241; c=relaxed/simple; bh=W7ipyoW/fRSYhba4QVfOCwXsodllmzAL79gEGnCb1Uw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=my8Mw4ymTNpMpP1r7c6wXz6K6f6qOafutqIGSKerOYXquGl0Ni57eZNWwIlz2hySrjMHLUQZHx3ViMKFcuHqniUcZHUY/uaoQo0iZKchTP9RH+chmqciPmztMPkKyO9iUZwViMwWRrLjE6NcT/+21zZsGqLHpxBn1fkLQITW+0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YmzAA8Or; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YmzAA8Or" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8353fd1cb5fso3603425b3a.0 for ; Fri, 22 May 2026 06:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779458240; x=1780063040; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4SSqgZ+xBW8AJpHIxgNY5kInADkD/HLOymZ8JyZqvnA=; b=YmzAA8Orc6Fv1l5mMYMim8P6d8+x2qk9Uu8z4GBfSrGH947ty3wOJzvceh2WpvnNaB v7MbvtnBNaUkYKtaj/Xt3s+GLxTkaIYc3/3CpmJjKcCkJ9ZM8eZsEcvxbBvBGAMB0XiS uyP286fpUjhBX2SseWuJA2DhMZ+dYOk49rvMNTF73BIO7KgPahovgYaVsV+bw02J9Bhy XgYHKMw8TlzNYLeF+OBrFR+rLCQzaKiDLmny1btY3u/lt0L2LLGCoyvCBDbSkBfx0tCb tGw/jW1cissR65ze52n+Aub7z0xbtBAiADgipypNILmH5GKdhemG4P1YRvxakqvKrCJs 02UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779458240; x=1780063040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4SSqgZ+xBW8AJpHIxgNY5kInADkD/HLOymZ8JyZqvnA=; b=UrVu2FVjL0W2bx53/NLbmXvpr5+UdSWRhKy1lHrg5ywRAvnsjcLaRlKXyFRrvi29/R qtamHbiYUGiXkRsB57VsiY1NleY0f/OKUFNVzLvACgBtSdfkDTE4+v58UeDdtKwG63wp /Sb/Y/y3/qc8aXeWKpWAzM1+f9R5PaW9HAeDZUtPjJ6eyT9B0pMUDQ7mBBvNVlNG5cP0 IJMMAo0TCRw37PSpgLvRu5FiPlIWyaMg3kyDla0+oXp+oROkLI7LCFumFO2EmRASA5VP qSBRPcVKvGRJ2iGrLgYy+Dacf4oBfpvIvPXnpWfvt7SY4CdSlNxJ0g8fUE3Ynvvg7FRi yDuw== X-Forwarded-Encrypted: i=1; AFNElJ/BJhnx5mIn5a1PEM0IYSQJ/SMtXW9dWoy/XWIAEMIG9e2lC/7ZOzXswLMe91S70ejnuLt/f2qIS4J88cA=@vger.kernel.org X-Gm-Message-State: AOJu0YzSDFq2B878OSqT11Z0z2QTe+VU4IHMTIiCYTPzX/t/ga8Me+S5 jSy1dMOEk467Ti8iPDzEzRvFa00u8J25er4zvznIFlBY7RGV+sYQpUyN X-Gm-Gg: Acq92OGpr6k6loW8WftmawSeqFhaqa047QyUMkJINj8DpL3TLOfxZIsozeqxR5uEqGF 4Zqr8ZNjxAQIWAXGvR9mdVWu+THVSjgu0xmjWNg9TZRiRKqcdqNJCHTIU2d/ZFY1cBg4LDDehnu 6ggXksHRsuUPYq1Icbi/q22nXz5QwCP/54vlpBBEJcXp9oAOsXFsNgVkoG0HLgDQ9eHRQrDcmtQ plIFhLSYv7A9/CXoNPS2ETTYEu1aEiFQJxsG1DOzEVtn5Z46w280jqGmcw1x7eo0PzPV0ckNF+9 X2FoztINxfCLUaLuDV7zsbd4Y0VoRv/qrmdJxlqoRK3oOLvf+5nsWNgmj7AGMSJyIzF4eh4IK+T dJrS237M+HN5Y5hDYCLBcnL4MEs1uGDv/JiGDI3NxnHGBf9BgtfhkBL2jkTTR0xOxLtJjSvNIyD jrT+K3fkJTVchW4dNisKufhFoi87ZsjCFWqOlMxjgwZQ== X-Received: by 2002:a05:6a00:2407:b0:837:8a0c:8f70 with SMTP id d2e1a72fcca58-8414b5523e1mr5862028b3a.28.1779458239573; Fri, 22 May 2026 06:57:19 -0700 (PDT) Received: from localhost.localdomain ([2408:8210:c68:1df0:15da:df1f:de46:f7d4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164fc646bsm2135061b3a.46.2026.05.22.06.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 06:57:19 -0700 (PDT) From: zhaoyuenan To: chao@kernel.org Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: Add ckpt_thread_task sysfs node Date: Fri, 22 May 2026 21:56:54 +0800 Message-Id: <20260522135654.19535-1-amktiao030215@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260521151008.13682-1-amktiao030215@gmail.com> References: <20260521151008.13682-1-amktiao030215@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Chao, On 5/22/26 10:50, Chao Yu wrote: > Hi Yuenan, > > Thanks for your contribution! > > If there is a method to get pid via userspace, I prefer to do it in userspace, > rather than implementing and maintaining an duplicated one in kernel. > > Or do you have a strong reason to do this in kernel? The main reason is that retrieving this PID from userspace is currently quite complex and fragile. Previously, userspace tools had to rely on pipelines like: pgrep f2fs_ckpt-$(ls -l /dev/block/by-name/userdata | awk '{print $5$6}' | tr ',' ':') This approach has a few drawbacks: 1. It requires parsing major/minor numbers and executing multiple commands, which is inefficient for simple monitoring tools. 2. On some older kernels, the thread name can be truncated due to TASK_COMM_LEN limitations, causing 'pgrep' to fail to match the full 'f2fs_ckpt-X:Y' string. Exposing the PID via a sysfs node provides a deterministic, lightweight, and reliable way (just a simple 'cat') to fetch it without any userspace guessing or complex parsing. Does this address your concern? Thanks, Yuenan