From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Zongyao Chen <ZongYao.Chen@linux.alibaba.com>,
Ackerley Tng <ackerleytng@google.com>,
Sean Christopherson <seanjc@google.com>
Subject: [PATCH v2 3/3] KVM: selftests: Remove unnecessary "%s" formatting of a constant string
Date: Fri, 22 May 2026 10:21:51 -0700 [thread overview]
Message-ID: <20260522172151.3530267-4-seanjc@google.com> (raw)
In-Reply-To: <20260522172151.3530267-1-seanjc@google.com>
Drop superfluous %s formatting from assertions in the guest_memfd overlap
testcases, as the string being printed doesn't require runtime formatting.
No functional change intended.
Reported-by: Ackerley Tng <ackerleytng@google.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
tools/testing/selftests/kvm/set_memory_region_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/kvm/set_memory_region_test.c b/tools/testing/selftests/kvm/set_memory_region_test.c
index be99c1ff5a5a..e0800bfb11eb 100644
--- a/tools/testing/selftests/kvm/set_memory_region_test.c
+++ b/tools/testing/selftests/kvm/set_memory_region_test.c
@@ -554,7 +554,7 @@ static void test_add_overlapping_private_memory_regions(void)
MEM_REGION_GPA * 2 - MEM_REGION_SIZE,
MEM_REGION_SIZE * 2,
0, memfd, 0);
- TEST_ASSERT(r == -1 && errno == EEXIST, "%s",
+ TEST_ASSERT(r == -1 && errno == EEXIST,
"Overlapping guest_memfd() bindings should fail with EEXIST");
/* And now the back half of the other slot. */
@@ -562,7 +562,7 @@ static void test_add_overlapping_private_memory_regions(void)
MEM_REGION_GPA * 2 + MEM_REGION_SIZE,
MEM_REGION_SIZE * 2,
0, memfd, 0);
- TEST_ASSERT(r == -1 && errno == EEXIST, "%s",
+ TEST_ASSERT(r == -1 && errno == EEXIST,
"Overlapping guest_memfd() bindings should fail with EEXIST");
close(memfd);
--
2.54.0.794.g4f17f83d09-goog
next prev parent reply other threads:[~2026-05-22 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 17:21 [PATCH v2 0/3] KVM: Fix guest_memfd binding overlap errno and selftest Sean Christopherson
2026-05-22 17:21 ` [PATCH v2 1/3] KVM: guest_memfd: Return -EEXIST for overlapping bindings Sean Christopherson
2026-05-22 17:21 ` [PATCH v2 2/3] KVM: selftests: Test guest_memfd binding overlap without GPA overlap Sean Christopherson
2026-05-22 17:21 ` Sean Christopherson [this message]
2026-05-22 17:52 ` [PATCH v2 3/3] KVM: selftests: Remove unnecessary "%s" formatting of a constant string Ackerley Tng
2026-05-27 18:10 ` [PATCH v2 0/3] KVM: Fix guest_memfd binding overlap errno and selftest Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522172151.3530267-4-seanjc@google.com \
--to=seanjc@google.com \
--cc=ZongYao.Chen@linux.alibaba.com \
--cc=ackerleytng@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®