From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139A93644AF for ; Fri, 22 May 2026 17:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779471277; cv=none; b=QjiNqGkPseThLD9sFE4Wiz+ihnrd5GcBFHT/4OomVTuNsvoIKR+4fmSfpW85MWNJ7uhaouq8Pl9LyfQYe90Xl6OdmU5OODKwUnEv66aZVtozabgtFYwU8lYX7Rnx3colKQ9qKqyyXt6FJ8SLJyzea4WyZDQm7xOj5LmafVcERvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779471277; c=relaxed/simple; bh=8VWbdGkuGsTTTwEXrzMET+OwRMV8Bxyp9scuxw0paE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Am8WemXOBZzLBbmOw6YPSiicoh5pEsnRf1RUVjWJ8UUgWjEM44+oXyg2XCsDNkMIXD7xYDgpBp5bMZrToVvTyAqTeYOgXcDTuGyfRJmq1fcI4RoJZW9AqRJ0IiCUrsOTVZxVZcoUzlhfgsiWPihaOcB7kO+vO9W8T+WClrzbmt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B1JMWk55; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YlCoZbPO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B1JMWk55"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YlCoZbPO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MB3Acm777951 for ; Fri, 22 May 2026 17:34:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=uZWxbq16V5d ge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=B1JMWk55GaHgiWCzPuJxLZtkRd6 YlokSf+1ZlCWA5czwzoleWZ1AnL5mKFJJ2sFcOLqwixvEErfRDo63Q9vsd6GpW2u OrtVcMySfUES9/YqbL+IwQWDuWi68nXNK/1+5nBNt0PS7lbNEVUm4U1AidJMIVNU 0HMsBO+KeV6U7P+nwJutgyetySDJibNy9tUR76ifcGjp0EQISKffeGAgO4Yxevlc XUb9sCRABJhO4NYMI+Wsiias9AKTYNjbVt3tY+AmOjKh+3/9ArYDN6RBYr562ni2 Ui1M4FRk4U60lUXb66wVd1Qln8PL5oG7hEjF4WyVRdxj41d+EaYXJmczXAw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea94h4ns8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 17:34:35 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-366122e01fcso7503600a91.2 for ; Fri, 22 May 2026 10:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779471274; x=1780076074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uZWxbq16V5dge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=YlCoZbPO3JXDnkLJV6wAwDi0eZ6Ji6/eBOAPhkxFOP7IBsNMQatoovkoPWcwi/Lc2k 0ZaCrUd5yrau5V+1dlvRN1KRY+wZfC8ZfTLTW7OML5FmjjJu4G58tbNhIWpGXozMfTT0 qCZFp+Asrga4XDT6dzMad/GtcLYJ/vONKVsbXDOq/nszzqRHkQO8ahZOHWsKrfsO7JZI hsAUBOAG7NTfeJecC3tzc5hAAxPmxn1O/cW6YX7CryaqqM0KySpwd8330qCPysFsUNcw FRh70Qh56YSgLoNug8kgylUWiUvezmG2ehGrsYrF09J8LJxoNGn4wwwSBa8uunViMSqb TyqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779471274; x=1780076074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uZWxbq16V5dge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=eFbNnAeB+cbeWdsx46rSePRww4mr1cEBqbzUbhA18rSPwnjsxi/mj5PFshJVt1ATbt QRwmcDcaEN6Y7weZi7Yhw3Yyo1uzc9n8fb7JqBfnCzrQ2xVnP5rd9E9Pm10fi6N0iM+v wgq0ZFSsHCHtXOMiYwrLQ4/DNwIU2cgLD8+bfDxhiERZBj/ByBcyK5r5/RltzNeXJLC+ /cAjs0Yhcyr1exey8e5HDqwRuCpeB04FnZbpriqntuSLH9uzeXfxK8obLuQhWUu1+0T6 d7PCzpog+3+LrJ7mY2aruI1BdcOg8B6xeGXrxRuWoij7lT7v8NfPLplZrS/g5HyfwsRR +D9w== X-Forwarded-Encrypted: i=1; AFNElJ/1h62XDBHaYCe8iIuGeEPAMuu1pY6FfNXTiTL8dhDQ+bbB4AVIX5a0/EvxiLB7KJKao8WThHRS8cKLobg=@vger.kernel.org X-Gm-Message-State: AOJu0YxTY3T9OsyRJ+nblUAv9HeS5N1JQ6FIYhjdAVSnhof4A/z7UNF3 b2MTDElNcI0lvbZZepDKHZyJQCC8B2Kcnr8f6LmufveaMwNrlIoFNk/OAXd/Z9gkfb6tWEmqnKZ wo90As5E7pXOvaErv7QNa1RlogDTif4jnlasfqU+SR4d96jpdlUtc2vJyY/lNiJ6smek= X-Gm-Gg: Acq92OGweUnoFJkgQbhgVpy4784t4SvhJieV+rYtzIKOUNA8e5ElUPD73Onc+EgEn+E zSoKgIpKnW6nS7uV8iIsVGJIovuM0JGMxMBLDA172hXpSuVw3kYsia/mnp00+EMZ8nlIQGR0Ufr gaZ8SHEFNf68JHfvbdilUG4BcC85EHMygh4eE5TGppBVTRr0l82wE+hjXFzdRojh0+dh9Mlayys fA70saszT4hXLa62FbW64wnb9Wr2RTGERrv2FlQiTN6ID8wakVZsX4/u002yFOSHbZD6ZfSkwfv k8aN9Fgz1CnpkT8OWy7GxlS+Mw/SSh0EpTrYD3QB4wqNRqu/TtaYwAKsGlmy8+qREs2if0zOcXi /qzR2NJjQSOshCDRf+OEU1w3KMmkQJ24N X-Received: by 2002:a17:90b:4905:b0:36a:7c8f:1423 with SMTP id 98e67ed59e1d1-36a7c8f15b3mr1889230a91.9.1779471274019; Fri, 22 May 2026 10:34:34 -0700 (PDT) X-Received: by 2002:a17:90b:4905:b0:36a:7c8f:1423 with SMTP id 98e67ed59e1d1-36a7c8f15b3mr1889189a91.9.1779471273526; Fri, 22 May 2026 10:34:33 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852057f9cdsm2063203a12.32.2026.05.22.10.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 10:34:33 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Anna Maniscalco , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v9 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Fri, 22 May 2026 10:32:48 -0700 Message-ID: <20260522173349.55491-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260522173349.55491-1-robin.clark@oss.qualcomm.com> References: <20260522173349.55491-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: alAo8E8nz93ltHJmIiZ4pJxWLZQsEnjC X-Authority-Analysis: v=2.4 cv=QblWeMbv c=1 sm=1 tr=0 ts=6a1093ab cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=RIk3oTIWcAeXYnX0VHsA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: alAo8E8nz93ltHJmIiZ4pJxWLZQsEnjC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDE3NSBTYWx0ZWRfX0s3o+ZYFRBVd 4wQCgMdUjA7uQkgI9zOlVnZ559FtCZ9EibL5j0cf09CGe8tQaIMhI2KFCobWhc9tDjZ+PLg580E Hwqhavzc5cruI6fCtsstMjXQHHi51eyPjG6S4x+sjoWigYbex2VZSR5ImKpqZ9gqMtvWdlIFdh6 mOTbexGAHF5wejdKrYjxdWunhkoRktyq0XDhVDijWCVdQ+EjI/baNl/K1sq4nSvH0PoAPIsXCp8 k7QNl9ov/oCTGYaDcuPtP3zGcJfY7o5kaKRB7bUoUrJjx+WmOGUtNRfXk0fDOmabjZevGmgfDpk Yuh2PwtrrbDDhENFsrAKlKlGH0aLI4rPa8z5yyIzCcfebguowAeFBBBQsAcfFseqXHfn/MddsVr gm47qsEIB7SWWvG3WMtaTqgiyHHGC0zBgH1FRSlIObhD3VDNyGHxrnrVrE43YcLg0zczETrt5Xb iqCexg1K1AzBz7Fv3Ag== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220175 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Anna Maniscalco Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0