From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1F5F37F016 for ; Fri, 22 May 2026 19:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779479658; cv=none; b=JyvH8f1G8OUcq9Z8YtK/rzCWQDKGKbVmhl7ylQzo+pJApjA82WbJWZ3QfAdwEOH9TCcihnLDNni+OVoEZObeSVUQ36CUgv8tbFZTGzdEpH7Uv7kdstc4cmFlJFh715tAW5uk/b5SPYljkZElGF9FqVaPwBnvdB0hrAPEVNFu3z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779479658; c=relaxed/simple; bh=MCragVeqWGfwwLMtO1vbVTdRFf4q/FyUz9Na6DMFRdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xt5hObe3ryCCTcUuvvtNX6y/nYkGoknZn/mckZR3i7LWZaVD0Wtg8Pwb6yOJsoRVryoBOSjtFX8eC+tDUhEzmIWXQ8fS9NxUVY5Wg2nmV8LcgSpZ5GMOyAwgh/mwZuktVsI6ZzTf/q9NwlutBInNe2RLGKEONRFSvChVmeYbjns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mn6a3tCz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ItDcxg+e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mn6a3tCz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ItDcxg+e" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MHFO6J3947594 for ; Fri, 22 May 2026 19:54:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+J0UtrHxFLw 6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=mn6a3tCzAP7WBViZYz0o/u8Fgue y5eFgb0EtTgVQ7y6mtl/2hypXTOO5MfyQGdnfEcbpofEQHpSJCDYnt20wmDm4hC/ vmpQp/v93iy7WzUIqBKgQBv5cnSWbTMwRz7tvIa49UJ+vzDTPRV0murSmh+VW6Gg 9RbMMiG9Sm24dyUvXqabYy1yufOZGGFnCtd+v4s4unEb4Pik8Spqg/trnfOSueNb hXdrKwCmnlyzSJyo8tlT4WYuQ0rpT2mCJU4Nidj3f3gD+dd6Wcxtoy7Hq+BOGS5/ m2s0pEBvFdymiSgyyaJz+O2YAmhmIKu8+81kgghjpgf7hdccx2potdsi4xQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ean2nj7wv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 19:54:15 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba718173d1so132765865ad.0 for ; Fri, 22 May 2026 12:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779479654; x=1780084454; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+J0UtrHxFLw6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=ItDcxg+eLhfXkX7Bzp1i6U9OreTAoYXS/jlWdBh5/eN53mvFmIQKXROoj5vOt9yPD3 l3ZqnCp4S/7TU3jM4f54V6CWLfLjQXSCfkSMJE4Saey953vEOeiZQBe2Lzc8u8vfKndZ I8vf0cIE38sI+7oUxxlAKemH6FOWv3WSTZMz9QkbKIAbBC1hbQlzAXy21EP1vqDIdruR 4aW48UlFm5OxE89hm9i0pvALwqb40JsYogLs4Kq9AWLmAqMw414F/zOY9XsMeu0M9YM+ k3lmZL+F5M5hURa2Yzx7sAqBWapsW0qScwhYynUk60kiV9sE8GnoArX4Uj1itegU8itu nSFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779479654; x=1780084454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+J0UtrHxFLw6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=aJhhUrqEFjPU/jCkBObko4kf4wX+rCXkpZzfRnUgyhXTUtG7SdESB9wLHy1aPkQa40 wHXZeuiTbPo6g8HGg6/YbV3Jq/PImnbtA6xeGIeGrXzocRYvHGapLSRJRzcSST5Cwt1+ 6n7oWfOMq0DtGGF5/JpwolGXLsFmAImPjv2gwY97AidtozTOsj2qdIicnSBkQQL81rJ/ ilb3Dz1SpI23a5VlPB07FIBWAQy+XYCRI7RgAksGn7uQUgaKMyahqXBbaMnzZnq5PAE+ 875S/+K2RFxortMYOgo2204ABxD7yg5/oof4LcP1QT3G98tdECcyc9OM1VGciXAvJ/fp sKVw== X-Forwarded-Encrypted: i=1; AFNElJ/bS8Y/ySeo4lTYZvTlUvSThbZukU21BgjAwwUL0bwLklOd4fkM9/uB74zS0sKTOwc0eRQ3Wj8/TNq9pm4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz02sThuD5kZrZjaGMjsNyEEdKlz9M39i93uVsfu8RS23BmYF0L mMMgm42KwL+rXHanyxCdi0pyVV/07RDmcf14GyqKOJ/9CKIv9XeHqDTiGB1T7uksJ2X7jKJIy42 0j8mT3kADEn1An+ATcDo2dRq6PJ1BiWINCc6qnO4RiBBYv28SrbltYKErKzP1Vn5qdVQ= X-Gm-Gg: Acq92OHizuQh64bKurn8DSYORl2x98lfzpDmf4dT1zmxlx+8efC/3vxmdjPvheX12OY JIE1zulsW5l5tDNqzl67fhdlW0xx3+ZjoMdmxZY1wJt/doAaZ/ecqQZfJoetTvTWOHXGU7EvXN1 0rUFEkop1tf8U8wOwhMuMhGFPng8Pvvu/gmMLQfzBhBL44Pk1kYOIZODped/3/b7wVBzSrHnOFv 8+IGCv3gX4PEowWLXDtuTzN1yEOYaW3QdbZHxx76Sqza/DMOcozcPFguASdtK+Wuv+doFx48s0x 9pHdBErPziyLMvTxUKBFy7TZGa1oNWlHxPsSfJt62KevbwUcNjBA+vXlZhXzRtnFCTbQnpSW6s3 pX+2gN8Pxe1lyW8vmlPN3fihy1/HMj2TEeiI2j68BWBt9HxYr X-Received: by 2002:a17:902:f650:b0:2ae:55eb:f82d with SMTP id d9443c01a7336-2beb038f177mr60344175ad.1.1779479654343; Fri, 22 May 2026 12:54:14 -0700 (PDT) X-Received: by 2002:a17:902:f650:b0:2ae:55eb:f82d with SMTP id d9443c01a7336-2beb038f177mr60343705ad.1.1779479653866; Fri, 22 May 2026 12:54:13 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb5695f05sm33541155ad.6.2026.05.22.12.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 12:54:13 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio , Dmitry Baryshkov Subject: [PATCH v3 03/18] firmware: qcom: scm: use dev_err_probe() for dload address failure Date: Sat, 23 May 2026 01:19:54 +0530 Message-ID: <20260522195009.2961022-4-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522195009.2961022-1-mukesh.ojha@oss.qualcomm.com> References: <20260522195009.2961022-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=XvDK/1F9 c=1 sm=1 tr=0 ts=6a10b467 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=GEQWD5Nhug1BhVu3dP8A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: bF-zct70Sp7-9XdqkWYhU2x7be6dGoi3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDE5OCBTYWx0ZWRfXz9eaEG4P/HHk UwEncBklB4zKrYbN0tOtd/ak3H7JdEN3bfcjCuDtoeGCbgOd0qFxQe0AeCZmywpjaTvnTLNFdQR 9NiftMeDIKlem2cer6pF5aT2lNvwwfEnfN+IMDzUTq5tiq7K1LrImoAjICHamFScjNhXW5epxja yj2ClV8xbI9a3z1BNp1KqaehEQeze+tIQTE6htAOM3NprC2O4m5V2DL5mIxSMj5/zzAJxzBWCWo gAKlaGpS7PTftrtOlHRV0W6cRKQrz8d9H62N59pDVgUpjTWECnkT/5eFKV4my2SvJuG4vchJt+P AStbwVH1hnc2HUo93O3NqWpLBJ/SiwS4YabqBqYckg0NUjRr4Pl4Azm4nsxA2aHdUo/7eBQEVAb k+iXwYCDZDJomhHmimANbFk71cUH5AfkG71BX68xrI0olCJ030lgvU/C/funX5ppfmUhzUOz8rX Cs0eOXhydRClGH3eKjQ== X-Proofpoint-ORIG-GUID: bF-zct70Sp7-9XdqkWYhU2x7be6dGoi3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_05,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220198 Replace the bare `return ret` after qcom_scm_find_dload_address() with dev_err_probe() to produce a consistent, deferred-probe-aware error message when the download-mode address cannot be resolved. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 9b06a69d3a6d..52432469badc 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -2747,7 +2747,8 @@ static int qcom_scm_probe(struct platform_device *pdev) scm->dev = &pdev->dev; ret = qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr); if (ret < 0) - return ret; + return dev_err_probe(&pdev->dev, ret, + "Failed to get download mode address\n"); mutex_init(&scm->scm_bw_lock); -- 2.53.0