From: Andrew Morton <akpm@linux-foundation.org>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam.howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH 0/7 v2] mm/memcontrol, page_counter: move stock from mem_cgroup to page_counter
Date: Fri, 22 May 2026 21:00:31 -0700 [thread overview]
Message-ID: <20260522210031.6d5e0debd687b39b87c87501@linux-foundation.org> (raw)
In-Reply-To: <20260523025051.170871-1-joshua.hahnjy@gmail.com>
On Fri, 22 May 2026 19:50:50 -0700 Joshua Hahn <joshua.hahnjy@gmail.com> wrote:
> On Fri, 22 May 2026 15:06:18 -0700 Joshua Hahn <joshua.hahnjy@gmail.com> wrote:
>
> > Memcg currently keeps a "stock" of 64 pages per-cpu to cache pre-charged
> > allocations, allowing small allocations to avoid walking the expensive
> > mem_cgroup hierarchy traversal and atomic operations on each charge.
> > This design introduces a fastpath, but there is room for improvement:
>
> This iteration was developed and tested on top of mm-stable.
> I'm seeing now that Sashiko cannot apply this patch, and I think it expects
> it to have been built on top of mm-new.
>
> Reviewers -- would it make sense to rebase this on top of mm-new and
> re-send this as a v3, or should I wait for feedback on this cycle
> before sending out a new version?
>
> In any case, this could have been avoided if I just developed on top of
> mm-new. I'll be mindful to do that in the future.
Sashiko does attempt various branches, including mm-stable so I'm not
sure what went wrong here.
It's a bit of a crapshoot at this time, as mm-new is still growing like
a weed (19 patches yesterday, 24 so far today). Slowing way down soon!
I'll be pushing mm-new later this evening and after that it shouldn't change
much for several days because we all take weekends off, don't we?
Convention appears to say "wait a week before resending" but IMO
there's value in parallelizing Sashiko review with human review. And
it's understandable if some humans aren't very motivated to review
until the AI thing has had a shot at it, because that might result in
alterations. So I'd say that a resend-for-Sashiko is appropriate.
prev parent reply other threads:[~2026-05-23 4:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 22:06 Joshua Hahn
2026-05-22 22:06 ` [PATCH 1/7 v2] mm/page_counter: introduce per-page_counter stock Joshua Hahn
2026-05-22 22:06 ` [PATCH 2/7 v2] mm/page_counter: use page_counter_stock in page_counter_try_charge Joshua Hahn
2026-05-22 22:06 ` [PATCH 3/7 v2] mm/page_counter: introduce stock drain APIs Joshua Hahn
2026-05-22 22:06 ` [PATCH 4/7 v2] mm/memcontrol: convert memcg to use page_counter_stock Joshua Hahn
2026-05-22 22:06 ` [PATCH 5/7 v2] mm/memcontrol: optimize memsw stock for cgroup v1 Joshua Hahn
2026-05-22 22:06 ` [PATCH 6/7 v2] mm/memcontrol: optimize stock usage for cgroup v2 Joshua Hahn
2026-05-22 22:06 ` [PATCH 7/7 v2] mm/memcontrol: remove unused memcg_stock code Joshua Hahn
2026-05-23 2:50 ` [PATCH 0/7 v2] mm/memcontrol, page_counter: move stock from mem_cgroup to page_counter Joshua Hahn
2026-05-23 4:00 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522210031.6d5e0debd687b39b87c87501@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®