From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9DC7391836 for ; Fri, 22 May 2026 23:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779490925; cv=none; b=AoHMDxN5ZLxcGaCD28C0AXvsKbgMy6mScvKtIvqcfNJlK8uDi/elWoUeNvOS6YjUkX4WtbFMeBPtOBQ+todF6emqtyq4PoXX0Vi4G/r83qm/qfkwnfPMfvspS5nu+RrCgoOOdVM+BHmX90UkgL9PJXzNnpQDArAxt1ExWmRNvJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779490925; c=relaxed/simple; bh=5t9imB8TQUpIuhr2NaXIAgQ086dM4YJDsGiJoMdidVE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eYOzfNoZ0tLTHfm+AwoQB6CEx9iNYusiI4Ku6bZPA5Dxzpu+1BqnE4CAAhJ+qLWgj7FJkXmOis88h01YvqD7TkJJmz+swXyqgmjD5t1CblHpDcsQs1Whf0S0HFctIIrVQobA8YDD0efiEUpXyOlJ8jHahcZp74SD5We/L/rjaWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eFSkcNjs; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eFSkcNjs" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44b7e8b65faso599541f8f.1 for ; Fri, 22 May 2026 16:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779490913; x=1780095713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CYnl6H7JNYvzOK1yTCqArfWOoQ9aVJm0Lozs66ZGulI=; b=eFSkcNjsPZS3FJs3s6NrviCofWhwl+DyXZls+h4VK/QK2jdZj9Nn6WBFEVbUDg+MSF qPrrXQOiuh1tDYKDkNoQcmmcuErigjPCvlOekFBaFxCifnlK/jT18gxyCZca8rkGkkJC tOTDrQH8hUS9RQOjICHKC7oPABZ4lLRyl1oMqBTGfiHoJ2o9sX4fOz1zrjyU/BarJemd 8lzQV+EjnCgVHmnGhteiMl6vlpP1K+UFHWYC53amMkzRwmWNcA7pd4o5g6MnQIedu4RF JoyxrwME8A6fjXjbjaRFSj8xIEsKsIUUWK8lelu65d/d5lrSdCBqDFuK+jbQmfhZUCya 7Xqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779490913; x=1780095713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CYnl6H7JNYvzOK1yTCqArfWOoQ9aVJm0Lozs66ZGulI=; b=RpzfXbPLVgbnIhKamMwOORsIeD7ezMVI+VWQ3e2sQKloo/JZNUZZc8aW3QR+7/P20t /fAMDjLRXQuRbTMbAuM/G4qxjzfnjikyfOjAI08Yr1ywEqqKDempcIin2Z2D19OCfZSA pZDJI1/bwByxVC6PiuZZ2MNSYhanON7gmW1KtH3I/Oxrt0kzHfOptNaxrqqTNbuchii0 2h7U6THDt7lm12ZmoIOA5KT3ZtVJ9l4O9hsel9ZavUrrrr0Q7jARnJu9ht2Jb6Nn14hf PZsZqnGXZyMUj+FVSlBaPgNIluaLBzxYqJjVxyvYqACrMD2YJIKaWfGaia0R+WR/H37Q q7iw== X-Forwarded-Encrypted: i=1; AFNElJ/TK/dNizEzAN+ma3SOTeVCrUPKZ/vK8GgWspgGcXHXeDMwV6JvC5abMJRuB5p4NmzKpXLBBhRwgbCXZaY=@vger.kernel.org X-Gm-Message-State: AOJu0YzPTJOevQY05Vj6jQW9tjMEMJIs537S8Y30nAm9w2ZV5jHPigwd 9gYfy3mr6lzVYubKEPObHwh0QKxiIz1a43uCykVFz9tX3q4PEkRbHmKC X-Gm-Gg: Acq92OHFaD0lHdGgBJqpcsAhMpJGwXR2Dxk66o96siruSPyHbGSCcPZUs2M+YQwEvPS m/vud/CCLyGjYyeI3zcBkuLdGypX08x1G5XWroI1nJT57EMFLayuU0FZwRe2wHSkBQ0i1XlD50K x45h+nDeO24zNOaFxIiZVgvUvN7i/hiQ+fiCo7FQS8VfAkN3w3TM7nco5A7AWfoVwsiiByCHdyd pmCXakYh/QzZrf7XHxRfAh7b2L8gjmCiF22iAxCB7jJLkP+AVXlEmHE/uJC2Z0nDGkn8zTLUHce SrFYLw1k+4TgAOha/wn6Iq/XeuWCjQemtBa1hXdTnnGnKvrh0AWfiE/eItAEocJgg+ma6dNAXKg ar9BwfJ2r64FUXsts/x4lRoyMv+44/FNU7pBS0zCCriXj0MFGkB+u1OivLxPDTr/IfFSCGRIhfi AB/H0KPKTZAcVEMp8XdGH119PoWZXoaZNToDtVXOfFLq14EuvVzcMt6T6pKhpx7Sc= X-Received: by 2002:a05:600c:444e:b0:48e:7a10:1f5e with SMTP id 5b1f17b1804b1-4904248ab61mr37470595e9.2.1779490913007; Fri, 22 May 2026 16:01:53 -0700 (PDT) Received: from menon.v.cablecom.net (84-74-0-139.dclient.hispeed.ch. [84.74.0.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490456274ebsm67100265e9.15.2026.05.22.16.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 16:01:52 -0700 (PDT) From: Lothar Rubusch To: thorsten.blum@linux.dev, herbert@gondor.apana.org.au, davem@davemloft.net, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, tudor.ambarus@linaro.org, ardb@kernel.org, linusw@kernel.org, krzk+dt@kernel.org Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, l.rubusch@gmail.com Subject: [PATCH v4 10/12] crypto: atmel-i2c - implement capability-based client selection Date: Fri, 22 May 2026 23:01:32 +0000 Message-Id: <20260522230134.32414-11-l.rubusch@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260522230134.32414-1-l.rubusch@gmail.com> References: <20260522230134.32414-1-l.rubusch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend the shared I2C client allocation interface to support feature-aware hardware selection by introducing capability filtering. Add a 'caps' mask to 'struct atmel_i2c_client_priv' alongside an 'atmel_i2c_capability' enum. The allocator now explicitly filters hardware nodes by a requested capability bit while retaining the least-loaded device load-balancing scheme. Update the ECC driver to advertise ATMEL_CAP_ECDH configuration capability during probe, and adapt the tfm context setup execution path to request this specific capability variant. Initialize the bitmask field to zero inside the SHA204A driver context for now. Signed-off-by: Lothar Rubusch --- drivers/crypto/atmel-ecc.c | 4 +++- drivers/crypto/atmel-i2c.c | 6 +++++- drivers/crypto/atmel-i2c.h | 8 +++++++- drivers/crypto/atmel-sha204a.c | 2 ++ 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 16e607cd06c4..76b8f9e7c2e1 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -212,7 +212,7 @@ static int atmel_ecdh_init_tfm(struct crypto_kpp *tfm) struct atmel_ecdh_ctx *ctx = kpp_tfm_ctx(tfm); ctx->curve_id = ECC_CURVE_NIST_P256; - ctx->client = atmel_i2c_client_alloc(); + ctx->client = atmel_i2c_client_alloc(ATMEL_CAP_ECDH); if (IS_ERR(ctx->client)) { pr_err("tfm - i2c_client binding failed\n"); return PTR_ERR(ctx->client); @@ -287,6 +287,8 @@ static int atmel_ecc_probe(struct i2c_client *client) i2c_priv = i2c_get_clientdata(client); i2c_priv->ready = false; + i2c_priv->caps = BIT(ATMEL_CAP_ECDH); + spin_lock(&atmel_i2c_mgmt.i2c_list_lock); list_add_tail(&i2c_priv->i2c_client_list_node, &atmel_i2c_mgmt.i2c_client_list); diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c index 92d3e28f9d9a..4953b8fcb02d 100644 --- a/drivers/crypto/atmel-i2c.c +++ b/drivers/crypto/atmel-i2c.c @@ -57,7 +57,7 @@ static void atmel_i2c_checksum(struct atmel_i2c_cmd *cmd) *__crc16 = cpu_to_le16(bitrev16(crc16(0, data, len))); } -struct i2c_client *atmel_i2c_client_alloc(void) +struct i2c_client *atmel_i2c_client_alloc(enum atmel_i2c_capability cap) { struct atmel_i2c_client_priv *i2c_priv, *min_i2c_priv = NULL; struct i2c_client *client = ERR_PTR(-ENODEV); @@ -75,6 +75,10 @@ struct i2c_client *atmel_i2c_client_alloc(void) i2c_client_list_node) { if (!i2c_priv->ready) continue; + + if (!(i2c_priv->caps & BIT(cap))) + continue; + tfm_cnt = atomic_read(&i2c_priv->tfm_count); if (tfm_cnt < min_tfm_cnt) { min_tfm_cnt = tfm_cnt; diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h index ddab80bc1a72..af2e49332ab6 100644 --- a/drivers/crypto/atmel-i2c.h +++ b/drivers/crypto/atmel-i2c.h @@ -115,6 +115,10 @@ struct atmel_i2c_cmd { #define ECDH_PREFIX_MODE 0x00 /* Used for binding tfm objects to i2c clients. */ +enum atmel_i2c_capability { + ATMEL_CAP_ECDH = 0, +}; + struct atmel_i2c_client_mgmt { struct list_head i2c_client_list; spinlock_t i2c_list_lock; @@ -131,6 +135,7 @@ extern struct atmel_i2c_client_mgmt atmel_i2c_mgmt; * @tfm_count : number of active crypto transformations on i2c client * @hwrng : hold the hardware generated rng * @ready : hw client is ready to use + * @caps : feature capability of the particular driver * * Reads and writes from/to the i2c client are sequential. The first byte * transmitted to the device is treated as the byte size. Any attempt to send @@ -149,6 +154,7 @@ struct atmel_i2c_client_priv { struct hwrng hwrng; struct completion remove_done; bool ready; + u32 caps; }; /** @@ -193,7 +199,7 @@ void atmel_i2c_init_genkey_cmd(struct atmel_i2c_cmd *cmd, u16 keyid); int atmel_i2c_init_ecdh_cmd(struct atmel_i2c_cmd *cmd, struct scatterlist *pubkey); -struct i2c_client *atmel_i2c_client_alloc(void); +struct i2c_client *atmel_i2c_client_alloc(enum atmel_i2c_capability cap); void atmel_i2c_client_free(struct i2c_client *client); void atmel_i2c_deactivate_client(struct atmel_i2c_client_priv *i2c_priv); diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index 33e5a66b843c..0c5b5cdbfcbc 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -178,6 +178,8 @@ static int atmel_sha204a_probe(struct i2c_client *client) i2c_priv = i2c_get_clientdata(client); + i2c_priv->caps = 0; + memset(&i2c_priv->hwrng, 0, sizeof(i2c_priv->hwrng)); i2c_priv->hwrng.name = dev_name(&client->dev); -- 2.39.5