From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33309330641; Sat, 23 May 2026 19:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779565644; cv=pass; b=NuEQyHMFPXFh/lhKvnAa/hgUik+vhDpI43DfxVIIEjnPc0JlFNy5Gc3dmO0pshCJa01l7iSOwLs6r1si/OF1+OzBp7AFecJ1EKxWxNncaLnORmTQy+0kNFpGkWKiQIuV2cbqPHrrbBWPNNahDVSNcvWWTin0R/DpO7xLftfk4cE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779565644; c=relaxed/simple; bh=v1GA2mYldnLXUA2z2YE9InJNo6zJFyotg8UDSwGjK00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tplyAS6lpaL8J8MD9wAhKRDrtStlNyHuR8AN8a/ZjYtZzi8FSGn3CJogtGxX2giyBfc5TKKBcqXjhwnsrRzcjFL95b9WvZkoPP8zBEZn6+wmBwgGKWShdsPjh2fIKkkMdaukBN4ydBJJP4ctn50CYQVKLtHHh2vj+c6XF35LWIY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=E97PahUT; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="E97PahUT" ARC-Seal: i=1; a=rsa-sha256; t=1779565602; cv=none; d=zohomail.com; s=zohoarc; b=hE21EA1vl4B+sZkhT7os+r5stZqGItYxQ6je3zhspVBkqKD3QXUOv2dqMGSajXB91/SntsTo/ra276sQ2+9lai2oDc5nm+SjvXby6c1VX33OLXb/X48Km+gsuLc0H4AzQYWN4Rv0SxINW28TCPkMBcgGeY5v0n7tcEIgXKE8h6U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779565602; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=11mrw5ERpgGzjDqAImvICD/uybnyecRT/PgLC2hXYL4=; b=nPkpe6feDq3zFSmb8ZCQmXt3UlMxrpPQNXs3jvlpFhX1bjXr2FbnS8Fmy5X7t3woBkrS4ThSHyvCN0o8fi/HsCWfPOb5TVRQ3bZGX6MqXQR7t9lWSuAUE7JSdXPJ4BaxhbMpPElrdHyzkq+eD4IVaKDzlxjfvY28r8Ptw1FuzKo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779565602; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=11mrw5ERpgGzjDqAImvICD/uybnyecRT/PgLC2hXYL4=; b=E97PahUT+jYCDDKWt1CdraS7l2peI1T/SgnoDQigOLlktayz2XGQVu/QTMul48Lk eusmiold/+vZiYVJz4MkU9hqAY5/AO8pCTnHtaXOj+1EoMNolAajp6soHoaKH+dh3jj T8l5JM1g5D+HyNa1RMnKCpon7DqwmJiNmydgahmA= Received: by mx.zohomail.com with SMTPS id 1779565601318512.2082188037197; Sat, 23 May 2026 12:46:41 -0700 (PDT) From: Nicolas Frattaroli Date: Sat, 23 May 2026 21:43:49 +0200 Subject: [PATCH v16 14/28] drm/i915/dp: Implement "color format" DRM property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260523-color-format-v16-14-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> In-Reply-To: <20260523-color-format-v16-0-24340c5e4732@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , Daniel Stone Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.15.2 Implement the "color format" DRM property for DP. The values of the property include RGB, YCbCr420, YCbCr444 and Auto. Auto will pick RGB, with a fallback to YCbCr420. The mask of supported formats by the source exposed by the property is an optimistic scenario, as specific DFP-related caveats can't be established before an EDID is present. Should the explicitly requested color format not be supported by the sink (or by the source in combination with the sink), then an error is returned to userspace, so that it can make a better choice. Reviewed-by: Daniel Stone Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/i915/display/intel_dp.c | 61 ++++++++++++++++++++++++++++++--- 1 file changed, 57 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 380933579178..041e40c3ae8a 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -3435,10 +3435,10 @@ intel_dp_compute_output_format(struct intel_encoder *encoder, } static int -intel_dp_compute_formats(struct intel_encoder *encoder, - struct intel_crtc_state *crtc_state, - struct drm_connector_state *conn_state, - bool respect_downstream_limits) +intel_dp_compute_formats_auto(struct intel_encoder *encoder, + struct intel_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + bool respect_downstream_limits) { struct intel_display *display = to_intel_display(encoder); struct intel_dp *intel_dp = enc_to_intel_dp(encoder); @@ -3474,6 +3474,34 @@ intel_dp_compute_formats(struct intel_encoder *encoder, return ret; } +static int +intel_dp_compute_formats(struct intel_encoder *encoder, + struct intel_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + bool respect_downstream_limits) +{ + switch (conn_state->color_format) { + case DRM_CONNECTOR_COLOR_FORMAT_RGB444: + return intel_dp_compute_output_format(encoder, crtc_state, conn_state, + respect_downstream_limits, + INTEL_OUTPUT_FORMAT_RGB); + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR444: + return intel_dp_compute_output_format(encoder, crtc_state, conn_state, + respect_downstream_limits, + INTEL_OUTPUT_FORMAT_YCBCR444); + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR420: + return intel_dp_compute_output_format(encoder, crtc_state, conn_state, + respect_downstream_limits, + INTEL_OUTPUT_FORMAT_YCBCR420); + case DRM_CONNECTOR_COLOR_FORMAT_AUTO: + return intel_dp_compute_formats_auto(encoder, crtc_state, conn_state, + respect_downstream_limits); + default: + MISSING_CASE(conn_state->color_format); + return -EINVAL; + } +} + void intel_dp_audio_compute_config(struct intel_encoder *encoder, struct intel_crtc_state *pipe_config, @@ -7027,6 +7055,29 @@ intel_dp_has_gamut_metadata_dip(struct intel_encoder *encoder) return false; } +static void +intel_dp_attach_color_format_property(struct intel_dp *intel_dp) +{ + struct intel_connector *connector = intel_dp->attached_connector; + struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); + unsigned long fmts = BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444); + bool has_pcon = false; + + if (!connector) + return; + + if (dig_port && intel_bios_encoder_is_lspcon(dig_port->base.devdata)) + has_pcon = true; + + if (has_pcon || source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR420)) + fmts |= BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR420); + + if (has_pcon || source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR444)) + fmts |= BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444); + + drm_connector_attach_color_format_property(&connector->base, fmts); +} + static void intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *_connector) { @@ -7059,6 +7110,8 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *_connec if (HAS_VRR(display)) drm_connector_attach_vrr_capable_property(&connector->base); + + intel_dp_attach_color_format_property(intel_dp); } static void -- 2.54.0