From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76FA3335081; Sat, 23 May 2026 19:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779565586; cv=pass; b=Q77dRpzOakeQGyNkW+YTr3b7sC2KGBtjia3RPbIa4z27xnIWzR4sdif+xZxNWUoXaCrd46gUV/0b07KKUg8X1W8YVAU6e+BWpirOLZgWGGgthnGCJvArHNlt0Nye7KRkZFNvGrvDomLGcIhsVST00H46RIfyk2hEL63VTFeK6ns= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779565586; c=relaxed/simple; bh=EmKuqnO90Xwr7Cg55wBBzgxTj4MAwShsOSXmsU66cmE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d6iy18whJFyC2f4xvQP6/byeFDPgvznANAaU5Kb62lhs3IapC9rChW4cLlddFWM2UiU/7Ljt5IQHJ1IemeSNcB0QKZHmz7dmaE/t7m7RTecV2VGfhfPwQ+oz+xhzH5iQH7VO9+NujGq5yGEC+QgjknjLugruehZAsA5BCMlblFo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=GzphpZfj; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="GzphpZfj" ARC-Seal: i=1; a=rsa-sha256; t=1779565550; cv=none; d=zohomail.com; s=zohoarc; b=gZayjQGh5Tqko1XKQhUAQorxr+WJfW5bgLoVX5OzrbHssGHYieOj/5aoEtHjKqlAJp6REo0c3uHRku12nZjXyOIi59+h5P8J67HosV7r3z4R+gBCWvqY9d0rJiV+VAJUO3VzVMFjyrWKms0BU2vKqc3vWQLzSUCjE1+RFoyRDgs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779565550; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=GG7N+YpF5OPbnblpOFH2Ooa+APF+6Jj/DXhtPAgCpt8=; b=Nj+HzcKKU5DhrQDuEVE8gdixO8/UOqrpvfHWiYmYJuFx9Azj2loi67vCRa2OO0UIkMP9SICoh/BHpg2kuPT9pHnYocG919CIEAM6SXnevvb9uWZSuXs3fNqRRx5KRHkOalMoR2dCYCKQTuzzJZ82kFKgAqXU3hsCz1JN6iEn/Xs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779565550; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=GG7N+YpF5OPbnblpOFH2Ooa+APF+6Jj/DXhtPAgCpt8=; b=GzphpZfjr7L3VyvyZzuFAD1QOpgxawa/jOIQhuOiHeowdmjtIzkVZ8PKvjRK2n99 Ql+bLDITKDZ8Z/f8dRgTV8a0TGHC4i6kL66ppCT4pskULNjzYqRa/ahGPypxtSkK+l5 Ng/KzL4ItD8jUPXJduCWxBwHEL83YCVug8kuCQXU= Received: by mx.zohomail.com with SMTPS id 1779565548563230.4219044231827; Sat, 23 May 2026 12:45:48 -0700 (PDT) From: Nicolas Frattaroli Date: Sat, 23 May 2026 21:43:43 +0200 Subject: [PATCH v16 08/28] drm/display: hdmi-state-helper: Act on color format DRM property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260523-color-format-v16-8-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> In-Reply-To: <20260523-color-format-v16-0-24340c5e4732@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , Daniel Stone Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org, Nicolas Frattaroli , Dmitry Baryshkov X-Mailer: b4 0.15.2 With the introduction of the "color format" DRM property, which allows userspace to request a specific color format, the HDMI state helper should implement this. Implement it by translating the requested drm_connector_color_format to a drm_output_color_format enum value as per the logic HDMI should use for this: Auto is translated to RGB, and a fallback to YUV420 is only performed if the original color format was auto. Reviewed-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard Reviewed-by: Daniel Stone Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 31 +++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c index 3ba47564caad..1c54e6feac61 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -670,8 +670,39 @@ hdmi_compute_config(const struct drm_connector *connector, unsigned int max_bpc = clamp_t(unsigned int, conn_state->max_bpc, 8, connector->max_bpc); + enum drm_output_color_format fmt; int ret; + if (conn_state->color_format != DRM_CONNECTOR_COLOR_FORMAT_AUTO) { + switch (conn_state->color_format) { + case DRM_CONNECTOR_COLOR_FORMAT_AUTO: + drm_warn(connector->dev, "AUTO format in non-AUTO path.\n"); + fallthrough; + case DRM_CONNECTOR_COLOR_FORMAT_RGB444: + fmt = DRM_OUTPUT_COLOR_FORMAT_RGB444; + break; + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR444: + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR444; + break; + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR422: + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR422; + break; + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR420: + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR420; + break; + default: + drm_dbg_kms(connector->dev, "HDMI does not support color format '%d'.\n", + conn_state->color_format); + return -EINVAL; + } + + return hdmi_compute_format_bpc(connector, conn_state, mode, max_bpc, fmt); + } + + /* + * For %DRM_CONNECTOR_COLOR_FORMAT_AUTO, try RGB first, and fall back + * to the less bandwidth-intensive YCBCR420 if RGB fails. + */ ret = hdmi_compute_format_bpc(connector, conn_state, mode, max_bpc, DRM_OUTPUT_COLOR_FORMAT_RGB444); if (ret) { -- 2.54.0