From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4573634C9AC for ; Sat, 23 May 2026 07:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779520523; cv=none; b=b+VrOeVCECa7r9XeLW5C//U3YIa4lNpDF09hgn5U1zRIJG9+FD0dZIJcI9pYQoFdZF2wVwL8Pb7MgSJ6tqb2xwHhKbL8sStql95GUoy88sF57fcQ7veBUXRyvRMjI3gx2eJsfSx3LhPxbZe3A5Wk5VJlMw084Dl5KJ4Mw8lisyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779520523; c=relaxed/simple; bh=zY26AoTDT5sXs+cwH/35lsu5KHT7UoaJFyISX4/PEiA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PaAmKe2H0z1j9S2h7qAaHgEtcSkqbBsmmPyE/kH8cfDRIo/MTpZbPGCSi9AcA3aYrSDSsLQM4B6qm11jOy5bXJOc5cinVHUOMIehsJ0DY8gWKPMgkzKyrMoXGJbOM6Dt4OoRRb0kKvUoZ+1bLh7gTOKH9S4Q608ILF2GEC88tDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q1/6ALyK; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q1/6ALyK" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4526a8170ceso4024419f8f.2 for ; Sat, 23 May 2026 00:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779520520; x=1780125320; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UrPKdNKgj6LivKrqLr8CgMfwExcBZv4b+V8NB+o2xak=; b=q1/6ALyKibzj3o6aDV1YE50rTA6024QvKw3ZMDxGxL4M8KD4ulePXnYjLcYZV6Dm82 D0/JSnDgtpuyRGAA3X773ftyiBUFTqFmNzYWNY/kEhXRabRuJTbtMKdqB+ZQayX3o8li tYwV4bq0mCoFzsJfaWB7E2y4kwgGuOvDw8oBJDsA8872pW1uPo00o3M6PTg11vt0pH/2 qLjiqBKEo/nJUh2Ctjc7Pd/vE2MnjOKqwTZz35lBkxdnaNZ7JZySICIStiqMQEhbo/Sj w2hSkv7Rf6Y31QWsi7rHTIul8z90/l8t8UQebTv91J06loPE4m3c0uGIDJyots/FHK5o T1ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779520520; x=1780125320; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UrPKdNKgj6LivKrqLr8CgMfwExcBZv4b+V8NB+o2xak=; b=J5j28O4KcsX8uw7BQbaJ3x6QxCD8kPpcLg+Bq8WgZpyWumzz8W06pO3KNw8bzBW+mH De9BWl95ONOakhk/b7A3Son9fyo0jIDc/HG1R7n0XK+silHnpn5H6a8DTmlLdjVdM370 62e0UZUH3cFMd9LIpe/wvk6tGGE7xxKVMdG5VOZZG6Ph3g9LefvSjosz3C0vhN5L7etq MSB15yeL1ghKSlQ4jSZ1nPDz9xOfiXuNW7cjxdjRhwxK2h2eEGtFB4O0AnTr8H+B49kP fWyPRzHINqC6rqQ4w0LFLzHJ/kQS2nVeUp3xDN+QlUM+EJ/Pe8gdqfSoviTicwEqMs6f SyBA== X-Forwarded-Encrypted: i=1; AFNElJ+on0w4H4CY3XUNdqP3b8/LqKPU/b+B8aDhSty0SZQKeMfox6NNR8SyMzM4COm7IXe5KlqA8wojwBcL9nw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+aBtFygKqjHGKRevmBOePzsdXO5qqw5AFa9j2Xb0Cg3hWCVDj Fzsjd67oYW5CB8nO+jNxr0rRcLPmTsyO3dPiI70lGBx/yN1CA93mcpwD X-Gm-Gg: Acq92OEsAoz+IqUvHw1YukR7+q3UeHMcx2BKQkjP6FFcgJEJlHaGp5ifO6nE7chtQ0l aN4jdzs0cAvbjW+uEnW/C+ix6gnFNBF+zXeM+1CAaC6FpRJYgMrLEtyrFwr4aWAnsQYyflq3OI0 k1blDDsGUZeRjueIPxoVRYlhq0H3UWTymEvCpdjm6Ttsf60Qy3rofZ2MzMvSNtVus2DAuPz7b8s h0a+WYygkXf1IvfXUrd/q+1WhxlszovApw/tOjEuZqzR5LyGIq2PLUNE4CJbtZLfjJO7Vs3t2EA 0LkZfSIT2k6eRyBXURRkub4kK2Wb7CsXhPiPglPCCQdEJocL8aC0u3GFgy+6GWH/Ze4Xjz+PKtA 6ws6cuyjYhHSRvpuKU5y5boTKud9jvBKYP/cl+juEE1wwI/dvFZlbtPMUO9tXfvhQYTpi8Prix+ 6eAcI1PhykAJ2Jjmd6rStKZEjF/4Ae X-Received: by 2002:a05:6000:2889:b0:45e:5b92:1e45 with SMTP id ffacd0b85a97d-45eb38c7d20mr10565597f8f.40.1779520519421; Sat, 23 May 2026 00:15:19 -0700 (PDT) Received: from [192.168.0.174] ([31.96.183.250]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-45eb6d5cb76sm8639838f8f.25.2026.05.23.00.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 00:15:18 -0700 (PDT) From: Jim Cromie Date: Sat, 23 May 2026 01:14:46 -0600 Subject: [PATCH v2 13/24] dyndbg: reduce verbose/debug clutter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260523-dd-maint-2-v2-13-b937312aa083@gmail.com> References: <20260523-dd-maint-2-v2-0-b937312aa083@gmail.com> In-Reply-To: <20260523-dd-maint-2-v2-0-b937312aa083@gmail.com> To: Jonathan Corbet , Shuah Khan , Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Shuah Khan Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779520485; l=4656; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=zY26AoTDT5sXs+cwH/35lsu5KHT7UoaJFyISX4/PEiA=; b=L2RL4t6UeiHcEGIX7kfDlIJ3EmHkqwuLl8YVbLdl0/jhDPOyxEy1b8gUT+0am8u8QIKmPveZD uy88jHV84ClDGG73VhFpecIhC0yryh1axgP4R06jKvH8P0W/nSkUzUT X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' flags=0x1 maskp=0xffffffff dyndbg: processed 1 queries, with 0 matches, 0 errs Also drop several verbose=3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v2: RvB after SoB trivial change to verbose-debug output line to output the actual "module" keyword rather than "mod:", and do so only when the module is constrained by the callchain (ie as part of a modprobe). was: query X: "(keyword value)* [+-=]flags" mod:* now: query X: "(keyword value)* [+-=]flags" or query X: module FOO "keyword value)* [+-=]flags" IOW, adjust output to reflect the input grammar more closely. --- lib/dynamic_debug.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 6d9dbeb68ae8..dfed3725aa44 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -277,9 +277,6 @@ static int ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } @@ -512,7 +509,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -526,7 +522,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x\n", modifiers->flags); /* calculate final flags, mask based upon op */ switch (op) { @@ -542,7 +537,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask); return 0; } @@ -552,7 +547,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) struct flag_settings modifiers = {}; struct ddebug_query query = {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; nwords = ddebug_tokenize(query_string, words, MAXWORDS); @@ -570,10 +565,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound = ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } /* handle multiple queries in query string, continue on error, return @@ -594,7 +586,8 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - vpr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*"); + vpr_info("query %d: %s%s \"%s\"\n", i, + modname ? "module " : "", modname ?: "", query); rc = ddebug_exec_query(query, modname); if (rc < 0) { @@ -1160,11 +1153,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); dt = kzalloc_obj(*dt); if (dt == NULL) { -- 2.54.0