From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400D835F5F3 for ; Sat, 23 May 2026 07:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779520534; cv=none; b=mWPisnl70fq6K2VXPBreub5G3PtPPjkXhpMZGIV7KaYpF8lwB65nOfYUAX6jsGz9CI90SM4NBbvkESmwXmvPMfx7FtiZJQ2SQyNQIC5CK7ya5bXVeP96g0JwC2wXN/G8KHyGyhGOotjT3f8l/6js9YpdsIWdjUvDFh8DNh1zVVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779520534; c=relaxed/simple; bh=IcYsAkjYk+uuIclQHpJnOMdkt8o2M7E29sb0avD+z5Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rjmqXNOb5TXyz6XTLpjGrD32rL1v5xGXc/lX3BcqxWFlAbRy9GPKQeSQoTUHJxU0VugZOuDIODDnuMmfWjuTN8N39JI7L2S5/RVnze+HzcMTuk4+tOVTCd9u+Rp9UBmWbjNydow/EPKgY3F2IXDcxoWuOr52yw5BmNKa/ZiVDCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D8JSr5C9; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D8JSr5C9" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44a5174670eso4708052f8f.1 for ; Sat, 23 May 2026 00:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779520530; x=1780125330; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pDOYX2d+BKhaTTyw2PdfR5N/FD2dwrYDYgB1Q3ey6Ms=; b=D8JSr5C9WoHEXJvYIjqi4bTBRBV/9xNIiIveJ1TgRSTyt/EX8N/h+XUH1KwCBTTp/E BzFfjNt/1GZ9Mp9yQevC39464z9K3lmW1KZxbOtgA9H0Jp76uDjXqXvTzeCdzXNTR7+V i/Hx4kIZy5v8h/ZoDo/5u+21xEbRkSzcxKj3wVaWhHH4taC5eDI+SHzgQA6gqJSqCwmI CkHtmCaS5bQaOplrrcL2xS8WJRLWBCH2GuLKeGtOjD/PB8m4pyikVHEzcx70IfT7sY2z 8xXCgAvO4LhBg+qpnQfNBYAN2In1hYWwtoWid/MBHGqr4jLYn/YKYaZIwL+GiMuS0Shc J4fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779520530; x=1780125330; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pDOYX2d+BKhaTTyw2PdfR5N/FD2dwrYDYgB1Q3ey6Ms=; b=Wm363JHkMhKMgwuSNLKkJoATCnSs/Z8dGZTc7qpp2UkaVOFPxqjU4trQxqnndkPJms mKo0EKrRl6AB78UUQqMzfJt8Pt6nd3wpX8iE039pQozZ519TG3j0SwTtHbYuRYVEk8Lo TNkMVE4Je4OMU+R1y6zSO1HtLUKZwAVLvqLKG1u/fPj+2gmyzwHZWN1cL01/z72Om1Bc 6tNR+60EWb3TjF0QaG9Nutu1fBG6LEzkMOkVAVFS5c6+NjYN6cm1naY+Tozqtt4ghAnY NbIRHgSt6lBL42HF1Xw9xLxOCFzR+urPqXgi0jT6ctotj23xOM3uG55BtxIZ51xOPaQO BhZg== X-Forwarded-Encrypted: i=1; AFNElJ8Eme5AG52cjlpZB09eh/XXEXsukIwXGStnwMF1C5jx8W6RYqtIqzxsV4qN6X4dq0nJySoEIqu7eBycZtE=@vger.kernel.org X-Gm-Message-State: AOJu0YzWTEWxKxInX3MbDLcMJaznLIyYY/nlWTWRSsoFTpycJQIrxtCV niVdcxaQHaaXlFi6lg35xA+ZqlrUou71lFfebfH6sxZN67OjjSG16WPA X-Gm-Gg: Acq92OFTCL5cCmUDA4T7eucmcm6qSs3WD8EWJEgPaLmLP/0Sux1YWELNsP/Y6scDE6e DsoEIh/rjdLTNTMh5132vW+Acb0gMUn6ppYWUCggZtegmv4aG+jiT8nM0lZ5xd8/+hqLtFP8cDw mrEgsbpPlUu9LJTW16+jCo2mLLz7T2y/qOCfhNuRfOkwCo40Xs/Vz2vBHolypBAGoEXfzZIEMGb KYAPwBs+7Ha0T0YK+C7+hIbmqAqhtXFg4sWtQaINfpqEEnpQKupZESuxtZroxY+KJjeFzj8lFcO UEsx8xjl4JVFBzF/OSZOuJjpzvOiXCHCVyhsvtlFXZ+V16I6YyCHJkW0qW/ldPLa4IVQa4KfFgl 5O+J3E9dtDy1cfz9gS+fHBb5TsDAdjoAeYnN7gaqQS2t9PVqMY0INpIMb9Rl9s8m3zQpTDg+5Ho o/8cjkBBSwIwYE5DEeScrD53bfEsx8 X-Received: by 2002:a5d:5f8d:0:b0:43d:71f4:7ed4 with SMTP id ffacd0b85a97d-45eb368206cmr11355026f8f.15.1779520530539; Sat, 23 May 2026 00:15:30 -0700 (PDT) Received: from [192.168.0.174] ([31.96.183.250]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-45eb6d5cb76sm8639838f8f.25.2026.05.23.00.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 00:15:29 -0700 (PDT) From: Jim Cromie Date: Sat, 23 May 2026 01:14:50 -0600 Subject: [PATCH v2 17/24] dyndbg: macrofy a 2-index for-loop pattern Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260523-dd-maint-2-v2-17-b937312aa083@gmail.com> References: <20260523-dd-maint-2-v2-0-b937312aa083@gmail.com> In-Reply-To: <20260523-dd-maint-2-v2-0-b937312aa083@gmail.com> To: Jonathan Corbet , Shuah Khan , Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Shuah Khan Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-kselftest@vger.kernel.org, Jim Cromie , Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779520485; l=2772; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=IcYsAkjYk+uuIclQHpJnOMdkt8o2M7E29sb0avD+z5Q=; b=DSaOdL6/jQ5YJqm3Wtd/v9vl7sBYDaCKynhQOcWgxX0DOYt6uiNlbXyVZEYxlh8Mx6/zJ2QHU 3ndgCMMLJ68CdKl3OWiPBufHpGCMCOGE5M+QvMfjnN8/xUiv+axEwat X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= dynamic-debug currently has 2 __sections (__dyndbg, __dyndb_classes), struct _ddebug_info keeps track of them both, with 2 members each: _vec and _vec#_len. We need to loop over these sections, with index and record pointer, making ref to both _vec and _vec_len. This is already fiddly and error-prone, and will get worse as we add a 3rd section. Lets instead embed/abstract the fiddly-ness in the `for_subvec()` macro, and avoid repeating it going forward. This is a for-loop macro expander, so it syntactically expects to precede either a single statement or a { block } of them, and the usual typeof or do-while-0 tricks are unavailable to fix the multiple-expansion warning. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- v2: move RvB after SoB --- lib/dynamic_debug.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 7f03b331d185..e9481ef21825 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -130,6 +130,20 @@ do { \ #define v3pr_info(fmt, ...) vnpr_info(3, fmt, ##__VA_ARGS__) #define v4pr_info(fmt, ...) vnpr_info(4, fmt, ##__VA_ARGS__) +/* + * simplify a repeated for-loop pattern walking N steps in a T _vec + * member inside a struct _box. It expects int i and T *_sp to be + * declared in the caller. + * @_i: caller provided counter. + * @_sp: cursor into _vec, to examine each item. + * @_box: ptr to a struct containing @_vec member + * @_vec: name of a member in @_box + */ +#define for_subvec(_i, _sp, _box, _vec) \ + for ((_i) = 0, (_sp) = (_box)->_vec; \ + (_i) < (_box)->num_##_vec; \ + (_i)++, (_sp)++) /* { block } */ + static void vpr_info_dq(const struct ddebug_query *query, const char *msg) { /* trim any trailing newlines */ @@ -157,7 +171,7 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons struct ddebug_class_map *map; int i, idx; - for (map = dt->classes, i = 0; i < dt->num_classes; i++, map++) { + for_subvec(i, map, dt, classes) { idx = match_string(map->class_names, map->length, class_string); if (idx >= 0) { *class_id = idx + map->base; @@ -1159,8 +1173,7 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug * the builtin/modular classmap vector/section. Save the start * and length of the subrange at its edges. */ - for (cm = di->classes, i = 0; i < di->num_classes; i++, cm++) { - + for_subvec(i, cm, di, classes) { if (!strcmp(cm->mod_name, dt->mod_name)) { if (!nc) { v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n", -- 2.54.0