From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E596433121E for ; Sat, 23 May 2026 05:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779515756; cv=none; b=WucxwxBnmxOtgYx71siTvokrXGkgut+0AQFco0zVm1wSTl705LwbwFrXvjP3qfDyxdlJUaDqGakYlxzTmsMWXBISiHH0F+lGhM5G7Lz+IYOJ9I0ykogczPJhAtcr12r75sbhWjl3EcVdGsbDOvqs0/4QyONPHADEuVeRewJgh4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779515756; c=relaxed/simple; bh=M9/6c9xpxdfASdhzfeKzLb81C8BPym9l8vlZZZ6bIAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a+ZERj8AiJFPSbDw8reU98adYmxxCl6qOhJEqj83w4o4pInX6b10bCfHjAZgIx4d07gO1t7jgosv4TDvDHY6baADbsu6sQLYNj3S1qqwMfoDWY6niEVnUS1j/Zta4K9Nvi5GGxY91lPR+r8T7v4pMY+TLvm5r13x60KEvg+B4qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j18gEn1y; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j18gEn1y" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-57747a2bf20so2483124e0c.0 for ; Fri, 22 May 2026 22:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779515754; x=1780120554; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gtCpLLviP80UNadtvZprEuK2y75Rqf+N7aAub4ukfvY=; b=j18gEn1yVEhQy0nA0ICTwgCdEXqUFQ5iq/1co+wx2FdAy408MBjbmx9JwE5zthI6AL oiW2FlAcC2h9NZnur6cJfsTGS0RE0Mw19PThwQovE8QvYyTmPcNaZE5q6VIg61DooITD 2CIij2YTiqzMhQBV4i8AvCPR+9JFbOUTxNTkOjEX1cIAcUCD3H4jFjZ4maYWH0FCAto9 vGM0niUvjvWFbs55oKMbW+hZ473lM7ujz5ZihBOMmlYYZYyFjvrmi9f9iM/+XdmaZY+N UNli7WQfCSQcFIGs7GQqUT/dWiJvMcLDK2AGbATI1FtueCi/NnNUvZsJnv+UomPdfMRa 2rbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779515754; x=1780120554; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gtCpLLviP80UNadtvZprEuK2y75Rqf+N7aAub4ukfvY=; b=FLz4MNxE2MzYUpCYJEqJ3la1zLR5/OczMSEJAnn+bADKCnI03/WtiYeYLZYWO3UHOk 8UM3IoOQ0D9K4673JfjbnPDTKZnxgWq0o2+n+WdMaoJtA6NPrdALlKKJlxH53ohcHHnv aMl+BcaCgKRnIUg+tG4drp1OKpykMke0kswvbWVhSNDPwe5a8UaFcJWo0J73h+Te57y1 hMkoPS6XzrTmZnBAZiCW+rIER1wU4cevUuWuF61OjETw8MVLQkWBVEalU8bTgQUsohpj 2RX4QfGUkgnx91GVhhWLA/FJhTvbSlWHnsBW+D71u7NvT4+oeo8ik8o0IXXiVGH7zp6i AiKQ== X-Forwarded-Encrypted: i=1; AFNElJ9LkhFw5eEVqWGbfbKC1UCgQ1szZjhB2Sh2vDRFYu+J0Ikryooc+Nd2k5gXPogzq4NtGM1nYSy76iES2tM=@vger.kernel.org X-Gm-Message-State: AOJu0YyWFX4MXY5+jq+0lmpHksXLGemAB4srdX5FELDMHwr8zOtH2nCU YHNaR3UDrwA3vyTiVkraDuPnl/QpnhD28fcw2lU8S8E14xlT/fyQsuY4 X-Gm-Gg: Acq92OHXpwU4SGkq+HaEeAQP6Wc/7xDo04S7KqgeG99nOkTMWFR1NI83AXW0EOZ/P7P kuN0CHUo4cEMVyf1t+ltPNz7bw1se4DFa8zIRlfSw/lzPfvG+DlnVFkmfBB2qNzhWE25Rx/k+x7 U4qewMyVlxnc4ZV/wEWuVNiaE+iIUauH/PRE8O30Kcnr840pi724/KSzvxutsYN9EPVZIwXDMBk u89xOfH+hIXTr2fCWvp2oWzMkIj/jX8G5a2WcoDQ4xAYwswjl1W7omXHYayzOcvXcAZvm5WgKrf Dq0plVBYUgKIdm0aV49yIiudBJnx4ixUwfopDRcGZTYcYVrFqvtyjVQIIkNwIv6WFp/XLEk3HJL Fb2wBTqX7248krlAFvakWHsAxvurSV4vhexPx4pG60KpBwWrqLa86fTIvp18dDMVHuhsB4uRB5E jYQkmK4nsLY+R3fw3Vv92mQDLGsKthu151A9QnIxUlS8/2sJmbUw== X-Received: by 2002:a05:6122:6082:b0:56f:1c32:bd07 with SMTP id 71dfb90a1353d-5865e3b01afmr3912134e0c.2.1779515753658; Fri, 22 May 2026 22:55:53 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-586f973300dsm5023718e0c.18.2026.05.22.22.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 22:55:52 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Sat, 23 May 2026 02:55:34 -0300 Subject: [net-next PATCH v7 1/8] net: dsa: realtek: rtl8365mb: use ERR_PTR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260523-realtek_forward-v7-1-313805e218f3@gmail.com> References: <20260523-realtek_forward-v7-0-313805e218f3@gmail.com> In-Reply-To: <20260523-realtek_forward-v7-0-313805e218f3@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Angelo Daros de Luca X-Mailer: b4 0.15.2 Convert numeric error codes into human-readable strings by using %pe together with ERR_PTR() in dev_err() messages. Also use dev_err_probe() instead of checking for -EPROBE_DEFER. Reviewed-by: Linus Walleij Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/rtl8365mb.c | 51 +++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index 0da048da533a..2637884fe472 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -803,8 +803,8 @@ static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum) ret = rtl8365mb_phy_ocp_read(priv, phy, ocp_addr, &val); if (ret) { dev_err(priv->dev, - "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to read PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -831,8 +831,8 @@ static int rtl8365mb_phy_write(struct realtek_priv *priv, int phy, int regnum, ret = rtl8365mb_phy_ocp_write(priv, phy, ocp_addr, val); if (ret) { dev_err(priv->dev, - "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to write PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -1082,8 +1082,8 @@ static void rtl8365mb_phylink_mac_config(struct phylink_config *config, ret = rtl8365mb_ext_config_rgmii(priv, port, state->interface); if (ret) dev_err(priv->dev, - "failed to configure RGMII mode on port %d: %d\n", - port, ret); + "failed to configure RGMII mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1112,8 +1112,8 @@ static void rtl8365mb_phylink_mac_link_down(struct phylink_config *config, false, false); if (ret) dev_err(priv->dev, - "failed to reset forced mode on port %d: %d\n", - port, ret); + "failed to reset forced mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1143,8 +1143,8 @@ static void rtl8365mb_phylink_mac_link_up(struct phylink_config *config, rx_pause); if (ret) dev_err(priv->dev, - "failed to force mode on port %d: %d\n", port, - ret); + "failed to force mode on port %d: %pe\n", port, + ERR_PTR(ret)); return; } @@ -1299,8 +1299,8 @@ static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *da mib->length, &data[i]); if (ret) { dev_err(priv->dev, - "failed to read port %d counters: %d\n", port, - ret); + "failed to read port %d counters: %pe\n", port, + ERR_PTR(ret)); break; } } @@ -1652,7 +1652,8 @@ static irqreturn_t rtl8365mb_irq(int irq, void *data) return IRQ_HANDLED; out_error: - dev_err(priv->dev, "failed to read interrupt status: %d\n", ret); + dev_err(priv->dev, "failed to read interrupt status: %pe\n", + ERR_PTR(ret)); out_none: return IRQ_NONE; @@ -1725,10 +1726,13 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) /* rtl8365mb IRQs cascade off this one */ irq = of_irq_get(intc, 0); if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(priv->dev, "failed to get parent irq: %d\n", - irq); - ret = irq ? irq : -EINVAL; + if (!irq) { + dev_err(priv->dev, "failed to map IRQ\n"); + ret = -EINVAL; + } else { + ret = dev_err_probe(priv->dev, irq, + "failed to get parent irq\n"); + } goto out_put_node; } @@ -1790,7 +1794,8 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT, "rtl8365mb", priv); if (ret) { - dev_err(priv->dev, "failed to request irq: %d\n", ret); + dev_err(priv->dev, "failed to request irq: %pe\n", + ERR_PTR(ret)); goto out_remove_irqdomain; } @@ -1966,14 +1971,16 @@ static int rtl8365mb_setup(struct dsa_switch *ds) ret = rtl8365mb_reset_chip(priv); if (ret) { - dev_err(priv->dev, "failed to reset chip: %d\n", ret); + dev_err(priv->dev, "failed to reset chip: %pe\n", + ERR_PTR(ret)); goto out_error; } /* Configure switch to vendor-defined initial state */ ret = rtl8365mb_switch_init(priv); if (ret) { - dev_err(priv->dev, "failed to initialize switch: %d\n", ret); + dev_err(priv->dev, "failed to initialize switch: %pe\n", + ERR_PTR(ret)); goto out_error; } @@ -2091,8 +2098,8 @@ static int rtl8365mb_detect(struct realtek_priv *priv) ret = rtl8365mb_get_chip_id_and_ver(priv->map, &chip_id, &chip_ver); if (ret) { - dev_err(priv->dev, "failed to read chip id and version: %d\n", - ret); + dev_err(priv->dev, "failed to read chip id and version: %pe\n", + ERR_PTR(ret)); return ret; } -- 2.54.0