From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7AF41C84DC for ; Sat, 23 May 2026 05:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779512807; cv=none; b=rnRF1tot9BThudjhRitF4CcCrv+zX0UhHhGD6Oa3lJfd2Ru3Mpa8WEpqWxn5tWh2Z2+wkCqXx72MZBQBIkGHTPSvj7e3ksBJGDZPsjbtyGNt3SpMajuXkSvPwXAzLDnyAZ9aVucOA6bh8aStkXmKVj7nXUM2uv9+DW696XLH2ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779512807; c=relaxed/simple; bh=D49s69jzBXejZo67zjSIej+Rl6VSAaM7KMlYezj0434=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NxAomqHi7j3+DuZ6lGcOmCHi+wjqQlrBWcPahLmSQn80zJ4U4tstDXBURKTw2VlAUSEFvnd+/x0unfU6uwShobN2BZSfpVbdHM6K2Tdei77jtQbfy8cjSAY41kcgxg2WNer9DbbyKrjSwd7P6lMdeuS++PvjnayH6S8vmOwkfK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z4zBCE35; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z4zBCE35" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2f68f3b075fso2130014eec.0 for ; Fri, 22 May 2026 22:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779512805; x=1780117605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xYWslJK6SpSjatzdYnqvuc5HM66+pB8AlGJT3pjZSU0=; b=Z4zBCE35xakkjGzhJNH9lSmDKEush9ifnr+m0A6lvQnRWKmTEpORwT59wEDW5afg+/ 20NVOfFjWuaG/a08zJWPTtM90IeFYsgtHqsoRhMrVCpPoPTA1gpxUN+UzJ7j7Oq113vU yWuaED4CmFOImIb1tiBtQ0e5yQc5huB84sfxwKdIx88YTZi6qycMZcZf1Njc9liP4W1b F2uATUT9yh5Am4MHmkHUWQqsrbsyAz3FTkeitESOCGw0TyRZQl0aDdpY8Ub5D3/VaDzC l4iCuR/CVGK4cFypT93CR5wZTTh+CCn3E6ZWBicEHc+qfYfGmgEjAePKo32Ufxm6cYj/ IwBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779512805; x=1780117605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xYWslJK6SpSjatzdYnqvuc5HM66+pB8AlGJT3pjZSU0=; b=so50MX2glSJxXR+XT8tZECxaSQt5HyEjouqgUUV1sx+vw7BrvYFWJQO4Uyve3clnFp RAyb99blGzHqUBNCA7RGT9pVDqHcxVq9QDyrZGQJAUDr4iENeoTuFpIu9BwYwAY77ab4 +yI9U/YlCS8pCv2hoEDukefa/ZhftaQ3Ls7t9gezeLyi8W9yozxrcrs/5RaL0Er5rlwZ m55A48fdxSOa/RWxJtrRBzyYJA/RLuC764TCbQ5jtORfMl0nDfWzRYRYG8x+1mA3oieX RqpQ27x88LfQnqaLm1SaEsP8geWKHUNgUz0UdCFwEdQ3E+HjgX8vuEiZcU70z1evHwkM IIOQ== X-Forwarded-Encrypted: i=1; AFNElJ9uLI/JhwOof9Q9r+LSEJkM5BHCT4InGcVfx5PRl98ATrAanZ/8trC0gxvOg7Ag8zG8ldiZTQ6Zl8x71as=@vger.kernel.org X-Gm-Message-State: AOJu0YyA1e/WC1iK/bXAQ/qJc7F1ujG7xtnVhCFJzrW+RuMqb8W46Hrf JxIy45EtJRDTnuQqaFSLNe2lHiZBoN8bTgDQhaIVyelwtW5bPwyOLQKC X-Gm-Gg: Acq92OEdVv6H49Yzkm8Po9hA0LHSZEaLZx+40oSPo5+DpdlEk+g42iKIS485QE0Jt7C vHWHpB1SM4B6mJwTptJU3ikiVpq9z1O9ZzCAaQ5ozXfkxH6xc+ut5xLpn2y+DxLRGkxtudPp9Bu B9rk1eqs5/zvjPLv0UVVTyqvj9UntLNwDgj8hsjLEIJtnDsnX+iuvbVAhuJ4GL/JO47ldH2kdPk OTqIAwOlebUq+OSqKpJpvS8orYxWIbQTVtFR94z+FGh9aJvsp55t4bctJo1qtet8NIpPk94gCJm T+GMn5RUJBdGvJwxXtwzi92gY4K/VOdsUnH39h7zdKHnEGmHneVJYxKSsppgfWudS1fYagrsTa8 4IhqEghLWlRNszKW71OQgskQ6/6GVTFuAllj+K7WTvA2bqfuxLeekyH9/MpGyPhHWS7NWPn8Cv7 FjVvRqybTC81mM4YvelB136LPTt8blgsKSVQpb+rWqDJJ3F0IWhFyJEG8g/Lml0lQB9RCpx4p50 QAeYF0vuOyCtw== X-Received: by 2002:a05:7300:cd8f:b0:2f5:3641:f10f with SMTP id 5a478bee46e88-304491ebec3mr3466361eec.31.1779512805103; Fri, 22 May 2026 22:06:45 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7e45:2bd:3c86:d34a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451f3feadsm3502583eec.13.2026.05.22.22.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 22:06:42 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Thomas Fourier , Seungjin Bae , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sashiko bot Subject: [PATCH 04/11] Input: ims-pcu - fix firmware leak in async update Date: Fri, 22 May 2026 22:06:22 -0700 Message-ID: <20260523050634.501509-4-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.746.g67dd491aae-goog In-Reply-To: <20260523050634.501509-1-dmitry.torokhov@gmail.com> References: <20260523050634.501509-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The firmware object was not being released if validation failed. Use __free(firmware) to ensure the firmware is always released. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Cc: stable@vger.kernel.org Reported-by: Sashiko bot Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index a134483e543b..f86f9a5a7564 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -934,9 +934,10 @@ static int ims_pcu_handle_firmware_update(struct ims_pcu *pcu, return retval; } -static void ims_pcu_process_async_firmware(const struct firmware *fw, +static void ims_pcu_process_async_firmware(const struct firmware *_fw, void *context) { + const struct firmware *fw __free(firmware) = _fw; struct ims_pcu *pcu = context; int error; @@ -956,8 +957,6 @@ static void ims_pcu_process_async_firmware(const struct firmware *fw, scoped_guard(mutex, &pcu->cmd_mutex) ims_pcu_handle_firmware_update(pcu, fw); - release_firmware(fw); - out: complete(&pcu->async_firmware_done); } -- 2.54.0.746.g67dd491aae-goog