From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A012232A3E1 for ; Sat, 23 May 2026 05:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779512811; cv=none; b=u7BILil4IamlCCMoqJQLx5gDCiTUBjdb6uUKmzbdcdFSYobA3DljoWoRKd1uCwvFv1VRHwEPpAtx0jf4weWQ8xI3KkC0hrRJZ/ai41UF8N9IckySYwuaiy7G/dhZxEEDxBHi6jC+GhVQi4UtTNIvtXZfO+eupwMTl4+WKI3n5Pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779512811; c=relaxed/simple; bh=wFfcrC6+quti4awUdpIOtG9tFUevx0TecZKQaKI4tv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hM32IRh8uMhYZxI0aivzidkimsFq0yDi/NYJpslKY/3KS0v8GUjoP5X82iqg5Xm29ibesKhulllS9/+ymfkNKrpZcR2nGVx+1nEA9cEwLzPnhs6Rt0AxPWpY7kkA8YdfOTFWk3Ynfo+jm/uQgztAGsN3YzOATeV6FlEv8IVcHqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xosj1dd4; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xosj1dd4" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-30455f77e0eso1069851eec.0 for ; Fri, 22 May 2026 22:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779512809; x=1780117609; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ghXdVwh/ggIDUMJwerhmJOVNlYeh4b/xLTuz0F1xTdk=; b=Xosj1dd48ZMdESGKBbjrApr302XvRY/invtdzQYSZ2iJbtySj1iUHSq8EL0Ws+rpxH lX/Ax4Iz0TjcM+ou3rs9nbmG6WnapCGvjr+aRZatgdCUxXi8+6ADBO3d+TzZG3EfmRuD SL69IDz7MgR2mFInue4sxhGdSKcQlz2zk2UyOGGKUGeim/3rElH7XT3jhEiorwkACo/0 5mkgsWDKpLhguHzRVExdcxwrEZVzwuMxXYVQHd7Gjt8/niCjwFHzceZ9Bw49T7+kWEPb d+ImU9RE/AQbDUh5KtTuRQ7o22gYv9MGtmDxEOLERGMF8FoN46eRTxYI0OloW6sSoh6/ s/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779512809; x=1780117609; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ghXdVwh/ggIDUMJwerhmJOVNlYeh4b/xLTuz0F1xTdk=; b=b7FSZsKVC/VHbLwwkJcueKRdCKd3+3cgqu0WWAWg2iXkFuVv1BTDDRA79qN/uX6LYl P+k+TfwaVpLDd6AXuRVdfHyEGuYeNaJB99Au+rpi2v0gZONOYFuXPSu9NIF+JTn9Ft2k dYlHCnvmgCuEiYNbBf/ngovMcgodztd3rSPC1+mkkT6j9W/YtDLNByVmgkW7OfsDRYfv T/ABDRAVg/tQ0SXZ3KmuGo9zen08zlK1zo62CkaJdDixnf5QL73nnnx7F0YeUQGWVv6I pxyDi/2FstCA5vvh3dj88DW/VkchkaHE0ahC1oo9yz1U8RejgTEYqm0JDY3ArdL+YEhA c/EA== X-Forwarded-Encrypted: i=1; AFNElJ8pt+rPw95olMS9R3R7SOan8T3uwpXKJdza13l+bdsp/Qb4OOCnL9vkiGFlqZeaBAJlVxvSjDqf0ezGXqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7IQSCB9vmm1LbrwGMXUTNTKk0KvTvn+nwuhyVHA36hyXiMB7N X/hyE2on/PFOwLipzs39KGTz8NNPKEsSYaIbxUn22ykU5BRcT2n3vpDT X-Gm-Gg: Acq92OEX78VCahUngzdAq82SIfsT0RRWvcsBHaE3xPxtCqZRvdd7dg490fe0pxOGNjD 6AK5xXCuu8IqXTnMdJvUfgqOxZFtUnBiersqk1Y219h8N9wF3eJnxrVbdpOAvsCvBcSreerVxqR Hk8RkW1Imnz+MLXJDHWUeWUN0fScPUbiehi6btedOCrJ4D0DMnEOgYqbdYGdDYSwDgfMbw8hyhw Cvyi7CEoG1zLzkj3q7pDWRUg9e3p3eZoLMXuqEtPWneYdCvkCkQQagd+NHSXXkwHpAZ5MqvJIoX vDrU999gZhXE4YTvNGkRtyJs/NY2N36Hi+A7BRVhRLBLLz0utpCe/eNNez8ERi3oT0QxXHFkm+N SSwajF7KnRuetLliS7+ckAsyiaR2Z0aKAjLF2YvggusBVsG+KfCkkzlv5fRqsawPlqOxLAt6dmf upbtOCraea/Tv/6h0FjUzdHUC3Z1Qw6Yt/uf/HUUfGTJNeutNYsBFkZocFNx9QitOBeUh3WZUTj 8LcNlOaj3uoBg== X-Received: by 2002:a05:7301:9c88:b0:2ed:ff78:2c12 with SMTP id 5a478bee46e88-304491f6bb2mr3781274eec.34.1779512808947; Fri, 22 May 2026 22:06:48 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7e45:2bd:3c86:d34a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451f3feadsm3502583eec.13.2026.05.22.22.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 22:06:47 -0700 (PDT) From: Dmitry Torokhov To: linux-input@vger.kernel.org Cc: Thomas Fourier , Seungjin Bae , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sashiko bot Subject: [PATCH 06/11] Input: ims-pcu - validate control endpoint type Date: Fri, 22 May 2026 22:06:24 -0700 Message-ID: <20260523050634.501509-6-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.746.g67dd491aae-goog In-Reply-To: <20260523050634.501509-1-dmitry.torokhov@gmail.com> References: <20260523050634.501509-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver currently assumes that the first endpoint of the control interface is an interrupt IN endpoint without verifying it. A malicious device could provide a different endpoint type, which would then be passed to usb_fill_int_urb(), potentially leading to kernel warnings or undefined behavior. Verify that the control endpoint is an interrupt IN endpoint. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Cc: stable@vger.kernel.org Reported-by: Sashiko bot Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/input/misc/ims-pcu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 7fdff9dd1b5f..0e7a783526e6 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -1703,6 +1703,12 @@ static int ims_pcu_parse_cdc_data(struct usb_interface *intf, struct ims_pcu *pc return -ENODEV; pcu->ep_ctrl = &alt->endpoint[0].desc; + if (!usb_endpoint_is_int_in(pcu->ep_ctrl)) { + dev_err(pcu->dev, + "Control endpoint is not INTERRUPT IN\n"); + return -EINVAL; + } + pcu->max_ctrl_size = usb_endpoint_maxp(pcu->ep_ctrl); pcu->data_intf = usb_ifnum_to_if(pcu->udev, -- 2.54.0.746.g67dd491aae-goog