From: Daniel Palmer <daniel@thingy.jp>
To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: Daniel Palmer <daniel@thingy.jp>
Subject: [PATCH] tmpfs/ramfs: Let memfd_create() work on nommu
Date: Sat, 23 May 2026 22:04:45 +0900 [thread overview]
Message-ID: <20260523130445.1101818-1-daniel@thingy.jp> (raw)
Currently trying to use memfd_create() on nommu returns
an error with errno set to EFBIG. The manpage memfd_create()
doesn't have EFBIG as a possible error value.
Doing some digging this is coming from 0 getting passed as
newsize to ramfs_nommu_expand_for_mapping() and that getting
into get_order() and there "The result is undefined if the size is 0".
Whatever comes out of get_order() is then used in the following
logic and that results in the EFBIG that causes the syscall
to fail and the errno in userspace.
If newsize is 0 there is nothing to do so just return.
Roughly tested on m68k nommu by creating a process, creating
an memfd, forking another process, mmap()ing the memfd in the
child, writing into the mapping, then mmap()ing in the parent
and checking that the right data is there.
Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
Really not sure if this is correct. It works for me but on
nommu a lot of things just work because there is no MMU to
shout about badness.
Maybe shashiko will say this is a dumb patch and explain
the proper fix. :)
Also I had almost no idea who to send this to from the output
of get_maintainer.pl.
fs/ramfs/file-nommu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c
index 2f79bcb89d2e..fb471bf88ab7 100644
--- a/fs/ramfs/file-nommu.c
+++ b/fs/ramfs/file-nommu.c
@@ -69,6 +69,9 @@ int ramfs_nommu_expand_for_mapping(struct inode *inode, size_t newsize)
gfp_t gfp = mapping_gfp_mask(inode->i_mapping);
/* make various checks */
+ if (!newsize)
+ return 0;
+
order = get_order(newsize);
if (unlikely(order > MAX_PAGE_ORDER))
return -EFBIG;
--
2.53.0
next reply other threads:[~2026-05-23 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 13:04 Daniel Palmer [this message]
2026-05-28 13:02 ` Lorenzo Stoakes
2026-06-30 3:58 ` Andrew Morton
2026-07-08 11:46 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523130445.1101818-1-daniel@thingy.jp \
--to=daniel@thingy.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®