From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56232347BC6 for ; Sat, 23 May 2026 13:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779543242; cv=none; b=H85EDKV6l5jWoJWaDK/DTVSP3br9Z37Pn/pBWYWsqgpucYoxTXcSgO/K1QrxmcKqS6eCAa4lD/xTVkcYBSBsYJJ+uNmmpYOjHT4VQcRreYfNaGGs2ZGiioz0jnr/Kj4HLQbMxbejOOTr/VMaC/J/WyU2OWOQcyunIZwShIGiUu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779543242; c=relaxed/simple; bh=5iCgyzuUNoEV0PAomPH6D8+BcG7Zu6jTnS9GnfIcS78=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f3nIZaV0W9FkDdS4Km34vT/eZ1beSP6x40PPZOJsHcrCbv0/Za4pwvOWqddxNuofx1YnXNJcSr71PhQKRIvIgk8TXvpA3NqCwJAEEYzt+OmYcs/3aSwd+oKaj7wZR/4cenr/uL0v+VIR3fyfJROMkOrO6e6jY/niAJ5PlDKepbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=DpExUmpF; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="DpExUmpF" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-50e63771eb0so82303621cf.3 for ; Sat, 23 May 2026 06:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1779543239; x=1780148039; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ScTPfMS4uBwckQ+rbDYkW0EYBsK6B7QnfP4yXtD8oFM=; b=DpExUmpFP8obfFBqfuCLP6S86VQxeKfKTnI84/eQWNTGC7rhtfVs36sVe8n/tNZvUc v1qVHFDO4yAoDKsMKUObbZEhnaxsdG5vpMy300Nu4T8gr4eog7rp1VBOd6ZFQKr03ZcB /ckYr/TgdWnMsPj7Qikt/ylG2I2aSN05CNR4Pl7sGShx9xpSsgIxgCq0qGribQ3KAT3B y9eSBAPiijYKUCOOqykVYClGG74tJVPdDE3aEbklrThWh1Zn9H8mzBvH3t+NRs4VQpnK QsuTsMEcaQW9qHd94kQTvGAdL7QP9qEn1GtrEq7vywGENJl+6ZgJxwFui/twhXIf8x/J tuGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779543239; x=1780148039; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ScTPfMS4uBwckQ+rbDYkW0EYBsK6B7QnfP4yXtD8oFM=; b=Vtcrz4blTXMrQT42Zfhz7OyEXNwdb4lTv/QNnJSc13gXUIEMqpWX59nyYRrbLiyrgt hJSYUOJd1A0A7YzvNoQqYpl1O18eycFsSLXjw06MPoz0pQ/5DanBoAPvXmxKHSzFMYmd gU4s5C3Rqqn8CHIp2exV6jQEO+Dxi32rYu57ZNT52xDglvkoQ4NHnEl8S04eFJhiMejw lhafBw4XNBhAX5b2kVjWzfA9gvjaGugz7xcq9teovaVp66CsBaZUDt9iXsqmANa871rE eScemewnA8UdPdUmzK3zj09l7g+f8e4bbpsfkB7NFeZCGJh5yMiBJ1erQOC6JsFpyKRK kmnw== X-Forwarded-Encrypted: i=1; AFNElJ/IANLVEpvhfaHsC/702gu+soVcMFY6qubIITyc+x7lG8lE6kmYNfFCZAll2lzQSTbfx2BfkHPv83mb4OE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwb3fn1lb7/F7xfmR5UEqzbFUf4++yjBh86+sOibRSSdADhZN/ Zp0GiSDWz8mHtTaGdHKPpETJ4MroAWiXIvPAxhy9xBEIFpjGI80K2ME+g3wvQtXtw70= X-Gm-Gg: Acq92OEwtbukRLsTFGAAh2c+fwZybdSPHsaW7uUqfxv435mNcaoB/+hyrgPLaSaNagb tHZzeOAultFcXoaL7XXyYJs1VZ5VBFYRfF+eWe/CbXtmQzWlhR4CqQH3HT3gzgG5Br7Q+KpUwBl KEbW1VgYG49KLT1nD/CgKnYJ7n4CItFoOGj+X6usjQE+MxPTrol/cFIr5im4ddMr3q3B/3yQ1vU DN1LLZTEahnE7Mys0dHJipc3CilM7HYMIc8lVzRVnSkp0VESY8OFmxruvysDSQy+PI/a98Tt54d 1dKhKt/evk4n+/2KiDgx7IS24AKQYHGeJW9AO6gnuXfh/UnyHjX9CcP2ZNnyZJYRVnLgrNh2EFv 0laM/zH0D72VbGhUw5y6P6CpXJZwcl03DzUPRn/NMFiXMxrTu7u2TGSDustElzde/MrE3ZTSnWZ Zpvb2Xtoom9KKKu79oGY5PMRr7SbTwu22ppbh6JDq+qoyIfHzHNPW2p4/WdJTliEUVMRLWriLnX S/LsGkJBVND1eM7 X-Received: by 2002:a05:622a:588c:b0:516:e9ea:1c32 with SMTP id d75a77b69052e-516e9ea1f17mr7464221cf.9.1779543239413; Sat, 23 May 2026 06:33:59 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc8131524esm46180116d6.40.2026.05.23.06.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 06:33:58 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wQmUH-00000006Hta-3suz; Sat, 23 May 2026 10:33:57 -0300 Date: Sat, 23 May 2026 10:33:57 -0300 From: Jason Gunthorpe To: Samiullah Khawaja Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Pranjal Shrivastava , Vipin Sharma , YiFei Zhu Subject: Re: [PATCH v2 06/16] iommupt: Implement preserve/unpreserve/restore callbacks Message-ID: <20260523133357.GH7702@ziepe.ca> References: <20260427175633.1978233-1-skhawaja@google.com> <20260427175633.1978233-7-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427175633.1978233-7-skhawaja@google.com> On Mon, Apr 27, 2026 at 05:56:23PM +0000, Samiullah Khawaja wrote: > @@ -266,12 +273,22 @@ struct pt_iommu_cfg { > }; \ > IOMMU_PROTOTYPES(fmt) > > +#ifdef CONFIG_IOMMU_LIVEUPDATE > +#define IOMMU_PT_LIVEUPDATE_OPS(fmt) \ > + , .preserve = &pt_iommu_##fmt##_preserve, \ > + .unpreserve = &pt_iommu_##fmt##_unpreserve, \ > + .restore = &pt_iommu_##fmt##_restore > +#else > +#define IOMMU_PT_LIVEUPDATE_OPS(fmt) > +#endif Don't do it like this at all, new iommupt unique ops should be routed through struct pt_iommu_ops See how map_range/unmap_range now work Jason