From: David Sterba <dsterba@suse.cz>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>, David Sterba <dsterba@suse.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 6/6] affs: Move long delayed work on system_dfl_long_wq
Date: Sat, 23 May 2026 17:26:15 +0200 [thread overview]
Message-ID: <20260523152615.GD183694@suse.cz> (raw)
In-Reply-To: <20260508134541.282073-7-marco.crivellari@suse.com>
On Fri, May 08, 2026 at 03:45:34PM +0200, Marco Crivellari wrote:
> Currently the code enqueue work items using {queue|mod}_delayed_work(),
> using system_long_wq. This workqueue should be used when long works are
> expected and it is a per-cpu workqueue.
>
> The function(s) end up calling __queue_delayed_work(), which set a global
> timer that could fire anywhere, enqueuing the work where the timer fired.
>
> Unbound works could benefit from scheduler task placement, to optimize
> performance and power consumption. Long work shouldn't stick to a single
> CPU.
>
> Recently, a new unbound workqueue specific for long running work has
> been added:
>
> c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works")
>
> Since the workqueue work doesn't rely on per-cpu variables, there is no
> obvious reason that justify the use of a per-cpu workqueue. So change
> system_long_wq with system_dfl_long_wq so that the work may benefit from
> scheduler task placement.
>
> Cc: David Sterba <dsterba@suse.com>
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Acked-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2026-05-23 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 13:45 [RFC PATCH 0/6] fs: " Marco Crivellari
2026-05-08 13:45 ` [RFC PATCH 1/6] ufs: " Marco Crivellari
2026-05-08 13:45 ` [RFC PATCH 2/6] fs/jffs2: " Marco Crivellari
2026-05-08 13:45 ` [RFC PATCH 3/6] hfsplus: " Marco Crivellari
2026-05-08 18:34 ` Viacheslav Dubeyko
2026-05-08 13:45 ` [RFC PATCH 4/6] hfs: " Marco Crivellari
2026-05-08 18:34 ` Viacheslav Dubeyko
2026-05-08 13:45 ` [RFC PATCH 5/6] fuse: dax: " Marco Crivellari
2026-06-10 12:17 ` Miklos Szeredi
2026-06-10 12:42 ` Marco Crivellari
2026-05-08 13:45 ` [RFC PATCH 6/6] affs: " Marco Crivellari
2026-05-23 15:26 ` David Sterba [this message]
2026-06-05 8:14 ` [RFC PATCH 0/6] fs: " Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523152615.GD183694@suse.cz \
--to=dsterba@suse.cz \
--cc=bigeasy@linutronix.de \
--cc=dsterba@suse.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®