From: William Breathitt Gray <wbg@kernel.org>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
o.rempel@pengutronix.de, kernel@pengutronix.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
andy@kernel.org, joshua.crofts1@gmail.com
Subject: Re: [PATCH] counter: interrupt-cnt: use devm_mutex_init()
Date: Sun, 24 May 2026 07:51:35 +0900 [thread overview]
Message-ID: <20260523225136.377780-1-wbg@kernel.org> (raw)
In-Reply-To: <20260523184418.7586-1-sozdayvek@gmail.com>
On Sat, May 23, 2026 at 11:44:18PM +0500, Stepan Ionichev wrote:
> interrupt_cnt_probe() calls mutex_init() but neither this driver
> nor the counter core issues a matching mutex_destroy() on unbind,
> so the lock debug state is leaked.
>
> Switch to devm_mutex_init() so the mutex is torn down in the same
> devm scope it was set up in.
>
> Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
This sounds like a bug fix (albeit applicable only under
CONFIG_DEBUG_MUTEXES) so we should have a Fixes tag here, correct?
If this issue applies to counter-core and counter-chrdev, would you
submit patches for them as well?
William Breathitt Gray
next prev parent reply other threads:[~2026-05-23 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 18:44 Stepan Ionichev
2026-05-23 20:54 ` Joshua Crofts
2026-05-23 22:51 ` William Breathitt Gray [this message]
2026-05-31 22:34 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523225136.377780-1-wbg@kernel.org \
--to=wbg@kernel.org \
--cc=andy@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®