From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6498F3876C5; Sun, 24 May 2026 10:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779617842; cv=none; b=qpVkQD+i/YVHBueAEXvUpJGChz/lG22BRu7802+Ks0Sh3WXnLOGBTl9YS/P5LY7IeI50fpQAhTieRisHzMF+iPSwVeX9+M2uo0YfS7R4fHbRlpCJqNLOqTtJuHwnDfwlIrmU+o5XvUZVrDzQEyDE6LWZM+Ss4ioqj7Fa7PfkBsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779617842; c=relaxed/simple; bh=o6yHnLbinDGTwtKjq5fqom6UlIJxge7edyEmHa5kDbE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e9fssdWtLLf4NPH59jGdIrOeopyzRv1hHZCRzx4xYp9VbmJmkGb2qhl6njdm+Ale73feehXwxNi8UC7cK5pj6VvmYlfpxMqlGeFn+OWVArocaVjOoF7gciic81JoZyjmSYeLGWkRGEt0ztQEQCX0Wi3t+pd04YAt7vDVWeFzoIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aG5WMWbg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aG5WMWbg" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1ABE2C2BCC7; Sun, 24 May 2026 10:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779617842; bh=o6yHnLbinDGTwtKjq5fqom6UlIJxge7edyEmHa5kDbE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=aG5WMWbgweb1DiaHqqvHS6hdXByvmx04QOgki1IE0qt2iXBlthZQYH3nKTnqEXMTL oNPN+UF54ViDvztbvejMY+eZRDol1QDhUV0d+EuSIwI/VLvSKgBTcuT6BnFjjJ474r MhAva9QZvb1Ly9+Mh2teuNIZxCEji+hiWQAp9w8YYs+dec5vcG3jMWJ0ISrNKxm1v/ L+RgFYaDdjeFLxRgs3+VdcRz95DHTMweRZWMKUbF7tK2C95co4to2IsnUCf1/4UkMt iScsHKdu3OTw12NpVTyhCX9O4ZNzHnSyoT/gXFe5qa3sqDoEQ0vg1g3ZdGNItOPnti lxM0kM4X/7MFA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0712CCD5BAB; Sun, 24 May 2026 10:17:22 +0000 (UTC) From: Rodrigo Alencar via B4 Relay Date: Sun, 24 May 2026 11:17:02 +0100 Subject: [PATCH v7 2/8] iio: dac: ad5686: remove redundant register definition Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260524-ad5686-fixes-v7-2-b6bf395d08bd@analog.com> References: <20260524-ad5686-fixes-v7-0-b6bf395d08bd@analog.com> In-Reply-To: <20260524-ad5686-fixes-v7-0-b6bf395d08bd@analog.com> To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Popa , Jonathan Cameron , Greg Kroah-Hartman , Michael Auchter , Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rodrigo Alencar , Andy Shevchenko X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779617840; l=2960; i=rodrigo.alencar@analog.com; s=default; h=from:subject:message-id; bh=Xiv+tJ1lwWKtIGFdm+dKfGGz+TEcNrV+I9Xy6tSqFgM=; b=3h63qLXcqDgawI+5goEHuMLBAQ5a+Fq+iuyEDFmWhkfIVzqBehU1dfrPj00bYTwBkmt+1d1Aq GNqN6/b5EK1C3AZWkofhfTCunyLDGTd1zZuRzs30XexWBfCqJmCYkGN X-Developer-Key: i=rodrigo.alencar@analog.com; a=ed25519; pk=ULeHbgU/OYh/PG/4anHDfLgldFItQHAhOktYRVLMFRo= X-Endpoint-Received: by B4 Relay for rodrigo.alencar@analog.com/default with auth_id=561 X-Original-From: Rodrigo Alencar Reply-To: rodrigo.alencar@analog.com From: Rodrigo Alencar AD5683_REGMAP and AD5693_REGMAP behave the same way in the common code, and that is because they target single channel devices from the same sub-family. There is no reason to separate them and it will make things simpler when refactoring the chip info table. Reviewed-by: Andy Shevchenko Signed-off-by: Rodrigo Alencar --- drivers/iio/dac/ad5686.c | 19 +++++-------------- drivers/iio/dac/ad5686.h | 2 -- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c index ae1ef52b62a2..110ea24c31d1 100644 --- a/drivers/iio/dac/ad5686.c +++ b/drivers/iio/dac/ad5686.c @@ -116,10 +116,6 @@ static ssize_t ad5686_write_dac_powerdown(struct iio_dev *indio_dev, if (chan->channel > 0x7) address = 0x8; break; - case AD5693_REGMAP: - shift = 13; - ref_bit_msk = AD5693_REF_BIT_MSK; - break; default: return -EINVAL; } @@ -300,7 +296,7 @@ static const struct ad5686_chip_info ad5686_chip_info_tbl[] = { .channels = ad5311r_channels, .int_vref_mv = 2500, .num_channels = 1, - .regmap_type = AD5693_REGMAP, + .regmap_type = AD5683_REGMAP, }, [ID_AD5337R] = { .channels = ad5337r_channels, @@ -422,24 +418,24 @@ static const struct ad5686_chip_info ad5686_chip_info_tbl[] = { .channels = ad5691r_channels, .int_vref_mv = 2500, .num_channels = 1, - .regmap_type = AD5693_REGMAP, + .regmap_type = AD5683_REGMAP, }, [ID_AD5692R] = { .channels = ad5692r_channels, .int_vref_mv = 2500, .num_channels = 1, - .regmap_type = AD5693_REGMAP, + .regmap_type = AD5683_REGMAP, }, [ID_AD5693] = { .channels = ad5693_channels, .num_channels = 1, - .regmap_type = AD5693_REGMAP, + .regmap_type = AD5683_REGMAP, }, [ID_AD5693R] = { .channels = ad5693_channels, .int_vref_mv = 2500, .num_channels = 1, - .regmap_type = AD5693_REGMAP, + .regmap_type = AD5683_REGMAP, }, [ID_AD5694] = { .channels = ad5684_channels, @@ -538,11 +534,6 @@ int ad5686_probe(struct device *dev, cmd = AD5686_CMD_INTERNAL_REFER_SETUP; ref_bit_msk = AD5686_REF_BIT_MSK; break; - case AD5693_REGMAP: - cmd = AD5686_CMD_CONTROL_REG; - ref_bit_msk = AD5693_REF_BIT_MSK; - st->use_internal_vref = !has_external_vref; - break; default: return -EINVAL; } diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h index d08160e7fad9..af15994c01ad 100644 --- a/drivers/iio/dac/ad5686.h +++ b/drivers/iio/dac/ad5686.h @@ -46,7 +46,6 @@ #define AD5310_REF_BIT_MSK BIT(8) #define AD5683_REF_BIT_MSK BIT(12) #define AD5686_REF_BIT_MSK BIT(0) -#define AD5693_REF_BIT_MSK BIT(12) /** * ad5686_supported_device_ids: @@ -89,7 +88,6 @@ enum ad5686_regmap_type { AD5310_REGMAP, AD5683_REGMAP, AD5686_REGMAP, - AD5693_REGMAP }; struct ad5686_state; -- 2.43.0