From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5C53911B8 for ; Sun, 24 May 2026 10:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779618828; cv=none; b=hNSiv76leHfXScOClFubAi8AiJ4HFmpXVjn5leVd/q57lunIWfG0K9n7kPkoR4EJvOHrnixwcgaIoS4w/++oqmMXSD5KyA/8jmqIXVkagrHKbjsOBPFX2zy8p5V3ichZVa/owV7KfD9+25tD5ZGuYpM5058t5rVcp2s91MGCBSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779618828; c=relaxed/simple; bh=T2TnNl5IXG3x/8HSEi/dmYszlfNUS/MS6JJyv3KPSVY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZL2UNhc82EzQbZNK0gNJHliBJqV6SUiQ3Tg3gRkz5w97vXBhIcdFi3bVUiSA4ZFUIVC8uKDNzRoCXTu6cXpO9PxtJyg+Ngca7o1S+KJ4+r+2xlZYjp1gQErQ5usZAUoTrkRYlNEMczE17zJRDDX8nCZA6VhCMXv0bbBxwuJilU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fJ/aG0dP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AD69QcvZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fJ/aG0dP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AD69QcvZ" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64O38gcZ555501 for ; Sun, 24 May 2026 10:33:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LIovE62RVN0QdCt+WmtKx5cgzNYUayKB/BcGmgYe/jI=; b=fJ/aG0dPyN9+sj7z MtpM7c9O10QAoRoZ7Cn3mNYqauiDf2UFakFqaG9+VgsarR0E5ylYtd9oy/DCjOFx C8dA8RdQaAgGUHeKcmW4UWt1pmDxlMDz2qqck0qqCGx0bX7zPoG7EUi4A0IhR1IC aIKJhRLdxka8ctCVfgIx90m7ikY9hfvLNyxtHmqd61PiG31JYp7E0k7HXdpgzNI7 5VpKLFtcFnZViAe40G2/hWF8EBncRt2rAFyXRnkoJK79UsWQtiwSqqUS1HVEjgxQ 06W+XWQIDMjxnTciIAupYdM5MPI1XummovTNoGxjrvQa8rTov17oWLPrvS9l1X/X iCkoGQ== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb50ftup5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 24 May 2026 10:33:46 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-575597e1259so6833737e0c.1 for ; Sun, 24 May 2026 03:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779618825; x=1780223625; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LIovE62RVN0QdCt+WmtKx5cgzNYUayKB/BcGmgYe/jI=; b=AD69QcvZY2R2wjoyG1i26lgeUTd8FHYqVSgbxWEkJ0FoJCKbbe8LZYpmoZNuy98J4v anXQsjNeVWFg57be/iBdG0JyFtO+u53KLvCp+GU2Tt4GH7pLkqx8k6P0CQFrT4Lb83j8 fRQCowP6SEUpAd0l3sw5eh9pchnbMxIP7C2vbpez1yJxgs2MBOmVB7LptZn3rNaGoL5v 8xG87oRrifcx1USrbIWw8quewzJTuRmnXdoGqNTa6TE7HdUSKM6Hg9PwbyBlmO1e7IXE ni7ryDDfYvOrBdUB5ALoneH0Rga5pEBxg2M0AxgCkzjnAzZgqb3znJFImvdw7+cb7OPO BrvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779618825; x=1780223625; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LIovE62RVN0QdCt+WmtKx5cgzNYUayKB/BcGmgYe/jI=; b=Apy425cQv25ayCjVzQ1AE4v4SSo2PEUPesXtjMoeQOmt06PGViZk4JxxUPSmOHNbu9 8U/ugedJ8EWLzbia44id7ZhOHoXyQ2ym1NrYhtDEHUZJ82MxSWnNWtAT0OIggWXkkzQu YisYYjjAzKJagCeLUw2pqiZUH+UR2H2OBUQBl6g/JuwXT9vS4wlpeZBteZEKrEY8NCVM 6U6WMKD/AshBWQTf0FEIHAMqeXH9vf/PUOjXwYTcOo/zG7HgBYdLTt9+WKQSLWek2TrK ghUlXFb+i1uyaLxEp3KVtH/0auo7sXcKEUWkfrTDv/6Bv3IXVP1QMPJu8IWilIGKUxs7 ktbQ== X-Forwarded-Encrypted: i=1; AFNElJ+Zw2HxWiuVLKVfr8Z7aYQ1D47dDDIl1IegB11FHyB2Tu2Pkr3Qjhtnon8/g9jZ7I/r8e9YRL9e9iJB/nY=@vger.kernel.org X-Gm-Message-State: AOJu0YxK6GRd63DLFLPS1DVIUNExbjAlMxBxQrZZmJqwvaiHZ+28jBR7 wzqfhl0mP5+DyCWPibjJQUztBayDOf7wxEqKyTEgYhsVwPmF/l/B8PcFZ/jQb12THmsRPBfTNKm BXKzTyCH1c3YVwB2lq10bUiiJ4fTds75O2Ms40YNUMx9V7aJg9dTBQmKxHiXVz/tg46c= X-Gm-Gg: Acq92OH4HCGsYhEZ8FNcb9lGEqnW3Q5ccOu7SLXCtKEs1/muipUAGcrUCZu9IMxe6YC PrbaaH4wzVVExpmmcDONRNdFo9a3llv5gA3zfQ0omu9anq/eixjBxBL8i9C8f4jXzjm+3GZZyWV Q7FWkbtcIhP+rZDlbcmtofndea0piHawe3Pwf9DywKHi2KQl1LKmehibi/NG6m0l1GdD+QKGTZN aPzxRNaXQVxMJoe5RJvfOHjGM2cgXS8M7PaEszStQVHg2nWKSlUtLj5aiHG659aTGf+FM53xdnb I0U5Dpfz+5aH/03TuKSHtYNZ/k1eYrIFzZknseQx3INTxUy9bN7Ys5TRuugtwKTnWHuqWESPj3m Xb1WgDa9QjJUrHEqx3maC0dRGsxEzkcy43MkyBV2o3O3PJj/1YLkWzNsVDRdYMXOp5hDYfRPBQW abYn8dtW10rIhR0SeMBiVddxkaIF2vmTT+ypg= X-Received: by 2002:a05:6102:3f86:b0:602:8c16:b24c with SMTP id ada2fe7eead31-67c7c0765aemr4823996137.19.1779618825590; Sun, 24 May 2026 03:33:45 -0700 (PDT) X-Received: by 2002:a05:6102:3f86:b0:602:8c16:b24c with SMTP id ada2fe7eead31-67c7c0765aemr4823988137.19.1779618825197; Sun, 24 May 2026 03:33:45 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa32cba880sm1816148e87.32.2026.05.24.03.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 03:33:44 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 24 May 2026 13:33:32 +0300 Subject: [PATCH v6 04/10] drm/msm/dp: Move link training to atomic_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260524-hpd-refactor-v6-4-cf3ab488dd7b@oss.qualcomm.com> References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> In-Reply-To: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Val Packett X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1737; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=kIfgr1TXlKJmMBrqjAe8XvEofIv6a7FFbjhSIdx8oFo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqEtP8rFYr9RxFhNyHvTDkeW6A4+2lNu04yxSnK yFxC1+HFiuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCahLT/AAKCRCLPIo+Aiko 1VN3B/sGoDcfMNPTG+CrZBca9Zt21qM3tfIB8ERORfHAdmuNpv4jUPqDFKCf51fceatoNyPbKyk ArSJAGtbi5d0L70U4B0BtowxEBvvVIQkPtXt9woUQO5hJwVYgXHMx1talX4TuH3rND658Ka7bq+ nAOcohmah1maXkO2khjmDP5F/SPgpeJ1j1k/tbSmWUT/ZERZ59VjMNzYj66CqiJp7i06V/tTI5V WAQCXYkfVxm8EGYIG40O711YRQXopeF/coJuzKnvAQ2kMqHBw4MrkjcD1Z1SjX/bTrlv9s14drI PweRo0priJUp1oXHmv30xxbeVNIErtwp5p8rQaSMYaAb1gCE X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI0MDEwNyBTYWx0ZWRfXzueddkPuhhpV u+xQ/jwu2Z8+9LrOS85AV/QbP+XgwpshB1hAZojijGZDfRzbJMV5asg8lLASyd0zgvRzmP0EmeP 4aNhI1lyqSOpQq6jkBe2lAUAed+oamchgdD3sso6/CZZsG14VtQK2ORXNapv/bzlMe5x4P9JnqE IfWAH+9/jmbLaqbLacmdc4u8bw+9wCXm+tupPu6gC+GF0EwraE3viu7Z2cm7dp+8XSDgRCFt640 djI+M298tfI3yHgCiiR+JK+wgLorebuXE23ByrSerqUE9S2drIFbSHUv3CR28w2TatnKUq+0G0b wEoaLBxgCyqR7rnFrorGGxXthVYh56KNZc5ssSt58WfrQ+6iwGd6OrQs8kYZlLzVKQUgtlDqxkN RTz6idVtSVy5UrRo7eEB5W5OT9FKTuHJ3yiz7Ts/NLpvI0n3m0VCReHSCeYsQh+CcrkuzLFBiAo smAWbYd3m3U8aLvCHLg== X-Proofpoint-ORIG-GUID: dh9Ap4EIXS7_rM30-S5ct_vi62NRLgIp X-Authority-Analysis: v=2.4 cv=UdBhjqSN c=1 sm=1 tr=0 ts=6a12d40a cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IoBVowuyLm_M3JZO-XQA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-GUID: dh9Ap4EIXS7_rM30-S5ct_vi62NRLgIp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-24_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605240107 From: Jessica Zhang Currently, the DP link training is being done during HPD. Move link training to atomic_enable() in accordance with the atomic_enable() documentation. Link disabling is already done in atomic_post_disable() (as part of the dp_ctrl_off_link_stream() helper). Signed-off-by: Jessica Zhang Tested-by: Val Packett # x1e80100-dell-latitude-7455 Tested-by: Yongxing Mou # Hamoa IOT EVK, QCS8300 Ride Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 97c4752005c0..036b4a5cece5 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -437,11 +437,6 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); msm_dp_link_reset_phy_params_vx_px(dp->link); - rc = msm_dp_ctrl_on_link(dp->ctrl); - if (rc) { - DRM_ERROR("failed to complete DP link training\n"); - goto end; - } msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); @@ -1699,6 +1694,13 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *drm_bridge, force_link_train = true; } + rc = msm_dp_ctrl_on_link(msm_dp_display->ctrl); + if (rc) { + DRM_ERROR("Failed link training (rc=%d)\n", rc); + // TODO: schedule drm_connector_set_link_status_property() + return; + } + msm_dp_display_enable(msm_dp_display, force_link_train); rc = msm_dp_display_post_enable(dp); -- 2.47.3