From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A19A32BE7BE for ; Sun, 24 May 2026 10:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779618831; cv=none; b=sAgYv/0EqVuDZTttVOTDJ7SDojKo9X6Yf/h317ni/BdqGDlCu5aTLB9QNKWBPQaRRZKLL6S0xBOqAZz2S8LAiQ99wcRcWS8+Rnac8/4MtIRH4OBpiKub2Ta9quzHUSMkzAUJvO28zjcY+MTcriNhhMfKxFR66rYPOOpYHI9bOBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779618831; c=relaxed/simple; bh=+GaGtvCVi/jXs8Gnl6qiTts4wOcrwLXV7mGMw9P2xyI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CO8OPDI8MlvdMxjjvmeYq4CFr3QHxTtZ0SdXnuLVk1N4zYaeHtItJ7wbRt23jMnX3/CgjIraCwmUeSHK1q5M077sV8jgpnhdeFbFGcmeLvGHPVLPiSPZrHU2YMoKpbP6LFemmN5ANZnVrRGPn3rDmHZ7WZBaiwALI9HxuJrI+RM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eRTO5095; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b7MEiPUI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eRTO5095"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b7MEiPUI" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64O0jESH3505255 for ; Sun, 24 May 2026 10:33:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l8o6cIS01j0pOwxkyeeRqH0JHndoNuqGw7yx7pJcTtI=; b=eRTO5095bF0iAnpM bWvKPvKLmFlRlAaIbQAKnfEb0o/PL6NH41Z/A/qNx62Zp541S49MY3e+QB2026M7 Sc4t7n0zoacI6CIZGzwpf8vcCUFPtYDG0tbTBn9a2b0r2iJIAHMcU2ZWnccF9Ru7 HGNS0XmHPGBB8RpmSkQOzEtiwbrDLwD/8dnh5MIScQmaRnUxXFndz+fBXiKyr6kP 9K0Tl8oIGya5WK6vBb6VlBT74Zsa5WzKog/q5CUz7zBFp3G5EXAFyt1xSX2jZUcm TgSopM9Earypu2386ZfSDnR7LD6RpMWWeZio2kb+a8ecU/XD6KV2xIFvOcd+jqcu +rtSyQ== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ebba0t696-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 24 May 2026 10:33:48 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5751772dec6so17755801e0c.2 for ; Sun, 24 May 2026 03:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779618828; x=1780223628; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l8o6cIS01j0pOwxkyeeRqH0JHndoNuqGw7yx7pJcTtI=; b=b7MEiPUIwIegY6hooGfEdWOXcUx9W3QbTtpDVWZRCrzkvmrYt2QU2PfdJWIib1exVt WorjGbcGgUqC1/1uvhBp1ZRmRab5+6UDBrEWNoHDxf6Pd8KCoPPE5MpqFqJNS6zn99dO wqu38Etusi+8DjZN7RyaiJiH6xIOpj58Or7pZG8RZ1xO+69UbCjsdAaPxthnyk7+GlTl RE9hkzWNJh5UYAjVoUmo9TXC3nLAA60biDU8nzNk++yGjjxCpQcwatSybs8NLIopr0/7 Oa9iqKAbHGHGUrWNZfJwFqkTGCuprSEh2HgrkZ214VTbGXNtsasfTvr2O7jn7/BB2/He TNMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779618828; x=1780223628; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l8o6cIS01j0pOwxkyeeRqH0JHndoNuqGw7yx7pJcTtI=; b=q22apHgSk3mfYnDWqMwIp15nKeUJjq4rG1Db4o7D+t97112eQbpLy/l+7+HyUhkSgE 9xjzO5G28nV/43wkYXN1Kr0GW9s38RftHW6EAjcOkCWBnTp453mcTD8sD6j78OiVFgfx 9b09ZA5VxAZlkwjcC62VO8rov5vsVnegqk2ijqUOyS8gH0uslE1qdi050vz8h7DDKew2 orA9QRV99kSVpB8UG7SpK0gENNVh9UKKJjyTCNtRNhugTWyekZqEj2WhiNCIObYEmEnM F2vgVx+Ffuy3OZLdg5Mrnk1+lml0wfX8t+q7SQxtnGfOP3RpigHa2I3YmXeTmMl7WFYI Pohw== X-Forwarded-Encrypted: i=1; AFNElJ/ZyArLxqti6Le/DXAbH0Zh41ATFXj6Ee6pCHVSkGxrbD6vnfdLai3DCeujjj95Uf82RpMmhqQnS9xMxfI=@vger.kernel.org X-Gm-Message-State: AOJu0YwK5VMhipwel9FuLolwPtjgZlaW41FX66/eQWoCZn0LwEOXlidk tP+kyVpgtDemift78ryyXgIXU5yOp/FHzIbwS192C4Mynfk+BGab7MLEUDlC9pgh6M6V4Rapfeb qC3IR5MhWeu+wC5N+Z87E23DJ1nnJkBXj20l42wOznHDI5+LhUPE5fXDEw3MbKG092SA= X-Gm-Gg: Acq92OETIwAJzkBJrOjfGtsIXlQGB/erZKM5aGhSoPx+iZagXqEV6eBAk/9n6Imd35R 2eQ2Vys5Zi3dAovImnx+Pt7Iv7f2QXUWaNnRD2KG3J5zqg3M3tYjrqHBuaILXkeaJia+N98vTW4 Ee4UvJxyVuIRxNvu5QZ8aSJL9DhBQ3Gk2yf3DOu9ZUMGuVzAy7hcDPXMF+HPYH+NmoS5ElqVNbt jOUNg2cRJPu1alt1bKVyLzN0URrPJTzwJxrDp0gO6DwP1avdqjJEPqNuLu3e6FVzA6Rb675wTWe oZ5iBnmf1b32wTi9unJ6FJZ9KVVzwCfdVdeqJqv/ZAp/yKYVt2MbUf6eQy5WCwGQz1bq6LFYQDW lZn2ns0JeDFdp+9PKJ1XfsPpkbsXxvJ39F4ANSzj8IACr3hVHN7ZPMQ623lhVC+jyLF5KCq4k8N Iwl3y+ofmJ3wVe7/zORECmkbAiztDeQ7FUj6c= X-Received: by 2002:a05:6122:3102:b0:56e:e9cf:7134 with SMTP id 71dfb90a1353d-5865ee6c055mr5365412e0c.3.1779618827846; Sun, 24 May 2026 03:33:47 -0700 (PDT) X-Received: by 2002:a05:6122:3102:b0:56e:e9cf:7134 with SMTP id 71dfb90a1353d-5865ee6c055mr5365392e0c.3.1779618827398; Sun, 24 May 2026 03:33:47 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa32cba880sm1816148e87.32.2026.05.24.03.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 03:33:45 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 24 May 2026 13:33:33 +0300 Subject: [PATCH v6 05/10] drm/msm/dp: Drop EV_USER_NOTIFICATION Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260524-hpd-refactor-v6-5-cf3ab488dd7b@oss.qualcomm.com> References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> In-Reply-To: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Bjorn Andersson , Konrad Dybcio , Val Packett X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4470; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=7YL2ddERO+WKYrbTK+cxw/v4FUdiddSRzjsP3v7dOZY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqEtP8GADJovtb7rXvgjO2Y/Y256UfXFTz5vVkj Y27da5YrWqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCahLT/AAKCRCLPIo+Aiko 1WZjCACZl57V2MEbFbABu1TZ94QulG4M1cMv+VkqWhuzs7MQFLmzy166Yi+2PPo/Y5mQyyW7jmw SaaqWdfaqBDp3uI3JzpbYeWxH0J6ZAiXkQGJCfVKlKriHN5DJ3t32lYBEZmbLYy2sSwS+fAyOT6 Ki45bFDNvsTv4CNxJ/pAHoN0yeR9rmVbFztEPGTT1nWgS31TngmP49SAtj2A03OU6q1+rZ4Vqx0 sR9AaFNVgqyVkG8ellSQqmLVdEQY6A4X7LogzvFtRdBTOFxhGNnQ02VmbbcPK1B3wRDeu4yR2nB EUAhewevR+3uDLNdC6uC11jQi3HEmIgFL8CBSOm9IqJb0mVq X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: Gk2D1p6HCsFFNij5PEyWqryUb0AwnPnB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI0MDEwNyBTYWx0ZWRfXxfdgpm4t1awZ QFV2UJnf6wsHScFSJ3zxzcuQK9dBxKTDhiuNNg1ngQAnn2YSux8udOde1rnrb6ZWB7gCRg5P2mS XKs402MnJFyRF81py9WLo+kKAwuwfjJj6po+mwE63rGadpuIJOznM+edkynqumY96/zZlAuCa3X os9VtVXHeg1n8MakWWlcMvAcALK82vg5qfD+dS/xH+YMwjQTELcb4Pkb4cxxN6VeIKYWZmQoNtM jXryU0VUBTFUxCiizvgP5QbOKXOpXaedGLReOv8qVS4+e8GZ2G48R8briSy/YuWyXkYngN1jvR8 fTaN9bb9xKDMMk0zkc7aUnc19q8tIBflgOnOGuh4otyD7for6ZLV1XLB5W/pvIqddMs/xDz0hAp FOs8cshaTjwGgGLJhW/fnB41w141RHx9FA7+vL9Xrdv9b1QVxuPpylXWotn68gh6quSXpFTYN6W la+jSi1eX+uzPrZXO/w== X-Proofpoint-GUID: Gk2D1p6HCsFFNij5PEyWqryUb0AwnPnB X-Authority-Analysis: v=2.4 cv=Xca5Co55 c=1 sm=1 tr=0 ts=6a12d40c cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=gW5k9mFOS1cgrKxYKbgA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-24_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605240107 From: Jessica Zhang Currently, we queue an event for signalling HPD connect/disconnect. This can mean a delay in plug/unplug handling and notifying DRM core when a hotplug happens. Drop EV_USER_NOTIFICATION and signal the IRQ event as part of hotplug handling. Signed-off-by: Jessica Zhang Reviewed-by: Bjorn Andersson Acked-by: Konrad Dybcio Reviewed-by: Konrad Dybcio Tested-by: Val Packett # x1e80100-dell-latitude-7455 Tested-by: Yongxing Mou # Hamoa IOT EVK, QCS8300 Ride Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 28 ++++++++-------------------- drivers/gpu/drm/msm/dp/dp_display.h | 1 + drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ 3 files changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 036b4a5cece5..6b76bff7c8d0 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -58,7 +58,6 @@ enum { EV_HPD_PLUG_INT, EV_IRQ_HPD_INT, EV_HPD_UNPLUG_INT, - EV_USER_NOTIFICATION, }; #define EVENT_TIMEOUT (HZ/10) /* 100ms */ @@ -344,17 +343,6 @@ static const struct component_ops msm_dp_display_comp_ops = { .unbind = msm_dp_display_unbind, }; -static void msm_dp_display_send_hpd_event(struct msm_dp *msm_dp_display) -{ - struct msm_dp_display_private *dp; - struct drm_connector *connector; - - dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); - - connector = dp->msm_dp_display.connector; - drm_helper_hpd_irq_event(connector->dev); -} - static int msm_dp_display_send_hpd_notification(struct msm_dp_display_private *dp, bool hpd) { @@ -378,7 +366,11 @@ static int msm_dp_display_send_hpd_notification(struct msm_dp_display_private *d drm_dbg_dp(dp->drm_dev, "type=%d hpd=%d\n", dp->msm_dp_display.connector_type, hpd); - msm_dp_display_send_hpd_event(&dp->msm_dp_display); + + drm_bridge_hpd_notify(dp->msm_dp_display.bridge, + hpd ? + connector_status_connected : + connector_status_disconnected); return 0; } @@ -438,7 +430,7 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) msm_dp_link_reset_phy_params_vx_px(dp->link); - msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); + msm_dp_display_send_hpd_notification(dp, true); end: return rc; @@ -507,7 +499,7 @@ static int msm_dp_display_notify_disconnect(struct device *dev) { struct msm_dp_display_private *dp = dev_get_dp_display_private(dev); - msm_dp_add_event(dp, EV_USER_NOTIFICATION, false, 0); + msm_dp_display_send_hpd_notification(dp, false); return 0; } @@ -528,7 +520,7 @@ static int msm_dp_display_handle_port_status_changed(struct msm_dp_display_priva drm_dbg_dp(dp->drm_dev, "sink count is zero, nothing to do\n"); if (dp->hpd_state != ST_DISCONNECTED) { dp->hpd_state = ST_DISCONNECT_PENDING; - msm_dp_add_event(dp, EV_USER_NOTIFICATION, false, 0); + msm_dp_display_send_hpd_notification(dp, false); } } else { if (dp->hpd_state == ST_DISCONNECTED) { @@ -1122,10 +1114,6 @@ static int hpd_event_thread(void *data) case EV_IRQ_HPD_INT: msm_dp_irq_hpd_handle(msm_dp_priv, todo->data); break; - case EV_USER_NOTIFICATION: - msm_dp_display_send_hpd_notification(msm_dp_priv, - todo->data); - break; default: break; } diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h index cc6e2cab36e9..60094061c102 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.h +++ b/drivers/gpu/drm/msm/dp/dp_display.h @@ -16,6 +16,7 @@ struct msm_dp { struct platform_device *pdev; struct drm_connector *connector; struct drm_bridge *next_bridge; + struct drm_bridge *bridge; bool link_ready; bool audio_enabled; bool power_on; diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 991a3ca1e6bd..528c9a40477f 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -340,6 +340,8 @@ int msm_dp_bridge_init(struct msm_dp *msm_dp_display, struct drm_device *dev, } } + msm_dp_display->bridge = bridge; + return 0; } -- 2.47.3