From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B0B3A8721 for ; Sun, 24 May 2026 16:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779639149; cv=none; b=d64cwB5FeFpRrdpWFDrTA8c4GmEk4Sx4py4w3zu/071MQOOU8t7PayNroi0Q9WoLm9EHSTi/1BvOCLOEwPTQoYRVhaznlY1wIZBp41BPWvYeGmAfYH4eRbn5qL2jbaL53pf+HC7xRW7nv9oTrLiLFptI8SkD96G3Y4MAt2VAAX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779639149; c=relaxed/simple; bh=GNE2yLcVmAnaMs7p03niEqNRSstWxlcBl/ztKs03sM0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pLIHxC9XqU2ACJBaphIu+xJbRp5ku44BRZ/dyCuyxotD3gOG6KAsn62tNzCDvsLd6rjnmOqBNGQLyxwLmjvLeAGmZJHsUoE2cKqCUySrgo9dzDYC7TgRIl9ZjjO8VkdYM4IHYWdkZQ2WTgP+yI40bMb3TjA0Zlzv86/LY2Cu5p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-43a2ad7bcc4so4076662fac.1 for ; Sun, 24 May 2026 09:12:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779639146; x=1780243946; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=25z3ic8/Pkx2AcYB/9aDrA71CiSAFUJRzNWM3+IEVSA=; b=SjQDMdL9VSk24D4Cr/ecNrcoMNUmbcWjdIxPKK9MdFEgJcbq3OkNEAKiOiioPAOHxM lGy1bZsH23mDXDQaxQYb2YeRseqTv0gG1hBNabFTez8ZyGOnhqXg+p3kFtH7vv7CLlWT FoM5PnjMySk65NjEctzG789FSqW28tuJqki0Wt609vmS/4iacOragMrLf6P/5YIqpumf hmFIvJc2DVnJXN6s7AmQkpVn/af4ghXuXNh+KjRfwI2wwyAKKTvejPRX4aEzLeOkHwaE UBVfKpXZ7PwbFl8LLaIsdmJnXHlC0jUbjaMlTLlviiJ0sG1Y6zKVEp+4jDH/XLkpkiNf BSAg== X-Forwarded-Encrypted: i=1; AFNElJ+lO3CwUVG/5BFpzL671J0FIhSgpYWaZMzTrApu3fCZwcTu5rBYj1TsWwCZ0Aguhkv1EksvvLwy3AvEVVo=@vger.kernel.org X-Gm-Message-State: AOJu0YybBpWaGwdcZJNI4jWKGtfTz/d4hOmilsY/aDGD/Bh9TbRMFySR bbk1jx6FQsyygGx0WteOcfNW1XVBDEM3IJVEgmlk8+VZMh86SPp64f9C0go5mNiu X-Gm-Gg: Acq92OEImJjpXdmuQizhELk9PtacuhZ/+imkLRRH0qk6qJTPKpJ5LRKst5RNr6TZG/5 vwPKdSYnmtwp+q5077jFv7OL/pO+9hsYX7HImSE7HXBV9ZrtzdFwdea9gI1quZOS3QevRG5jbbM Nd6+u/Zl5+De2fuc1WAhuJZuYuB3uMdxFB3kb+wg5/HlTq1dOmZO+ukHvsGRTYlQlo/KwUaGB1y i7+7HqBo9OYi4xkmyGrC+PIE4Ufs0IVN5O3jf1/4KsrFkCOxxa63vgSr3ABsLHAB4iOZh/gz3ve 8UN/PiGZT2k3XO90fdGeogpDy3THGrTL03FF/kJ5iTVGMSaPlzxVJPDo1QsLaA6phjzVNbF4ack o8/49po3MtTdczKekqclBYQ6sUXHrCet9wEQ3O1dT1mqkkfjTC4S2viEsn3NbmuwWq64Yn80jsR 9AoPeL1btJVyO0oVeo3TINdeAb X-Received: by 2002:a05:6870:d36e:b0:42c:1a8e:7f84 with SMTP id 586e51a60fabf-43b5aa16546mr6645847fac.4.1779639146237; Sun, 24 May 2026 09:12:26 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:40::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43b63512d63sm7646019fac.2.2026.05.24.09.12.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 09:12:25 -0700 (PDT) From: Breno Leitao Date: Sun, 24 May 2026 09:12:19 -0700 Subject: [PATCH 3/9] netconsole: move refill_skbs_work_handler() from netpoll Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260524-netconsole_move_more-v1-3-909d1ab398b4@debian.org> References: <20260524-netconsole_move_more-v1-0-909d1ab398b4@debian.org> In-Reply-To: <20260524-netconsole_move_more-v1-0-909d1ab398b4@debian.org> To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gustavold@gmail.com, asantostc@gmail.com, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.16-dev-d5d98 X-Developer-Signature: v=1; a=openpgp-sha256; l=2410; i=leitao@debian.org; h=from:subject:message-id; bh=GNE2yLcVmAnaMs7p03niEqNRSstWxlcBl/ztKs03sM0=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBqEyNlGC2QPKnSBTStkOWy5dirRvVJvuTsmZ3pc YFnsdXAM4CJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCahMjZQAKCRA1o5Of/Hh3 bV3rD/4jNzFbGDNiwaiK+mjIptKK/m7rF/fDd/zwoeYN3L9Pi78WqnYyO1ze5Pgd3xjZUmiqm7m sz3wTAeiFAa56IBZIPby+VRSK6FaSd7N49zhpm/U+VJBilNJVxPSTrXKoe6SQ/WwpOM3xXH3FGS OhBR/367FVsyCfV/9LVRfHbFd5BHfPABM0hPsFoJaJc4E3V+UlItpGtSB9u74/7ylbU8cIKMphU yTETzpz+47z50B26TZUA4gptEXq+D6/Xizj8Igiach4sancEsnOEoguwn5hXRGgZ80VTyWPwl9d dCZI0SN7MwiKvZRTOaAm5wyx8/eQs+uWeIrna+xc6A62OV2/yamuHch6MJMCuFMmWA0Mn2Addlk UyJVrUN4RV9FqZuZcu5LQvUrNnj0Dgrnvt8F/yhYgsStghMaFLG9QbkhpFoi0YptXX7o7hAGQAq 5yR77IUzlydlWq65z0nihjauio2Jp5SZUPZ9V2ztUC74A/tzKduyHSSL5Mu014AG4hAV7TAYPNk fHMbZ19UmXE3ZdctppNiWNa7Xuuv9+y1omLv1uHkQ3Xteu20s/gV5ZJaylT6V6+SbhtwNPlTehM bbjgQ3uknaFyB8PHCs8DB9nWIoigz6w26pQKCqmzkXAutQtq9M8Q667S14EaRe4TFgOMatZgtbw wxfSQigWVDPxQpw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D The work handler is wired via INIT_WORK() in netconsole_skb_pool_init() and has no other callers since the previous patch took the skb pool lifecycle out of __netpoll_setup(). Move the function body into drivers/net/netconsole.c as a file-static helper, drop EXPORT_SYMBOL_GPL() and remove the prototype from . Pure code motion: the body is unchanged and still calls the exported refill_skbs() in net/core/netpoll.c. Signed-off-by: Breno Leitao --- drivers/net/netconsole.c | 8 ++++++++ include/linux/netpoll.h | 1 - net/core/netpoll.c | 9 --------- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index b84de3ba44c3..3d7d17c59902 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -283,6 +283,14 @@ static bool bound_by_mac(struct netconsole_target *nt) return is_valid_ether_addr(nt->np.dev_mac); } +static void refill_skbs_work_handler(struct work_struct *work) +{ + struct netpoll *np = + container_of(work, struct netpoll, refill_wq); + + refill_skbs(np); +} + /* Initialise the per-target skb pool that find_skb() falls back to and * seed it. Pair with netconsole_skb_pool_flush() at the matching * netpoll teardown. diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index 9fa4deed0bff..1a497d12f336 100644 --- a/include/linux/netpoll.h +++ b/include/linux/netpoll.h @@ -75,7 +75,6 @@ void do_netpoll_cleanup(struct netpoll *np); netdev_tx_t netpoll_send_skb(struct netpoll *np, struct sk_buff *skb); void netpoll_zap_completion_queue(void); void refill_skbs(struct netpoll *np); -void refill_skbs_work_handler(struct work_struct *work); void skb_pool_flush(struct netpoll *np); #ifdef CONFIG_NETPOLL diff --git a/net/core/netpoll.c b/net/core/netpoll.c index a4d176ff9376..4111d6ee8d4b 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -367,15 +367,6 @@ void skb_pool_flush(struct netpoll *np) } EXPORT_SYMBOL_GPL(skb_pool_flush); -void refill_skbs_work_handler(struct work_struct *work) -{ - struct netpoll *np = - container_of(work, struct netpoll, refill_wq); - - refill_skbs(np); -} -EXPORT_SYMBOL_GPL(refill_skbs_work_handler); - int __netpoll_setup(struct netpoll *np, struct net_device *ndev) { struct netpoll_info *npinfo; -- 2.54.0