From: DaeMyung Kang <charsyam@gmail.com>
To: Namjae Jeon <linkinjeon@kernel.org>, Hyunchul Lee <hyc.lee@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
DaeMyung Kang <charsyam@gmail.com>
Subject: [PATCH 0/2] ntfs: fix link name free and $FILE_NAME validation
Date: Sun, 24 May 2026 14:42:36 +0900 [thread overview]
Message-ID: <20260524054238.3129288-1-charsyam@gmail.com> (raw)
This series contains two independent fixes for fs/ntfs.
Patch 1 corrects ntfs_link()'s release of the new link name.
ntfs_nlstoucs() returns a buffer allocated from ntfs_name_cache, and
every other namei.c caller releases it with kmem_cache_free(); only
ntfs_link() used kfree(). The conversion failure path is also adjusted
so the common out label is not reached with a NULL pointer that would
hit kmem_cache_free().
Patch 2 validates that a resident $FILE_NAME attribute can actually
hold the variable-length UTF-16 name implied by file_name_length.
A crafted image was reproduced under KASAN as a slab-out-of-bounds
read from a kmalloc-1k MFT record copy through ntfs_attr_name_get().
The validation is added before ntfs_attr_find() and
ntfs_external_attr_find() return the attribute, covering both the
AT_FILE_NAME and AT_UNUSED enumeration lookup paths.
The two patches are independent and can be applied in either order.
DaeMyung Kang (2):
ntfs: free link name from ntfs_name_cache
ntfs: validate resident file name attribute length
fs/ntfs/attrib.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
fs/ntfs/namei.c | 5 ++---
2 files changed, 48 insertions(+), 3 deletions(-)
--
2.43.0
next reply other threads:[~2026-05-24 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 5:42 DaeMyung Kang [this message]
2026-05-24 5:42 ` [PATCH 1/2] ntfs: free link name from ntfs_name_cache DaeMyung Kang
2026-05-25 12:51 ` Namjae Jeon
2026-05-24 5:42 ` [PATCH 2/2] ntfs: validate resident file name attribute length DaeMyung Kang
2026-05-25 6:38 ` Namjae Jeon
2026-05-25 16:32 ` [PATCH v2] ntfs: validate resident attribute values on lookup DaeMyung Kang
2026-05-26 0:08 ` Namjae Jeon
2026-05-26 1:05 ` CharSyam
2026-05-26 13:31 ` [PATCH v3] " DaeMyung Kang
2026-05-27 23:48 ` Namjae Jeon
2026-05-28 5:56 ` Hyunchul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260524054238.3129288-1-charsyam@gmail.com \
--to=charsyam@gmail.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®