From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 025A23016F7 for ; Sun, 24 May 2026 19:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779651009; cv=none; b=U0diNGYq2Hq1tGSIwVv91GEVc0Sqq8M1fF867yma6EEDFas5o38XIWUHoWSZfS8tkKQsHGfRTDaTEnJmSxWgWqWIctU4wS6oEn6DDICgcCf01MqQqOOw25yYr+R3XdYfWcTkSYDd205YJkjstqJoLWxOsq2qHrndkBd0Z/OsIHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779651009; c=relaxed/simple; bh=aQGHbzwD8XvoBZlnyYmSpbPjlEUQmQSq7kMMzigIpcs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=laC60/dpD+cqiWDGncQiInyQIaSMHmJzhtPO5UIv0xCOmw+bQy8evJO9UYlRfuHgWPqLdWAzBUnf8gY7S7KLPh9CBxtRPCw1kWtCBuA/N6ctoQ/ADAme2KPKnhpgSvIhBgGXDfe2FwoD/51Y5z84duiBCy1loCqANqFgW5DQ1/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RA7GfO87; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RA7GfO87" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2bc763e2ba8so44772195ad.3 for ; Sun, 24 May 2026 12:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779651007; x=1780255807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1EfWIGBBAe6WYbf3D5tIwvhwfgl7sXJJFkfUQOgxxis=; b=RA7GfO87N/btQUPFZupzP4LdUxj5f14fu7g1/xmd322hWqFBVgqEFbL1goafGn1Pq5 YwgLirI1jBsyN9G+GOIdfDhr385PU80oveUu5l+CbyYAiITONW35ivj113SmWa+2u44a ZKYwiiE2+Pa9XRpQlOH8MD/+JDG2H6CvhXR+eReafZlsIOkGDmJoIYIiOvvSYvwJ1l6J lL4k28iGq2QOdqwf+lusq95RryZ31KU8qWLfIMHDu+CCvJzU206aOI32lmacdLHSvTUF +kqDBjnhcgLfA6hAjWoHhMCCubyOrMeERqoUqgmA7NHcuJ2RcS+tyWpuQSuHhW80rwg0 B2OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779651007; x=1780255807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1EfWIGBBAe6WYbf3D5tIwvhwfgl7sXJJFkfUQOgxxis=; b=C1YVi5NjApvFKFA6ESfiCktnU0oz9Ra2U1c3P08fSs0GBGXQBUEj8F1YpDCDFilicR XpfQh3iqME9URNl5TeY8uC6vj4gnaz3c2KdQ56AWUgQGSc8623MuaPfyGXo3HhSW3a6/ HF791ekl6iy4ZhiKqXvBA1KOGbJAhsNP2HeNm2h18bMO1sVGX3SSzs+ZdBYfmeWBq/G6 HSOGQ5TPFUgA8rNc0HaImVg5xKhPQXcuNoYGa+exyEIkXtrvtBoPRSSJDjyXJMcnoIzt 7Kjkv3wxSAzfHVGNbVKMTvhojCPMq/iJEaGaPg7v0u73qRhLnZ9F2ucLfI2nIkacezQp TsmQ== X-Forwarded-Encrypted: i=1; AFNElJ/flonPsdUie+1TlfJasftJO70RUIUkrHJ7xYuFjFCBYnovIx1Ncwu5Jy6dCUaxD1up9XC3JlCTJYqCI50=@vger.kernel.org X-Gm-Message-State: AOJu0YzT5tcWRjShHSXhgRdoi+WY87TAunf38wJM/Ngi1Jyltqo4Kold 2QZXKmMSvor+oKVQMMQV1H5YKS3p0jxlQQG6IrqVrFf89qy3/CtKR06u X-Gm-Gg: Acq92OEF+DzE1s6brb5B9aU3aX1zu3Do+mUv/VVan2r0w3aohvjpgQV+Rvo5Fr1LPH9 LKwHXcQmTpIh1ljAShMJx+mq5dZGoEdm4vVAZ9fdWyuaAw/uVmZk9o99DSNBddNUvVS1DjXwlkn imaMt9+hkqYSqDBq07G8ssorCm1RdzRSVfoUr84t1DGfSPasZoOKp3+nF2gsVAFlSs1dYchlZOR C+lRGn1eWN0F/a86QCPqPsj0d6FR8W+WHiW/TdXgsiFaHkbWRTb6fbUY+a87TLRPWaCcow6sWra YxADE61c9qKX/U12YehvKgUHbEz7UJfqTscd/VXQiKT0p9GazjTtKdlHhGfJCjjjHOrpmxQ5Vxk ciN8k5KQ8bMQTv168w4g4ndvxJvEgXahe1odWaJI0ZOrm9BkEHFjTkqPvdiko5XijMXGcQzmUUx BaDuwgSKaITElneWgeKof1jN3uCcQCNT+Y8ZkB0zctDNei+afU X-Received: by 2002:a17:902:e542:b0:2bd:b585:55f5 with SMTP id d9443c01a7336-2beb069c13dmr130607315ad.8.1779651007331; Sun, 24 May 2026 12:30:07 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58c3168sm72555465ad.58.2026.05.24.12.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 12:30:06 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 34/36] iio: position: hid-sensor-custom-intel-hinge: drop hid_sensor_remove_trigger() using devm API Date: Mon, 25 May 2026 00:59:41 +0530 Message-Id: <20260524192943.1196773-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260524192943.1196773-1-sanjayembedded@gmail.com> References: <20260524192943.1196773-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Use devm_hid_sensor_setup_trigger() to automatically release resource during fail, unbind or removal of driver using devres framework. This simplify the setup, remove goto, avoid manual resource cleanup in teardown path. Signed-off-by: Sanjay Chitroda --- drivers/iio/position/hid-sensor-custom-intel-hinge.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/position/hid-sensor-custom-intel-hinge.c b/drivers/iio/position/hid-sensor-custom-intel-hinge.c index e616988fe9f4..7844ed12c030 100644 --- a/drivers/iio/position/hid-sensor-custom-intel-hinge.c +++ b/drivers/iio/position/hid-sensor-custom-intel-hinge.c @@ -311,8 +311,8 @@ static int hid_hinge_probe(struct platform_device *pdev) indio_dev->modes = INDIO_DIRECT_MODE; atomic_set(&st->common_attributes.data_ready, 0); - ret = hid_sensor_setup_trigger(indio_dev, indio_dev->name, - &st->common_attributes); + ret = devm_hid_sensor_setup_trigger(dev, indio_dev, indio_dev->name, + &st->common_attributes); if (ret < 0) { dev_err(dev, "trigger setup failed\n"); return ret; @@ -324,7 +324,7 @@ static int hid_hinge_probe(struct platform_device *pdev) ret = sensor_hub_register_callback(hsdev, hsdev->usage, &st->callbacks); if (ret < 0) { dev_err(dev, "callback reg failed\n"); - goto error_remove_trigger; + return ret; } ret = iio_device_register(indio_dev); @@ -337,8 +337,6 @@ static int hid_hinge_probe(struct platform_device *pdev) error_remove_callback: sensor_hub_remove_callback(hsdev, hsdev->usage); -error_remove_trigger: - hid_sensor_remove_trigger(&st->common_attributes); return ret; } @@ -347,11 +345,9 @@ static void hid_hinge_remove(struct platform_device *pdev) { struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev); struct iio_dev *indio_dev = platform_get_drvdata(pdev); - struct hinge_state *st = iio_priv(indio_dev); iio_device_unregister(indio_dev); sensor_hub_remove_callback(hsdev, hsdev->usage); - hid_sensor_remove_trigger(&st->common_attributes); } static const struct platform_device_id hid_hinge_ids[] = { -- 2.34.1