From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29CC130C145 for ; Sun, 24 May 2026 19:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779651952; cv=none; b=mzQXHytQkOGUEyEgkijGAMdGWHt1kogUDxQLSNcAz4HlCDfPu8SN4C713cYS+zrRwcshFO0SCJ/e9DrvSF9GslZ/0MOV+kCLQT7heNoT76mqse94GRXEhn2cuquFDAtX3KwbAHXQuCtmfc/qBC+otNCzMtBlAs0wI6+VHiB0xr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779651952; c=relaxed/simple; bh=QOH23cOE5ksNBRXS1I4/u4f1LkCMC6S9hdVW59i/FDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D6gsbgm3S6EMN01IytkmKj4epv8LzfokwP86ZR6j2T0ZGzyGWGjvzb+LMNKYM/1wmDc3+SNY31REa0SCLde5Xv2kqy7als5MxS0UAeqKnr7mKXsQDRv49reAMQZMdwEsq8t5v0/f1yxgCrUnNv10yzrD7U0+CzqBmRA2s4JcQgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ho+vWIYv; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ho+vWIYv" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36abfe17c11so704759a91.0 for ; Sun, 24 May 2026 12:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779651948; x=1780256748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ii2qt5Ov08fmFNNaHs2Sw1nWb5YUcmi/e2JrpHiw+2Q=; b=ho+vWIYvwtPXd1i3wOCAo8EwTN4pkJ0Q8SkLWMyr+yFTABtLhq1Mt+3le0hc+XxZwr WPnlWCH/BgajciC9GU97iAuKH5gURVn1KZfYuzsiJRI0NMDeWjW4oN02QnP5f84IaG4o AJ1XkM0DUhWWehyXjacgGarOiOuKDRbdapnLJBMmp0/mrwzj8eFVJNEsw7e/uUHDZuf/ htdPVG+lxbdW8gBddqP8I2K9+Mpfv7lHxtmXZsrQ7RLQutDKuA6eKT3pCuxjMt1uYiOn 8wzk1eOMwijU5U7r8laKIsTn0rBGauER8faMpLS8myZxGYsXgs2lyMOcLUkrxuMjFyR5 b8WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779651948; x=1780256748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ii2qt5Ov08fmFNNaHs2Sw1nWb5YUcmi/e2JrpHiw+2Q=; b=jxIHGyJ+oC78weWrjKgHYEZ3KoFLCTsmWwfd46pKTu/GpGebw2LQxTMuMicwFzuTj8 H5eZ9NYVkmk7KaP56zQTmrpgd5uFTxXuXjy3NCOKf2TpW1hT07pxS9Jn+/61c4ttNpc+ RycFOyfA/nl1rwGF/lTei9y9lxBpmc/gmwYzd8N70c4W9F8DIMaMHSQgblW4rfJ/gzMp CiWKUulae9tuBMrInDZFJuKCD5b1ONwRU9h04ZbH4vyWALrbm3yy9b79yHAqfdUnCHTS fne/Jrqs/Hgl4TF882E7hynPCqnlq5UTwIuEwwa0jYIFRxzwXsEFy2nSm0BXKA9GAkBW tOiQ== X-Forwarded-Encrypted: i=1; AFNElJ+x53pRZD7rTn/mUCD/aVXVOh3Nip75eQ6rsnZxbEpX3J/8SQm2M2DdWADZ6vtKSv3Ag4vpWaUWUi1z1RI=@vger.kernel.org X-Gm-Message-State: AOJu0YwbhWiE2/WDZMUOlAhW+iImyD2iS0LFPVxfBrO+7Q3O2eVrC8LP o9vE7p2kRczutXd7dBcf0t99VBZPqhelVJ7fCWpeqn3hmyAwcVO2Lvgc X-Gm-Gg: Acq92OG423Z3uR13IVSXH9DSLX7jUsVEyzryptmMDqz9pzBTpCPCmMt7/SdSpJyfDJp Sjfoudktge9AF+mwgTIc0JtT1+4p3NeKtUAxq6o2rn7VIQ5S9eXM+MQiBeTVrkP8kKX5+NIfi4I vCm76UiywB3MvuJGknRWmgARVdZJoBcGqJtMVL8k/7CDZUPMeYblNUQDw8fr0mKV5k8IyFKH8/i ewhYBR4ITXtvO+7++38LhmTHgiLImqKCMo8yszhvBeJ0O2FnV/P6jNWqOS9+B8du5LCqorJ5zRX o1LjhDGmBKRMgyiQHPr1CAR6IIvpps2wv1IN+3cop9PW++lYskx/8gq0tbgd7g06DK6MrTTMRpe 53GzBeUcF4n66myyE1Wa9Id5Fg6WfO0wWz3koJ8nc1IwSnAcsJuMURV3BZjncNLnY8LtrhVuP57 fnfy19fdhwco6jRttiF7kXZvJy X-Received: by 2002:a17:903:2bcc:b0:2bd:e5d4:dc63 with SMTP id d9443c01a7336-2beb070343emr131259625ad.26.1779651947922; Sun, 24 May 2026 12:45:47 -0700 (PDT) Received: from mincom1 ([125.149.177.227]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb590aa7esm74414485ad.78.2026.05.24.12.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 12:45:47 -0700 (PDT) From: Jihong Min To: Herbert Xu , linux-crypto@vger.kernel.org Cc: Christian Marangi , Antoine Tenart , "David S . Miller" , Richard van Schagen , linux-kernel@vger.kernel.org, Benjamin Larsson , Mieczyslaw Nalewaj , Aleksander Jan Bajkowski , Jihong Min Subject: [PATCH 1/6] crypto: eip93: return IRQ request errors from probe Date: Mon, 25 May 2026 04:45:23 +0900 Message-ID: <20260524194528.3666383-2-hurryman2212@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260524194528.3666383-1-hurryman2212@gmail.com> References: <20260524194528.3666383-1-hurryman2212@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit devm_request_threaded_irq() can fail, but eip93_crypto_probe() continues as if the interrupt handler was installed. Return the error immediately so the driver does not register algorithms for a device that cannot signal completions. Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support") Originally-by: Mieczyslaw Nalewaj Assisted-by: Codex:gpt-5.5 Signed-off-by: Jihong Min --- drivers/crypto/inside-secure/eip93/eip93-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/crypto/inside-secure/eip93/eip93-main.c index 7dccfdeb7b11..276839e1a515 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-main.c +++ b/drivers/crypto/inside-secure/eip93/eip93-main.c @@ -433,6 +433,8 @@ static int eip93_crypto_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(eip93->dev, eip93->irq, eip93_irq_handler, NULL, IRQF_ONESHOT, dev_name(eip93->dev), eip93); + if (ret) + return ret; eip93->ring = devm_kcalloc(eip93->dev, 1, sizeof(*eip93->ring), GFP_KERNEL); if (!eip93->ring) -- 2.53.0