From: Wentao Guan <guanwentao@uniontech.com>
To: petr.pavlu@suse.com
Cc: guanwentao@uniontech.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
masahiroy@kernel.org
Subject: Re: [PATCH v2] genksyms: Support arm64 CRC32 hardware acceleration1~
Date: Mon, 25 May 2026 16:02:29 +0800 [thread overview]
Message-ID: <20260525080229.1570905-1-guanwentao@uniontech.com> (raw)
In-Reply-To: <5d1b8b13-d590-497d-9185-609494135348@suse.com>
Hello Petr,
Thanks for your reply,
> Could you please provide measurements showing how this improves the
> runtime of genksyms and affects the overall kernel build time? Are
From my build kernel workload, genksyms perf report (record -g -F 99) show:
without patch:
- 7.83% 0.00% genksyms genksyms [.] _start
_start
- __libc_start_main
+ 3.19% yylex
1.81% find_symbol
0.92% is_reserved_word
0.62% free_list
+ 0.56% export_symbol
with patch:(find_symbol() and export_symbol() benifit from this):
- 7.12% 0.00% genksyms genksyms [.] _start
_start
- __libc_start_main
- 3.01% yylex
0.51% malloc
1.65% find_symbol
0.82% is_reserved_word
0.50% free_list
> CRC calculations actually a hot path in genksyms? I don't think it is
> worth complicating the genksyms code with architecture-specific
> optimizations unless there is a clear benefit.
Right.
> Additionally, many distributions already switched to gendwarfksyms last
> year. Unless someone provides a good reason to keep genksyms around,
> I expect it will be deprecated soon and eventually removed. It would be
> more valuable to show whether the same optimization is worthwhile for
> gendwarfksyms.
I see gendwarfksyms use crc32 from <zlib.h>, which from zlib1g-dev and zlib1g.
BRs
Wentao Guan
next prev parent reply other threads:[~2026-05-25 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 7:03 [PATCH v2] genksyms: Support arm64 CRC32 hardware acceleration Wentao Guan
2026-05-25 7:50 ` Petr Pavlu
2026-05-25 8:02 ` Wentao Guan [this message]
2026-05-25 9:09 ` [PATCH v2] genksyms: Support arm64 CRC32 hardware acceleration1~ Petr Pavlu
2026-05-25 13:41 ` Wentao Guan
2026-05-25 17:33 ` Petr Pavlu
2026-05-26 18:12 ` Wentao Guan
2026-05-26 19:13 ` Wentao Guan
2026-05-28 10:33 ` [PATCH v2] genksyms: Support arm64 CRC32 hardware acceleration kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525080229.1570905-1-guanwentao@uniontech.com \
--to=guanwentao@uniontech.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=petr.pavlu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®