From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD0CA3E168C for ; Mon, 25 May 2026 08:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697090; cv=none; b=PrwXJ895xQ7KXkyLeEj771lQ2lVLNYU+w7JHydd2VqfBrEF+qtYCH/6KuVtaoIgZWUKMgwaxW7xN3cDaLR8VN79KGZzq3qHnZHhex7AD+pEG1kcNM93w/QBNeLRAsWNT+FNTIw2ITig1mkQ6NvUpa0Zj8GGFIo3x0HrT9eulapw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697090; c=relaxed/simple; bh=A2UYesiuMtjbEp4erdKPoeYxaJI4NbYfA+DpALT+RSI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=npr3R/vRaFXFDaypmxXaTl/ixFnqY2Btujh/7UdqAbB0vR8SeenWXhK+f+oqmifrCn5kXaNHH74lp+ouSH5BY+RrO7U7E0IrHWYe/M2+qjd30lnIUXFMXfuA64ZDCasHmw2iF7Jo7IRrO8/bsONoFL9qGZTcCU+ScRRjuNgzSNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kedBNOx1; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kedBNOx1" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-367cbac9c37so5384332a91.2 for ; Mon, 25 May 2026 01:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779697088; x=1780301888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZbkFJTYwXGcL9YmL8kNq7n+6HKoUhYDKG8PtHv/96q8=; b=kedBNOx1PhX0ZYXxdgSGq4G9F29wQFge4XssrdhDgndRXnDHIpD2Pi64nOWLU+vWOz 5ew0+L3myoH5TEG6YT9peMOvqi9nvt1Cln/NwbxrHntxuiXeHp6kPPp/AuvzM/QnbgYA 2NbA34KdgSVoln1HLzz2GYAqtevRRnhUIXbxgAZe2LvB1WJl1pZ82q8qnLBQzVO0rOqH vmNWqnkXxod/93wlxnX8O9oFxT8a4Ycio+BuKvU4x/wcr5QO28TmJ2AhTetqueLk3JVf uhfVtnmlIEeI8TbGJJMBhwVOxDmJyqFo64xW+BI6p6MAM1U9+QoySGSBZ6iisXTNThi1 3mZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779697088; x=1780301888; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZbkFJTYwXGcL9YmL8kNq7n+6HKoUhYDKG8PtHv/96q8=; b=T1fetN/CUY1VvSupcOqjJHEc7oGX1wSvyIwajRHJt+h8Lsq6Cb2nz4NQbf25dbjVpF H+3tcHJm6i5fKH8nibU9Js7G4nkd49ylR3LJmwkw5Z5f9Iq+qyaUWMNdPhVZRyyF1kWP FY7XDaqGYhbjjQ6IsXU/M5NgGL1p4dudK5Zu05YfbKg+RltplLCxqIOB99BzJX+AVcfo uhkVcBKlkLf51EcMg+jruZQ1xAMopoX56dLhh7QV0sopBjQEaKYcRKeBIHxVHKL4JBBV 71Y1U523atlpYpdw/XWdXlHfndAVS8uyj/RvlZSVn4rTQPcHc9fws5l/XarS/4bX1KGL gHFA== X-Forwarded-Encrypted: i=1; AFNElJ9iEI01I4h1xIeN6s1pfqQeklyqXQmh5m0AmRS+U9VOk/2E7yfUlqphj8Nn6D6Rh2Dzis630bDLS9C+EZY=@vger.kernel.org X-Gm-Message-State: AOJu0YxdcDfuX3UzcP8dejJfThEZbXi0Dp9yC99GMN0HLPGSDvEZOS4A sh228DOtAlvO2AU+qeRxkJPnlO/Dcli+cyWc0zdfusvTaNsf175eLEPD X-Gm-Gg: Acq92OHphHUjojPP8OBnlBJy1T6dVt9LIRx+uiUAsvOix60/r+B3zl3OUUbc5edb9A9 oIfk5zoAoTb5ybJBzs+Pjo1JFnKtZ3bRYEVRG45011acwwg3T0e4ExJXHAVvAYU9fQKw4PVwBe4 jBaa2xJlpGbzJ0P6T/IKciTrnMfoYdQdcqSvhofZDM56P6IXyEClXe3g4OqfVfz3gs0T1dJnHkl rICnFH1sEv9Uc6Ay4erB1upHEkl8g8b1wcXhJtXLsVTP7SPHfoIK3+p9Tlnbo8KV/qDvN6A0QjV 1hz7BLZxF5AwkbWtuAndwXwrAEBtNLQhuPREVoS1gcP4ZrkxlsE3T/4kSNdOcA6hAedNAs/HCZk VBKs4aVJhP7n0QK3N5R06NhkjJiRYkGphGSccAdsbzxfvS3L4vTS2n/1etQNvVmYR3EP//IM/qq KA1jR1pJG2igw3UFazCAiLZvzjV735WOJ0F/anb/Gfeo1IuLse/vWszKxe3PohPC25dw== X-Received: by 2002:a17:90b:2f88:b0:368:a1c2:57fc with SMTP id 98e67ed59e1d1-36a67471bebmr13349114a91.12.1779697088100; Mon, 25 May 2026 01:18:08 -0700 (PDT) Received: from hcdev-d520mt2.. (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a721c7cf9sm8964102a91.10.2026.05.25.01.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 01:18:07 -0700 (PDT) From: a0282524688@gmail.com To: Lee Jones Cc: Ming Yu , linux-kernel@vger.kernel.org Subject: [PATCH v5 4/7] mfd: nct6694: Rename static I/O functions with _usb_ prefix Date: Mon, 25 May 2026 16:17:33 +0800 Message-Id: <20260525081736.2904310-5-a0282524688@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260525081736.2904310-1-a0282524688@gmail.com> References: <20260525081736.2904310-1-a0282524688@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ming Yu Rename the static I/O and error handling routines to include an `_usb_` prefix (e.g., nct6694_usb_read_msg, nct6694_usb_err_handling). This clearly identifies these functions as specific to the USB transport implementation. It improves code readability and avoids naming confusion with the core API abstracted in the shared header, preparing the codebase for future alternative transport drivers. Signed-off-by: Ming Yu --- Changes in v5: - Split from the monolithic v4 patch to follow the single logical change principle. drivers/mfd/nct6694.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/mfd/nct6694.c b/drivers/mfd/nct6694.c index b88863a0b70f..289580bbc472 100644 --- a/drivers/mfd/nct6694.c +++ b/drivers/mfd/nct6694.c @@ -79,7 +79,7 @@ static const struct mfd_cell nct6694_devs[] = { MFD_CELL_NAME("nct6694-rtc"), }; -static int nct6694_response_err_handling(struct nct6694 *nct6694, unsigned char err_status) +static int nct6694_usb_err_handling(struct nct6694 *nct6694, unsigned char err_status) { switch (err_status) { case NCT6694_NO_ERROR: @@ -104,7 +104,7 @@ static int nct6694_response_err_handling(struct nct6694 *nct6694, unsigned char } /** - * nct6694_read_msg() - Read message from NCT6694 device + * nct6694_usb_read_msg() - Read message from NCT6694 device via USB * @nct6694: NCT6694 device pointer * @cmd_hd: command header structure * @buf: buffer to store the response data @@ -115,9 +115,9 @@ static int nct6694_response_err_handling(struct nct6694 *nct6694, unsigned char * * Return: Negative value on error or 0 on success. */ -static int nct6694_read_msg(struct nct6694 *nct6694, - const struct nct6694_cmd_header *cmd_hd, - void *buf) +static int nct6694_usb_read_msg(struct nct6694 *nct6694, + const struct nct6694_cmd_header *cmd_hd, + void *buf) { struct nct6694_usb_data *udata = nct6694->priv; union nct6694_usb_msg *msg = udata->usb_msg; @@ -153,11 +153,11 @@ static int nct6694_read_msg(struct nct6694 *nct6694, return -EIO; } - return nct6694_response_err_handling(nct6694, msg->response_header.sts); + return nct6694_usb_err_handling(nct6694, msg->response_header.sts); } /** - * nct6694_write_msg() - Write message to NCT6694 device + * nct6694_usb_write_msg() - Write message to NCT6694 device via USB * @nct6694: NCT6694 device pointer * @cmd_hd: command header structure * @buf: buffer containing the data to be sent @@ -167,9 +167,9 @@ static int nct6694_read_msg(struct nct6694 *nct6694, * * Return: Negative value on error or 0 on success. */ -static int nct6694_write_msg(struct nct6694 *nct6694, - const struct nct6694_cmd_header *cmd_hd, - void *buf) +static int nct6694_usb_write_msg(struct nct6694 *nct6694, + const struct nct6694_cmd_header *cmd_hd, + void *buf) { struct nct6694_usb_data *udata = nct6694->priv; union nct6694_usb_msg *msg = udata->usb_msg; @@ -211,7 +211,7 @@ static int nct6694_write_msg(struct nct6694 *nct6694, return -EIO; } - return nct6694_response_err_handling(nct6694, msg->response_header.sts); + return nct6694_usb_err_handling(nct6694, msg->response_header.sts); } static void usb_int_callback(struct urb *urb) @@ -329,8 +329,8 @@ static int nct6694_usb_probe(struct usb_interface *iface, udata->udev = udev; nct6694->priv = udata; - nct6694->read_msg = nct6694_read_msg; - nct6694->write_msg = nct6694_write_msg; + nct6694->read_msg = nct6694_usb_read_msg; + nct6694->write_msg = nct6694_usb_write_msg; nct6694->domain = irq_domain_create_simple(NULL, NCT6694_NR_IRQS, 0, &nct6694_irq_domain_ops, -- 2.34.1