From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9FB342CA2 for ; Mon, 25 May 2026 08:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698746; cv=none; b=p+IHL6z15dLgFmqoSunk/IwLVFYvf1+VI6t4xRsFanx3rphdlAbd/FhVIsdjWUDs+lsYCIEO3aT+lt/G7FLY65J/gIP1MFtIdHcrCh08VeDlHlHY+X+fsC4ieS8bBI+eqC6HHG0qqpEYG1NvQpfMh4GpnFGB9PxOCjMthJfIsGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698746; c=relaxed/simple; bh=wTSqM9koNs+61o3qgmPLjzHlzMHe1qEAvZBMMINW2oA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=VOikxQ/RGRJLXuTmoKpdhhzosfi0iJL8MhUv6b45xkQLx3tcCHL++DwY7DatVEgKMVhBLfw7ZmRPdJ2tG2pBn1GWDolG86nfIOxRNVK3Pgty+hrX0sU1/TcirlgS82Ps3Uc1SbnMXpFV7oPl3+J6sBMtaozm4t2zQEEHVyW2Kyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CjCQfVjn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UDQDYIrB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CjCQfVjn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UDQDYIrB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779698744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rdMdPF6AjRDfJupohBg/unbXMgpat50XT188LnR7nHE=; b=CjCQfVjnDCFnO72TNnaAB60gy2c/dN8Fi4K/AKFL9kjsMkazOni5EN6Rm2NohPLd/Z+d0x eF8DncaQL3yUMF1NIHuQJSwlmbrkIxSVEqbCYzKd8ug0qHp1pEzczBsf6GS+tbttKQ/VmS DhvUzdLgmoVNGm2PdDZKx/NKEldmbks= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-rS1aBgmMPT6ZYpsi36jOEA-1; Mon, 25 May 2026 04:45:41 -0400 X-MC-Unique: rS1aBgmMPT6ZYpsi36jOEA-1 X-Mimecast-MFC-AGG-ID: rS1aBgmMPT6ZYpsi36jOEA_1779698740 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-38e9c93b90bso38395231fa.2 for ; Mon, 25 May 2026 01:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779698740; x=1780303540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rdMdPF6AjRDfJupohBg/unbXMgpat50XT188LnR7nHE=; b=UDQDYIrBkVNwjlfJlN6iPN+JqfOSfl26QNom3cLI0MdqZQdEZqicVaxUub8bMNglzL iq6ZISh6x9HM3PbLthVFPf6oRCA5D7vsfR9XcgQm1/yXi2XSuN4UeV5LrW7VvlAd3rur RAWoV4qcAh5AwJXTiCDkMlIgWVSRmLj1UUtIIM/IGnZ2s7PjZp5q5zUW16CKpQqTDlFx vr0u4+wRy0OhvT5VfXbSzknP1+kwDvEnokxiPAf6G2ZxK82gz4kESvnGikXShUMdtkNr uncWr0iQU6oOHgxekqlCQmr7q66GKPZ2lgZ9mijd4Nj1NIYlh0jdNMyRQKVZAp+aZI/B kwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779698740; x=1780303540; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rdMdPF6AjRDfJupohBg/unbXMgpat50XT188LnR7nHE=; b=XSGuQNo4KcoBKApG7x9uATHcx6Ks47Y855r5R4Dr78rpCbumsGN70tJ3MxuDVwvFw0 WaOvNG6EbsJs5hLD6MMqX5rUKwWd05cNb8DeINQQCvK4HruNBC51hbB1BLCiZr3Sa1TB 9xSv0aG4uDXuA12MK+Bzn57F/7YEnUIoBP/ZBKjXcb8gVHzq75mkDtBOm1UcQkRdE9Wt 32sgvlq11ipiEYK15I8Zg7X+RRpBA3NIG+tzfyDlGV+Aokh4DfJ/QyMVmfcGNjXtTP2m gEkb2j9QMawhftWpjf4gnidgy3zSiNnlGWXjH9cBrcbOks+g8bzLFCnbeuoJQRe5nazF jVJg== X-Forwarded-Encrypted: i=1; AFNElJ92MBb+TG2rJoAKxKt/JW9dB9TgIhujFTNrUwIjXN7IaVSW4NoiQaQqt+lEctT6ArpF6jBMp2qHU80zZN4=@vger.kernel.org X-Gm-Message-State: AOJu0YycTGYcS+iR8WtVMaXt0YRifCLrnS8/dVuzIvGQM6sLpj1bZgSl tKz5tN2o7Mark5z7LZ7ae4XGP/uKiJcqo3qi3GEoj+K12UscYQy3MWzvgm+O7gjxQo7b87TzQw0 VJVPegQfvN4nWBlm7KJjZpyRaWEsm8D5xoiPt2r2kOA/oL1NHK7Y4rOnSXjsQZuS3 X-Gm-Gg: Acq92OG7cJI2r+f1/XINzV5u/HngIC4gfq4D7vN0YFBbDRwCisItKGkb5b1oVMSGcsV QzQpe1NCxFnO/zcKeS3jTugVH5hLszw95kJtUwWKzpeWXyaXx/AlZ+FfwCx3PDBX2L5jiFlKgBR m5f1dfGFzua4Ud6up+hzPVH6zpWYggMyQy2WvIPRCfWqBlfZPjpSC3guqZFT88+nZg95XWNdWVM xqZDu+KQGkrZWsP0666KuDeuJEGruB69rVMbgs+aG9VQKJph/BIOJRo9EyDIg4tFibwJKCgJVDc TQaayFGcWukGyRr4u2Smt9cwG+TFzqYwntDYB0ve/nI5481zmBsU7vmFTbJseEZXibIGUe4vqra wkrVPDS7Pt7pRqOr30VLYOfusoDCggj8A2R5e X-Received: by 2002:a2e:bea0:0:b0:393:4e44:63ba with SMTP id 38308e7fff4ca-395d8e13013mr47052951fa.29.1779698740128; Mon, 25 May 2026 01:45:40 -0700 (PDT) X-Received: by 2002:a2e:bea0:0:b0:393:4e44:63ba with SMTP id 38308e7fff4ca-395d8e13013mr47052741fa.29.1779698739582; Mon, 25 May 2026 01:45:39 -0700 (PDT) Received: from fedora (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395dca7bcddsm21679061fa.16.2026.05.25.01.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 01:45:39 -0700 (PDT) From: mpenttil@redhat.com To: linux-mm@kvack.org Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Mika=20Penttil=C3=A4?= , David Hildenbrand , Jason Gunthorpe , Leon Romanovsky , Alistair Popple , Balbir Singh , Zi Yan , Matthew Brost , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Subject: [PATCH v12 0/5] Migrate on fault for device pages Date: Mon, 25 May 2026 11:45:19 +0300 Message-ID: <20260525084524.139868-1-mpenttil@redhat.com> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Mika Penttilä Currently, the way device page faulting and migration works is not optimal, if you want to do both fault handling and migration at once. Being able to migrate not present pages (or pages mapped with incorrect permissions, eg. COW) to the GPU requires doing either of the following sequences: 1. hmm_range_fault() - fault in non-present pages with correct permissions, etc. 2. migrate_vma_*() - migrate the pages Or: 1. migrate_vma_*() - migrate present pages 2. If non-present pages detected by migrate_vma_*(): a) call hmm_range_fault() to fault pages in b) call migrate_vma_*() again to migrate now present pages The problem with the first sequence is that you always have to do two page walks even when most of the time the pages are present or zero page mappings so the common case takes a performance hit. The second sequence is better for the common case, but far worse if pages aren't present because now you have to walk the page tables three times (once to find the page is not present, once so hmm_range_fault() can find a non-present page to fault in and once again to setup the migration). It is also tricky to code correctly. One page table walk could costs over 1000 cpu cycles on X86-64, which is a significant hit. We should be able to walk the page table once, faulting pages in as required and replacing them with migration entries if requested. Add a new flag to HMM APIs, HMM_PFN_REQ_MIGRATE, which tells to prepare for migration also during fault handling. Also, for the migrate_vma_setup() call paths, a flag, MIGRATE_VMA_FAULT, is added to tell to add fault handling to migrate. One extra benefit of migrating with hmm_range_fault() path is the migrate_vma.vma gets populated, so no need to retrieve that separataly. Tested in X86-64 VM with HMM test device, passing the selftests. For performance, the migrate throughput tests from the selftests show similar numbers (within error margin) as unmodified kernel. Tested also rebased on the "Remove device private pages from physical address space" series: https://lore.kernel.org/linux-mm/20260130111050.53670-1-jniethe@nvidia.com/ plus a small patch to adjust with no problems. Changes v11-v12 - Fix for issue found by Intel CI in patch 3 Changes v10-v11 - Fix nested mmap_read_lock in test suite - Addressed review comments from David Changes v9-v10 - Fix for issue Intel CI found, forgotten pte_unmap() before migration_entry_wait() Changes v8-v9 - rebase on drm-tip - fixed uaf around migrate_vma_split_folio() usage - added missing pmd unlock Changes v7-v8 - rebase on 7.0 - fixed subject in two patches - enhanced commit messages - squashed patch 6 into patch 4 to fix kernel test robot warning - readded dropped Cc block from cover letter - fixed white space Changes v6-v7 - rebase on 7.0.0-rc6 - added documentation and comments - denote to be migrated zero page as HMM_PFN_MIGRATE alone - got rid of HMM_PFN_INOUT_FLAGS movement in patch 2 - picked up Acked-By from David for patch 1 Changes v5-v6 - rebase on 7.0.0-rc4 - use range based TLB flushing while unmapping ptes - gate migration behind HMM_PFN_REQ_MIGRATE for fault and migrate paths - always infer migration flags from migrate->flags only Changes v4-v5 - rebase on 6.19 - fixed David's email address - fixed link issue without CONFIG_TRANSPARENT_HUGEPAGE - refactored into smaller commits - added more comments to code Changes v3-v4: - rebase on 6.19-rc8 - fixed issues found by kernel test robot with random configs - fixed typos Changes v2-v3: - rebase on 6.19-rc7 - fixed issues found by kernel test robot - fixed smatch issues reported by Dan Carpenter - fixes to lock handling (pmd/pte) on errors - added assertions for pmd/pte lock states - other issues discovered by Matthew, thanks! Changes v1-v2: - rebase on 6.19-rc6 - fixed issues found by kernel test robot - fixed locking (pmd/ptl) to cover handle_ and prepare_ regions parts if migrating - other issues discovered by Matthew, thanks! Changes RFC-v1: - rebase on 6.19-rc5 - adjust for the device THP - changes from feedback Revisions: - RFC https://lore.kernel.org/linux-mm/20250814072045.3637192-1-mpenttil@redhat.com/ - v1: https://lore.kernel.org/all/20260114091923.3950465-1-mpenttil@redhat.com/ - v2: https://lore.kernel.org/all/20260119112502.645059-1-mpenttil@redhat.com/ - v3: https://lore.kernel.org/all/20260126111939.1332983-2-mpenttil@redhat.com/ - v4: https://lore.kernel.org/all/20260202112622.2104213-1-mpenttil@redhat.com/ - v5: https://lore.kernel.org/linux-mm/20260211081301.2940672-1-mpenttil@redhat.com/ - v6: https://lore.kernel.org/linux-mm/20260316062407.3354636-1-mpenttil@redhat.com/ - v7: https://lore.kernel.org/linux-mm/20260330115611.347988-1-mpenttil@redhat.com/ - v8: https://lore.kernel.org/linux-mm/20260414041226.1539439-1-mpenttil@redhat.com/ - v9: https://lore.kernel.org/linux-mm/20260505051658.2219537-1-mpenttil@redhat.com/ - v10: https://lore.kernel.org/linux-mm/20260505184421.2324798-1-mpenttil@redhat.com/ - v11: https://lore.kernel.org/linux-mm/20260525050830.100254-1-mpenttil@redhat.com/ Cc: David Hildenbrand Cc: Jason Gunthorpe Cc: Leon Romanovsky Cc: Alistair Popple Cc: Balbir Singh Cc: Zi Yan Cc: Matthew Brost Cc: Andrew Morton Cc: Lorenzo Stoakes Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Mika Penttilä (5): mm/Kconfig: changes for migrate on fault for device pages mm: Add helper to convert HMM pfn to migrate pfn mm/hmm: do the plumbing for HMM to participate in migration mm: setup device page migration in HMM pagewalk lib/test_hmm: add a new testcase for the migrate on fault include/linux/hmm.h | 19 +- include/linux/migrate.h | 26 +- lib/test_hmm.c | 118 +++- lib/test_hmm_uapi.h | 19 +- mm/Kconfig | 2 + mm/hmm.c | 843 +++++++++++++++++++++++-- mm/migrate_device.c | 583 +++-------------- tools/testing/selftests/mm/hmm-tests.c | 54 ++ 8 files changed, 1086 insertions(+), 578 deletions(-) drm-tip base-commit: a79fb6644b307c0ced7b8fe967cdcac8ea884e03 -- 2.50.0