From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07A4D3859D2 for ; Mon, 25 May 2026 14:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720454; cv=none; b=I4qiaPpNrA96cL6NDdZgrLjtZxkEHrI8IWt21GlGZz7y9ER00xyGNRvs2JwQQBmeo1d5vtSn1n3CoxpUbbz9xO5V6t7WELyLFo49QwoV9o/osfGo2Fu45l2zyrnvZYhobp69s2yPU/oqEzcKUldrMk0NpAXKt1rWK2cIdWmTA4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779720454; c=relaxed/simple; bh=J1/LbVdtBZ+LOAFAQJmwliG2jdxMbt8JaagyM4ndmvk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vEAQI3ildlrFyc/JVp/DuwdNpezs3VefV+pqCg8RrRis/XOZVkTfcLbwEmwhnLGS2etZGks2hSWB3lm0uEbx/oX52/4WbMvWiYN012f/6akPQEZbjTTQ1e6IVYg428F1QAqbOQkaxN9z4JPGwIByL0M+OWpusiykqt7eYTqbt30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JHrBesYQ; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JHrBesYQ" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36900945df5so4814673a91.0 for ; Mon, 25 May 2026 07:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779720452; x=1780325252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wCToqKFCbrUX7FSNvgPMJdWqTINioLrARjrzWOT0nyY=; b=JHrBesYQRaI5e4WC2b9ogmODLsFEjp7JtJD5RtSokDayoX/n6TfDtV9wLkQHob6eYK EQsDldfFFXOWxZo8mJOEvYmKJzWy502c1rC0l9s+dcOf0xLcVU5tphZg9IhgfxQ1xoR3 OuuBYDFfJe3z6b/FId/yHfJn0CZ1KcPsGJ05AeclJPrgZqzdEY/7zYlNPVZr363Q0mEi 6ABSPEY6N2wgGNj+oYphiyGSPu47u4IyzG8dslqRcS7cb2bJDS+k40r1DiiUU2/Rm286 Ma4rpn++bP2t1eEVW6ogN1Vx9x/jo8g5HdG6P7D5uzf28WyYMLOOW94GfVwMnDzwUG+y pLDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720452; x=1780325252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wCToqKFCbrUX7FSNvgPMJdWqTINioLrARjrzWOT0nyY=; b=hCH3v/ehKer0B5Wro5Xt9PxmxB/obQ9FZD2kqzlbkQbK1JkC/OeFjtmFINZYple080 2psYkGGZMqSN7fRhPykUAc9q6sytIcMqeOJdQMGngmCutZUSw8ZPxkflIXNcyKIR6P5O qaEujVuHfgh3BhzvnriWCVyYSh2KkFAebMC4dg3tFDC9JrYPp4sllOKKOpZ4RwsBVrZO NwaMuNy5KnrSaM6X6D69on5K/ud86nPsCHcLad5m+l12OiqH3czqiAkrYJ/q1N4iduql e1mN2+xx1u9/hoJ4ppm6YqkcWngE4XS1rmiN9CJXf3W4ZuQhOirsDd1iBWTMnu4S7ov9 5Ysg== X-Forwarded-Encrypted: i=1; AFNElJ/0p2ErujyD6zc26MhLq4RkCGDkDt6xZp7UNO+4S5gPBypNHZdqKgcMygAXcS+8Nl2h8yQhMrpxe2ibFHs=@vger.kernel.org X-Gm-Message-State: AOJu0YzcsFakvOyvL9f4JYgeGSqS+GFg17oayCLIJAPKrUroBo4rAuXu x2dKJOLcdqt9f4oGYXSGB/a3DKXsaYYxhKswQ4D9YV7vMzpTCGDVpjeI X-Gm-Gg: Acq92OHy+8J01qznTz61exX9d8yu9uYiH1KjcDmx2T1ca0PmFE4WTbE3PSj0osRpqQl p8Bb6wU88CzU6OSDWbX63HuUaWPNG30iyI6J3+h6pbzEuQMCEbphpU++7+QPOphPo5YrSLYdOUz hfG/4Gmltrj7xJxKebhHNttymMq3MreNPG1HXJ9uaMrEbD+5u9jekU9sNgxpBwGB65kCPTtHp38 JgdODj9fGuH8HT7o8hZETp2Obstq1CciMmX05prtoz2DyofZMivWjPM6Q5Xy+cumiLoAbU2i4R/ 1qKtGjjJfVUZ2slMICT87cmRdNv7iMHrWj3OYd61JR89KdysY4cGruJ8trE43lhaYv4rqNERnA8 5EPcw26sGGcx+IWxV1JzSWw8EYtVE0Agh/B0oP9f8c+11TO+P32IwuSTlTgYutxe6b/qQ8+T+R+ q8o70saAZkfQRUVVIMll/DrAvw/qRCm37f8Oz5Szo= X-Received: by 2002:a17:90b:2f88:b0:369:a962:8cd7 with SMTP id 98e67ed59e1d1-36a6749afa1mr15044923a91.12.1779720452269; Mon, 25 May 2026 07:47:32 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a5f:4fa1:cc65:18c0:209b:38a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36abfe17c95sm2721993a91.0.2026.05.25.07.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:47:31 -0700 (PDT) From: Jun Yan To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bartosz Golaszewski , Vincent Knecht , Grant Feng , Andre Przywara , Geert Uytterhoeven , Viresh Kumar , Florian Fainelli , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Shawn Guo , Michal Simek , Heiko Stuebner , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Date: Mon, 25 May 2026 22:46:08 +0800 Message-ID: <20260525144629.498630-3-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com> References: <20260525144629.498630-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is active-low. Fix incorrect initial GPIO level to properly release the chip from shutdown state. 2. According to datasheet [1] definition: Shutdown mode can either be used as a means of reducing power consumption or generating a flashing display (repeatedly entering and leaving shutdown mode). During shutdown mode all registers retain their data. shutdown mode does NOT perform chip reset.A dedicated software reset is already implemented in driver by writing 0 to reset chip. Remove redundant unnecessary toggling of the shutdown GPIO. [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf Fixes: dddb4e38c6ba ("leds: is31fl319x: Add shutdown pin and generate a 5ms low pulse when startup") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl319x.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c index e411cee06dab..41087ed262cb 100644 --- a/drivers/leds/leds-is31fl319x.c +++ b/drivers/leds/leds-is31fl319x.c @@ -396,7 +396,10 @@ static int is31fl319x_parse_fw(struct device *dev, struct is31fl319x_chip *is31) int count; int ret; - is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_HIGH); + /* Driving this GPIO line low (in fact high) takes the chip out of shutdown, + * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device tree). + */ + is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_LOW); if (IS_ERR(is31->shutdown_gpio)) return dev_err_probe(dev, PTR_ERR(is31->shutdown_gpio), "Failed to get shutdown gpio\n"); @@ -506,12 +509,6 @@ static int is31fl319x_probe(struct i2c_client *client) if (err) return err; - if (is31->shutdown_gpio) { - gpiod_direction_output(is31->shutdown_gpio, 0); - mdelay(5); - gpiod_direction_output(is31->shutdown_gpio, 1); - } - is31->client = client; is31->regmap = devm_regmap_init_i2c(client, is31->cdef->is31fl319x_regmap_config); if (IS_ERR(is31->regmap)) -- 2.54.0