From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f202.google.com (mail-lj1-f202.google.com [209.85.208.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19053FF892 for ; Tue, 26 May 2026 14:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779805790; cv=none; b=GGMA+pkYqyIyQuDuZE2xQmK/XDNNBzKtykFQeVbA17E/E/V5l3RKZCRmY8ezE1AGBony9wiBnEhmMNQb8uTnmicjGBwSpr0YeSPnMcN5jOS7O3LNFriEDxTKr6U++sK5ZVkDhHdyw+ASr3moCOa4qJpSQVRzOPnoiywu70LtjZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779805790; c=relaxed/simple; bh=t8iULvrUFjdfHnddacmqp3ZwHRl8owAMguuh6bqpWXw=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=RSzV1aYGKT7NsVisEVqldYlDynf1pjVuXZL2kX8W4gqNmpbTHwLsKD2jOE90coEGpOqyeh0Opp+ZPPbJhLSkXH+kYbcR9t/Tq7sLR9pwQPtRYd350Edw5wUWTeQQZ+upGFs7YnCi188mye3tWB8eFHETiXkQZrH09OsUsAyRFSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--rnj.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=j8q9IkJ1; arc=none smtp.client-ip=209.85.208.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--rnj.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="j8q9IkJ1" Received: by mail-lj1-f202.google.com with SMTP id 38308e7fff4ca-38e83f0482eso42108441fa.3 for ; Tue, 26 May 2026 07:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779805786; x=1780410586; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=PT3pEfkfxVmH8RSCJKQXWybdiAmWTUp2RzVFlPVXXfQ=; b=j8q9IkJ1FnZlCj9wMfCKgMnlpDbxFEfAWyWdGQleBawo4F8Vtx6hctLh065o3ZbHuB Y1ZHDIXtXkrdKDJorpOCbddWC3nRKVE+QDsUWozoV35VsEMiYz/5nJ/s+Gfpo17T23IL mXj2lZMM1mQ/4pXwF0UzIiypm/whX/OcEkwKGijCr0QsF/eSk8HBKldqwzsVt7WwUXWk x7jA9IQvlDh+yOw550WCtOfuObTe9MJl9E0CTSZrqtFwg3Htz90vGYLF2DhSwSxcHb2J qUfZGvmA8CKSrouQdFSuleOewHOsYFqf4A1K/Saia1YsjUu5xjNEUa/XBV3SIPi7YeW3 9MXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779805786; x=1780410586; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PT3pEfkfxVmH8RSCJKQXWybdiAmWTUp2RzVFlPVXXfQ=; b=HdRtR73xD8ZhtCZ7Jmuhql3feOYJZY8d9GQiAtNyXKCsy6pYORNaXKZMTwgJH4OkB2 fRXZ5+eyWPJ08Zuo6OavaG0yXjVctKCqSQLEE8aL+0iUYoTC7WomaM05p79tOmb9FX2q CguYm0uNYlIdChcp5nqH6uAYME3P0w5lQlKZREusRe+byl3rjFrHK09EqTzoZJuCXlor w3HER/BUXRUI4NcxZ54yd4XecGjNQkgf1Q8Rzo+8kUIZrWQyoXNLY6iefbqzlS7mlCs9 9Pk7FcS+rvZ/4Jgj+0M69WvI7+n3l+j+D8a1b87J/9c3JryeWKxpPdaUWHM715UuMBlb 61nQ== X-Forwarded-Encrypted: i=1; AFNElJ95FbPKxO0F7nMw/eboh4JtTzJpWVnLCHwogOWg/S/yV8CLWnFE+gmsKT2I9o6jxJGsi+JpooOh+y3mGRk=@vger.kernel.org X-Gm-Message-State: AOJu0YyLXvmIzzbvs0pXYhq4f62uZGo8fSBIFF3JzpyoQygNCq7OCjmF 7jDDWlNC+OMxrslVRIbn2V8b6o2+8Lu093rEX91yJxXREI0lhnAE+4fdJJ2jbySHQMpOww== X-Received: from ljgv26.prod.google.com ([2002:a2e:925a:0:b0:38e:8a9b:c977]) (user=rnj job=prod-delivery.src-stubby-dispatcher) by 2002:a2e:bc90:0:b0:393:a2ec:da3f with SMTP id 38308e7fff4ca-395d8bd3057mr66188811fa.4.1779805784717; Tue, 26 May 2026 07:29:44 -0700 (PDT) Date: Tue, 26 May 2026 14:29:42 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFauFWoC/3XMSw7CIBSF4a00dywGUCg6ch+mMS2v3sSWBhpi0 7B3sXOH/0nOt0OyEW2Ce7NDtBkThrkGPzWgx372lqCpDZxySQUTxIW4ottey6QoGQRve0a1uhk K9bJE6/BzcM+u9ohpDXE79Mx+6x8oM0IJV/LCVOukuQ4PH4J/27MOE3SllC9AxICIqQAAAA== X-Change-Id: 20260515-fortify_pm80-b527a10c89d0 X-Developer-Key: i=rnj@google.com; a=ed25519; pk=QwUkB1OONd7dk9zV4pLRQRehoWHHsLcRZD2QcswqHTc= X-Developer-Signature: v=1; a=ed25519-sha256; t=1779805783; l=1362; i=rnj@google.com; s=20260515; h=from:subject:message-id; bh=t8iULvrUFjdfHnddacmqp3ZwHRl8owAMguuh6bqpWXw=; b=60heXesYHrd0tjquVnZnz6fuW08YKkDYOOgSc5mRXSZIBEe4SgxTIm8iTdnKCHDLgCZ/V6kbv vkDzOXIj5cgD5VdyrjMj9M6vYmTQ3LWqXPbP/gRyGwJ+8o9EcWgCv/Q X-Mailer: b4 0.14.3 Message-ID: <20260526-fortify_pm80-v2-0-359b743eb97a@google.com> Subject: [PATCH v2 0/2] scsi: pm8001: Fix struct layout and FORTIFY_SOURCE crash From: Ronja Meyer To: Jack Wang , "James E.J. Bottomley" , "Martin K. Petersen" , Tom Peng , Kevin Ao , Lindar Liu , James Bottomley Cc: jack wang , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ronja Meyer , stable@vger.kernel.org, Igor Pylypiv Content-Type: text/plain; charset="utf-8" This patch series: - Fixes a crash when the driver is built with FORTIFY_SOURCE=y. - Aligns the struct layout of hw_event_resp to what the HBA believes it looks like. - Simplifies code previously required to work around the incorrect struct definition. Testing: - Verified I can still read from disks using the pm80xx driver. - I do not have pm8001 hardware available to verify against. Changes in v2: - Define sas_identify_frame_local via struct_group. - Move pm8001 phy_start_req _local change to patch 2. - Don't mess with whitespace unnecessarily. - Link to v1: https://lore.kernel.org/r/20260515-fortify_pm80-v1-0-2863187f6d4b@google.com Signed-off-by: Ronja Meyer --- Ronja Meyer (2): scsi: libsas: Define sas_identify_frame_local via struct_group scsi: pm8001: Match hw_event_resp to HBA data layout drivers/scsi/pm8001/pm8001_hwi.c | 6 +- drivers/scsi/pm8001/pm8001_hwi.h | 6 +- drivers/scsi/pm8001/pm80xx_hwi.c | 6 +- drivers/scsi/pm8001/pm80xx_hwi.h | 100 +-------------------------- include/scsi/sas.h | 144 ++++++++++++++++++++------------------- 5 files changed, 85 insertions(+), 177 deletions(-) --- base-commit: b71cb088b2e3427924a470fc43e7aedb8a40d2e3 change-id: 20260515-fortify_pm80-b527a10c89d0 Best regards, -- Ronja Meyer