From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 031043DDDDF for ; Tue, 26 May 2026 11:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779793916; cv=none; b=lyG/98H8oxRn7p7UlAGmgDAugApq7ohpok6XQXnAijsEtRPiw3yz2RfOkqpNOE/yQOH1UKIulQxjAZVWEkQCLsN6ThIYvEVJocHtJ10vB6UepgM/g/e2U8lu2Y5wJai7BI1nAfnqQONyt39Kiyfa6WwIyuHnvaOOJ5ItBBG+/bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779793916; c=relaxed/simple; bh=JPVQANRPzIydaU0WcpkAVORq1mGKEPTOEIUcCS0y0vU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g8bmXwwtAgKdVKamstBf+sJdKb9bhg1t17b0KFTBtUSnlc24K1khRan4svLpc2z5bpa4LAaLBRsnF9Mz8I1mWASEHBAn52vjRKji4nEUE2p62Qz62jafQ0DMxyGUkrSalgkkfXj1SYb9dVikO4EmGw3xBHkzGMx+pZBP/fDqPSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BhXad65q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BsUr20xZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BhXad65q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BsUr20xZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q5xlJT1604575 for ; Tue, 26 May 2026 11:11:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=GExpfkrACNf d8AgKb7pzoxx6CS0kiv0JrtZqZXX3hVQ=; b=BhXad65qnuPXa4pCQ3qTvcSghZV 6Ins+HEiNdbggsV1CBXqoSw21PEY8mu/L4CEXHVnYiGnujqPsa/gvuc5xXIjV8Fx UJT9UGh0VW94qVRrmUAGphoK9ndcAYH4hBUG0lEtauXjoSpDplQpu3llj+aMOQNu Im6Dyq7SKwTnZ0NMyJFRbXv4cVOGI/tB9hsCNFFK4q7XVGf5siYwf4opu218fUNA UjNuv88twTY3CnjhrBEbepNCX9afHh+KIo3KePKnc+d0ItD4X3q3ZvHczamGJ8lk MWhizXqWgJguYgsTGSepdbesPvDZoRBgYEHOzmZyZQMDbtsKD4swYh3SOGQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ed5v3s72y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 11:11:53 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-369166fe5e3so9278031a91.3 for ; Tue, 26 May 2026 04:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779793913; x=1780398713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GExpfkrACNfd8AgKb7pzoxx6CS0kiv0JrtZqZXX3hVQ=; b=BsUr20xZwouukmXYrwUkxey0euO3TOIfQaAFkpFWRNrIFi0CuGYDX4SRRhJcvCsSmg 9ZO5R+oVg8MY+XB6k8XHJsu2FsHLPlPIGbnfvXwdey5b3sqM6LF1PlIMLztSbO5ghm4T /4CwMHEgXTuhziT5/MrPilU550vpQ+djEAJfDFbm+EGpC6wsdI0U/b4D4sNQVNZgIZ0w pM+kiy84Y+K4aW0F4lHSd4vboMMUwYXityWUI6gZQHM9n5Jm30xgT2z28BpIOnCc05AU p6qOXYS4i2Nh+uKj6/AXanbJJRpGB+4Urh58hE2d+qJDUzKod+1LFgyBZn92cadbKUcq l0dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779793913; x=1780398713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GExpfkrACNfd8AgKb7pzoxx6CS0kiv0JrtZqZXX3hVQ=; b=H48KfQBIzum6ebqoaao4pe2LrJBjj0M9W9agjLLtjefIEUF1v7gZXJyTCMO54LMbxj DJ2nY0aC2dyyIomiZqboQisRLObPSCoWCAV2Qd2GLXNYAjq6ELiyf814eILSh8tJBNnt ohD+sn3VNkbVysIRIbNQaUDsQU/5sZ+yNFrt3VDpQUxwN+kfUQCqrJ9q+YXT44Z6wmHq GUvelxKTGrZv/DdrEcmBXr4bFy5SRC71MSyKBUXeuEznSsxqHVPK97FUJH4hPIcRouKc YpFJbL7uprW/dI7mqR7fe2mDhia8hP+HauqGN1olNoh/1+kPENBl3xDzTsA3dpOUu19V 3HHA== X-Forwarded-Encrypted: i=1; AFNElJ9gxN1AR6V+RqiixYrjDjbITtUAMHbDXOuYNiYvMG5z22JWuHKlJr7tM1XcQQtdz6tg7srcH7YEVh4qw/k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9XiHi8Tt2R3pPAJbc/1myv7ZcM1QRFTyHKEM2HVdDtIdMLG5i dyuvPCylBwTVcEqeCNm6alS+JRULXJymlIYteJckS78DqI4YNc6ay5eyB/ocxc4dfgV1L28OC7g 2tA6HO53hTduAIc8gpJJQK6OHMpgKs6qoz2V+B6c5/+AafIlvSCi10QB56E517VkNHPM= X-Gm-Gg: Acq92OEACV2HyslhFnbhk8fFxeSEz0kIXM7KYzrC1lVx3YN5IwQDCAKJnvN328Dh+oK lSLjQpFeNjIgllbrX0i1J7vMeJBm10gor4IOqp7683mgSpRLROag/AJImzV4W35drebQ3MwONNg Pq7qa8vuZ1TjZL0WGYqlJh86w5jwvsa/IdCGw/V0boT0pLEH2k1jdMI1O3CESE6oC6OUNbewWub PF+d0ThRtQEpgsyYlKagbGxHg4wCElUEOlojUeiCKBzZrZtkacAt1EZRs/W7/KWaqiEgmC8JoxY OyqgjqTy2g46ZbHZPkmSitDqCP6ucYk7M9FroJmkjDiE5bpDtmNboH0V4xGFXlX+CUfwtWLfiiU tPTl1IBeMwQ9Z3phxR2Kq2sRASSaOZFjskkCmXWn6Su4isc9+7q3Uo2koNTHjkosDMH/gztAvPz Fpv8uqv4y9UWVrLyKwiQ== X-Received: by 2002:a17:90b:3f4f:b0:368:1566:1ba5 with SMTP id 98e67ed59e1d1-36a6745c264mr18435941a91.7.1779793913028; Tue, 26 May 2026 04:11:53 -0700 (PDT) X-Received: by 2002:a17:90b:3f4f:b0:368:1566:1ba5 with SMTP id 98e67ed59e1d1-36a6745c264mr18435910a91.7.1779793912579; Tue, 26 May 2026 04:11:52 -0700 (PDT) Received: from QCOM-SocCW5bzXR.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a72c4ce6bsm12104253a91.11.2026.05.26.04.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 04:11:52 -0700 (PDT) From: Jianping Li To: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, abelvesa@kernel.org, jorge.ramirez@oss.qualcomm.com Cc: Jianping Li , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ekansh.gupta@oss.qualcomm.com, quic_chennak@quicinc.com, stable@kernel.org Subject: [PATCH v6 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing Date: Tue, 26 May 2026 19:11:22 +0800 Message-Id: <20260526111124.515-4-jianping.li@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260526111124.515-1-jianping.li@oss.qualcomm.com> References: <20260526111124.515-1-jianping.li@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA5NyBTYWx0ZWRfXw2gVuya3TXBE IemsCDDryvNEXuaw3kucVeFNXlg/Cz/3Q+M6EmQpXGbk1AClQkMC8Lew9g8yXzwBFafC7JhF65s q33/nwNmBeiSQBWNtpHLSsU7wwKyqrc57kiZa/iiSGh9iNrZ3JOfcQTtnJPHKQKU70KaauLAydV AgbSbXlW6+BB9hce6zNjFxmzbVFueIw/R3Z2dkW+OeUDxaZT5ltiZLEpZTGunsTYFzvZtlfr6li QnUphk4p6w3i2/Ays2KGyPhVXIr9HxtcmVeXSDEGFYiRSg/vvB9cEksyNur9zHI+Sb4HqhTCC5F hIRsQa+47P2Yx/P1fl9Bsti4YWjob5oQ/hfV8kREMMACp2c7wdw9Vty2gsLbgDKCkDf8pPs+Arc AMiNPdRfv4FHa+2CmxEUTv/xOpn7ncRnEQpx4nAUspcF4Psy5MHaCJjRpMHVr0vV4lNdW2c7ZDG uDRYZdRsvZMS8fM8PlQ== X-Authority-Analysis: v=2.4 cv=Zc4t8MVA c=1 sm=1 tr=0 ts=6a157ff9 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=cwMOb1EeFLyGxYfGK4oA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: xHB9tF0522gZ-wR7O1blRDWk9eLS0ps8 X-Proofpoint-GUID: xHB9tF0522gZ-wR7O1blRDWk9eLS0ps8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-26_02,2026-05-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260097 Audio PD static process creation assumes that a reserved-memory region is defined in DT and exposed via cctx->remote_heap. If reserved-memory is missing or incomplete, the driver may pass invalid address/size information to the DSP, leading to undefined behavior or crashes. Add explicit validation for remote_heap presence and size before sending the memory to DSP, and fail early if the configuration is invalid. Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") Cc: stable@kernel.org Signed-off-by: Jianping Li --- drivers/misc/fastrpc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a8a58f889d07..f46a8f53970d 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1354,6 +1354,13 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, } inbuf; u32 sc; + if (!fl->cctx->remote_heap || + !fl->cctx->remote_heap->dma_addr || + !fl->cctx->remote_heap->size) { + err = -ENOMEM; + dev_dbg(fl->sctx->dev, "remote heap memory region is not added\n"); + return err; + } args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS); if (!args) return -ENOMEM; -- 2.43.0