From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67A9F3DEFF5 for ; Tue, 26 May 2026 11:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779795447; cv=none; b=M77hvX19qTMPZ/RN8I+GbJKxeS73YL5OeISHPzxXayorY61fHbl+kez9C+hxNCoDjwiahgegUaB3H1n3dsKxdNt6vbvcoSMaYxgxq3ev+E51fn/uQAdwbfuuf9IWg5CebyB7LxF3HCA6y6yxwazVTjgEpmntXzqxpU4DyZCYiD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779795447; c=relaxed/simple; bh=sFwr926G2kZRY6EdIxnYvkB9SXokQ2O/b3RMZy4ayH8=; h=Message-ID:Date:From:To:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc: Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Cc:Subject:References:MIME-Version: Content-Type; b=isGooa4h0cCBXsf04qT5pgPRqeAnsKWKkxcR35tDug1NfxXwJPIj5bsI7bY7f1/FUPuHOKXZVlioyU8RgNVZLMlyxVH+2rPdAu6fzUFiFYBKkrTc0LrY7E6XGvtdtIXkSSRze9lONwxngnMyldp0JFCM8nhRDDV5dSH9qmktEZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=it9sysgm; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="it9sysgm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=FBbI84bIZ3XgIkk4RD6nwPQBjp6JKindKKOMk9s6xQ0=; b=it9sysgmcF6pSStN6LLxbBbMJ7 9aMBpWV51vWoqiWYxqZtfhjIBOvjKMhxV4WRZXs710RqamR1ImlqjoxcD3sGNL0EGpI9OFj5x4cGS zk+gR3zx6EzFL5je7QYqSFK+oIwzDwRFnI2Wy/o7dqHseBnkVEYbWdMZUCsrhxW3/gPTU+sQ3U6u0 eObaUMEU6HnXP2gxPtf2i/xxlzB6Xqwk9BT696I0paRkJzH0exNDGzgxcylTpBb+276zGNz81W4D1 SOCExAONb8+nV+SzpAd+3lD8u3p59F3ukMYwGOY9m9O/SUsz9dNedEaWXMSrcPdVd+cEbXw94DBHt YgJlxxaQ==; Received: from 2001-1c00-8d85-4b00-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:4b00:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRq5x-00000000zi5-2Sjw; Tue, 26 May 2026 11:37:13 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 0) id 09995300324; Tue, 26 May 2026 13:37:13 +0200 (CEST) Message-ID: <20260526113322.120970670@infradead.org> User-Agent: quilt/0.68 Date: Tue, 26 May 2026 13:16:10 +0200 From: Peter Zijlstra To: John Stultz , K Prateek Nayak Cc: Joel Fernandes , "Peter Zijlstra (Intel)" Cc: Qais Yousef Cc: Ingo Molnar Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Metin Kaya Cc: Xuewen Yan Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Suleiman Souhlal Cc: kuyo chang Cc: hupu Cc: linux-kernel@vger.kernel.org Cc: Mike Galbraith Subject: [PATCH 1/6] sched/proxy: Remove superfluous clear_task_blocked_in() References: <20260526111609.433880331@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Per the discussion here: https://lore.kernel.org/all/20260403112810.GG3738786@noisy.programming.kicks-ass.net/ The reason for this condition is that the signal condition in try_to_block_task() would set_task_blocked_in_waking(). However, it no longer does that, in fact, that path does clear_task_blocked_on(), rendering the clause under discussion moot. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 3 --- 1 file changed, 3 deletions(-) --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7132,9 +7132,6 @@ static void __sched notrace __schedule(i if (sched_proxy_exec()) { struct task_struct *prev_donor = rq->donor; - if (!prev_state && prev->blocked_on) - clear_task_blocked_on(prev, NULL); - rq_set_donor(rq, next); next->blocked_donor = NULL; if (unlikely(next->is_blocked && next->blocked_on)) {