From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADFAD409132 for ; Tue, 26 May 2026 14:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779807264; cv=none; b=BcVbSlHh9yrCgoFFfHb6QJ5djZEkPqior0NGj2Rqu0hc10tunBBKKA9HzUu7kDDD8w3N8EZ8g7cqmVJg/dUNPoJD9cuPqdRtbD5e9ry6pJHQLIVhVHBdP3lbgLISXP4hraM33Fwpzs21v/ECf3tB5A3rv49RW3sy3Y8HKxVimp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779807264; c=relaxed/simple; bh=J21gY2Oa0Lq/I3m/376HfnUTl1mHOuBcWrkSSc/IPj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ab3+B1X8MoruieSu9X8XyyiyPUGUfGMwy1PV+rlOiYqb4BWqMkEygelFRvSwKHi8HSO2ZwbAdG4hINGwUec+/BLyFs72YUvsAMy1Lz/bpY/mrp5cWblzimZbFRejXy8keO3eb414WMO5CR0AwnFyCImv9ffqHdYO17uXN6L3HVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gtRwLKhT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YTdwnPnY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gtRwLKhT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YTdwnPnY" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64QEYB204030409 for ; Tue, 26 May 2026 14:54:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ScHhidnB094 qXmqcj2I9GQS4JCvqHfks8d61PZbHe84=; b=gtRwLKhT2ZLfch1ZgVmlohpAHYX FRO6WIGAwS4ZvAvcwX7ATl523xxkF4JiGQ1N5giwvT9zOIK3goavJ+Nb1KL2g+h8 +BHrMaS0SVeUots/M87SETJiC/wQ/avpqk3HGhpcT3HunVkUQYFynHF/MMwE1MaF nmTgTfjyMSmBPOpFZLAQLPHQi+nLcR5bFRmqSWO/lGnz5OHNNMpL/1/8Mj6Xxf49 1rIW1HM23bJRMiThZ2AXhOY1psiPhMRDRk5+sp8Q7nNxTBt3aWbmpL1EaY/U4SfU bes92XpOUGB/46IY67IK0ikLS4+/aCkE4MbM6cyiMoacBKtFq0Dk2wRFehg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eddd7r3at-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 14:54:20 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ba6fe41283so114779895ad.1 for ; Tue, 26 May 2026 07:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779807260; x=1780412060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ScHhidnB094qXmqcj2I9GQS4JCvqHfks8d61PZbHe84=; b=YTdwnPnYwpmbIt5hmNqJFghp6W5zqxhulscPVuzHwmU9ocqbkWqOziZjzoFlY+v0XA K0A+8rGax7alx+iMYe0LfLiw7JbkP8rBUnrJeaS2MVitghEzv4TRFF/Id0+dyiyVgfnd JD2V886p10UYX5DW7BJ51i/iRMLkJcMhNqyUdjsqWg5/66Tzu5nX6qyw0aal58iD/pop LF41SnI9pvm9rHZp/oX30f46Q0g51r9J2SmQgC1nG/k2N8lE5J4MSXtl8CxMgQSPB1tR 5NsyeTrMp3L0fdEwjiLwKgTrB9uHhPvCYbv4+cncgoVMmy/yLHvBk9edX5+HdvAtWsX9 /FEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779807260; x=1780412060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ScHhidnB094qXmqcj2I9GQS4JCvqHfks8d61PZbHe84=; b=tEdMnoHGG6jNzqv9a2arpMVTPUjNL7uMwFk2GWdybD+PHKk5COcFCkoyuBdT9O191k Jz145IjXxvAAD7UcCH2NfByrCdY7lSaH/FHIf/6lHai17SGXcCMrx5kp43JFux0UbenA IX0L4k9NqvdwSFrwmPkQ8rDd08qNbzb1cdZOxR+Lj6PMZxTMAN9OXGH3omatM6Eb0L90 niRADACwaGpuyECJ/4TydGREsAtyAS/6TJUzcD92Zux9GLMUTQpe2X4sPLnRNdMMP33I hieKKPkY50qG7MQbT/wZY9UftHh7PIMXw4bE8OC7g8vjEQbGM6VZC6q+pTzZQKJguRY7 UUjA== X-Forwarded-Encrypted: i=1; AFNElJ+BX6PCu9Bwa+wMLxQdr4JgBPsRVDTUlWKadjEgsF2OwkQRlgtRbL+uWmOpvW8g4+vfxQBow19sk2LDa4c=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa19dU0b6+J0RGCz3NQECrbqywYNivReWxXw2BJ0INkROxt4QV jAGZRRXcIaYujd+6w8UXo60zKM3cGOLv/T+fPfdwwMaxOqZ3ppbCjpm4HgnQDvF3wNv7rVAZJtp xY16l3oNfGyplF2xIRok17LZqpAVPDGHpsZ2JpQdUcXXqf2E7itbB9YjoWck8FGpS6L8= X-Gm-Gg: Acq92OGnbHnx/Ak2sUqS2Ers771syLPFFTw2mn/InMCvpZPCYoshbPM87hv7RhxHmQI gc/7bbNa0ZMPg11YfZr4aIfcjKjQxckdCEyOeMpDJ7BWQO56EvE2xITXZhtm9vNvCoxxmLtTgRL ZUHXuF2UZeDYecqVwS9VBVQQi/SnF7y4Z/+hE2X0Rvx6LMSRKiDE5MdGYwPRpmTDU6gMkj3TApe uq6gCu4qMYdkW/OezeTHOrYrU3cbc2WZy/nVvofN2NNeE0k0G+fQzEQ3cgVq66ya3n5MDmP/a51 3ZrHnMP9BIPoPVK7MBgDf5o8VLfOEGLyG+gy4xhzSmOQSXxcI3VXJGlM+jTEkdPEqK8Vs9nAsJD DuJGjByMEC7nJ/vDxWLtoJb9EVJe9xh5U X-Received: by 2002:a17:903:3c28:b0:2bd:3c1a:473e with SMTP id d9443c01a7336-2beb038b83amr207706675ad.14.1779807260024; Tue, 26 May 2026 07:54:20 -0700 (PDT) X-Received: by 2002:a17:903:3c28:b0:2bd:3c1a:473e with SMTP id d9443c01a7336-2beb038b83amr207706305ad.14.1779807259554; Tue, 26 May 2026 07:54:19 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58b387dsm130855465ad.50.2026.05.26.07.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 07:54:19 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Anna Maniscalco , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v10 12/16] drm/msm/a8xx: Add perfcntr flush sequence Date: Tue, 26 May 2026 07:50:46 -0700 Message-ID: <20260526145137.160554-13-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260526145137.160554-1-robin.clark@oss.qualcomm.com> References: <20260526145137.160554-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDEyNyBTYWx0ZWRfXxnjtKAmwhpau 29touoZXLYejy3vKxx3L2frsYnSQYEL2ZSxICEPWI0IW9Squb7Z6Cj1YvXi5kkcf2DIKHG1BdDe VwnAwH5hqd/HHWnUSGGCtewlMu3EIdSwavEvkp5EZ3MN4xnciqmv733Ek7Pv3MgVkWAOkHldUxR Ag1LuuRu0S02pP8uo7auO95mgq+QxFSb4UYWa5iJDJe2bku4v+Pb7ACa4YZiQHsbv/YEvqIj0ji PuEbP60RFdNCH3M4LEOiauc8/4rv/8P97RiX5NctlLzi9hJvsDtrOVc9CuM2OJKlc2oRH7d/Oit gqPeXjnTLJjolfr3THdXTi8l9WXNEh7MT8KWueYH67nGuoNocKD7/3+7M15l92RBQS0tgxyemv0 EuRs0VIiSknjBRHnNJ0FjHPMBl/5ZzNYkDV2IaVTUILXcndq/TnpSFZntxgup/H8azEZxVSsKfW m+aGecaTHofPDVib4yg== X-Proofpoint-GUID: r7nc8Q-CDxz1ADdyK0nLm_20KMBbgc_R X-Authority-Analysis: v=2.4 cv=fKsJG5ae c=1 sm=1 tr=0 ts=6a15b41c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=W-43u8CF5Pkpiqpb4b0A:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: r7nc8Q-CDxz1ADdyK0nLm_20KMBbgc_R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-26_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 clxscore=1015 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260127 With the slice architecture, we need to flush the slice and unslice counters to perf RAM before reading counters. Signed-off-by: Rob Clark Reviewed-by: Anna Maniscalco Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 30df9bfa9ef8..a329d20033d7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2921,6 +2921,7 @@ const struct adreno_gpu_funcs a8xx_gpu_funcs = { .progress = a8xx_progress, .sysprof_setup = a6xx_gmu_sysprof_setup, .perfcntr_configure = a6xx_perfcntr_configure, + .perfcntr_flush = a8xx_perfcntr_flush, }, .init = a6xx_gpu_init, .get_timestamp = a8xx_gmu_get_timestamp, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index 99c3e55f5ca8..3491a24a9320 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h @@ -334,5 +334,6 @@ void a8xx_preempt_hw_init(struct msm_gpu *gpu); void a8xx_preempt_trigger(struct msm_gpu *gpu); void a8xx_preempt_irq(struct msm_gpu *gpu); bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring); +void a8xx_perfcntr_flush(struct msm_gpu *gpu); void a8xx_recover(struct msm_gpu *gpu); #endif /* __A6XX_GPU_H__ */ diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c index 124d315b2469..6c040f718176 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -1345,3 +1345,23 @@ bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring) { return true; } + +void a8xx_perfcntr_flush(struct msm_gpu *gpu) +{ + u32 val; + + /* + * Flush delta counters (both perf counters and pipe stats) present in + * RBBM_S and RBBM_US to perf RAM logic to get the latest data. + */ + gpu_write(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + gpu_write(gpu, REG_A8XX_RBBM_SLICE_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + + /* Ensure all writes are posted before polling status register */ + wmb(); + + if (gpu_poll_timeout(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_STATUS, val, + val & BIT(0), 100, 100 * 1000)) { + dev_err(&gpu->pdev->dev, "Perfcounter flush timed out: status=0x%08x\n", val); + } +} -- 2.54.0