From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8B4B405C4B for ; Tue, 26 May 2026 14:53:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779807241; cv=none; b=hJM1zSh+X7c4Jn4w01n7AokIN0VFwm+htMQ0PB4XuHqJMxDx5wBrpWJoclImg5DkHybnun3CWf3mXBq09cr1bFqKfGM5NcLuunEqaUs3jx6QKSAIdqAu+BG5LusSCRSGCI3YKWnB11Pk36DbO4k2Fpca8d0pALa2SlsTANGZs9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779807241; c=relaxed/simple; bh=8VWbdGkuGsTTTwEXrzMET+OwRMV8Bxyp9scuxw0paE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P3DvD6uj2or7yc6qWf7GoPV4VKcmBm+4JdHIvXJfnz0B846H9t8qo+i68dyOrQ2DN9NuKswyQ2a9Ycw9NJV+XjAVWXTLZ7sGa57cV65AK/5c/DUKrTAJT0hpl+Mx3+4ISJlnziqJxQ89EqMOar2khL7r/QAtuWUbwKEJQH8YvIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oCEl6biR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LEUxFiWh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oCEl6biR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LEUxFiWh" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64QDhwVK2528529 for ; Tue, 26 May 2026 14:53:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=uZWxbq16V5d ge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=oCEl6biRCeCTYulMumpMNwJUeIp pX3rblOuDvA723Y4LkqWTwAD2ycnETTh/Fvn6zJNwLGwtcAIPMLPcMJ/9XTcN5e4 waXkdXj1VqQBL1YmYCXzvRC9bAx9VuRfKN/SGXVwNdWkQtchG+5HkRPf0Eu/LsNU OE6mVXlAbp+2PXFCGBM1KwrmhMPNnb7gLp9Xv1gQAFxP/Y1OJp8KXeWsJVkEQoy3 HIohgZBSqzfPbQlJAThBE9xQB575PyJj7dvfchesMtTew4w9yTQcAs7gFAgtnIFh f6tPtpBpaAURMoRwJL9KFoq787jVBq8QdZEEdaXwEpwBTTD6LNv9EfxvWNQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4edcnnrafx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 14:53:57 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b4530a90fdso42549485ad.1 for ; Tue, 26 May 2026 07:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779807237; x=1780412037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uZWxbq16V5dge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=LEUxFiWhoO3DmNG5Q+4fH7Au4PnMoCTCqQWTsrGMCSMTf5W1xPfI9XuHXIsMv0I9tK Df0FNoJYU5W69TcfIdbomgZapTzEJbeToAfn/tywhwKRDbxUas8zE288tcvwxQb26A/b l+QCyFrkOpp7KkKzMOxUUEF5eQptp/BmfAgrKhxIgDWRhU+lDG6KSIWBcrn/kjuCQ8pf UbOusDrdIHscnRAD0ftAWnaUPTKrNxAytP4sNWtuxZEnnCr2CYwomNYAvzR/PbuE9gVx ThFOk8GqzGNPLfz9hBVN8oUNLfZo+3Oa3cdCucBcShbyDf9xEypdjcYJZwCk6c26m/Mg azWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779807237; x=1780412037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uZWxbq16V5dge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=gZusCz5SObM7bbADS6JrBa/YbOgTl+NaOk3KSa5YqO9ccLeLk/4+OfdwTnnI3QVjr0 02U8loOxuA4AH2UbD2mjXbaglGqIWWshZ5sdTu2kPfoFgW86nZyfNzXk0rMJ6s7KHeYQ XZWcBLsoy8gQue/7bwAlTTXOmlydo0vIefpShoOgWAEDBDUK41j8uTmz3J52uBVA4eD9 yB3dn8qzAu1hGNkbF6ndyDE7h+lepFuDi4lgYYOe0J9dA04OYGJepQMtPKWOdzuqltqc BJm9tkGrxLXHngfHfF+KitD0Wl3mtg+D8b64ykRTFqzX29tBcRVBC6EYVt+L6WWsYmTh Wreg== X-Forwarded-Encrypted: i=1; AFNElJ+HHm7Hee2zApr/d7dVxpHxdI+rpqCpU4vyDDgUJT8DeSieILPukfDOHArf8wPJjn4ZTfcBJcmkQn3XPaI=@vger.kernel.org X-Gm-Message-State: AOJu0YzgLCQkV7N0pA9cYX+4imQSluyawZd8lVsvWsfQ/+omkGatb4ZB NS46KSlbA+2NtkUrbZRR3ACs0NsjCuWSjDwtYyci5vJ4pwH1JlHj1WN0NNVV2Tz3jhFobz4FdBJ X7ffHB+sQem+nfYF63vZlSq4G3j3tCTZfnbmZqmdd0b0q3ey6ytJhxm4gW967Hp8DLz4= X-Gm-Gg: Acq92OGbViBeVNgMpJ4GGSePANfABQZ39nUorp4NWX9jCsq+fTWJjBAvFPZw4opl8z1 qmw5y8zcwpl11d74mycIO0bkqLQPJYOCr+jG7OU4fnBEnRhIZxdcgcS8qQsA9PlQEQEnDZdOMAC Bt8a9x6gdiArvnfviMisYRj3j/J1KzXgPx9T/aBy7tCDAe5PHESsaaKGQqlz6o6U7mAYH9i2nVY V2LOroa9Lv10xCR+/Xv4m9aOJsQaepC50/gcyvFz/ge420UgpB/L29QcQbtMXHXmvfYuGpy8mfU L2j+6ZslAmr/yBDHCZs4bDy8x3b+CeOR1OKIhiSPrTAcXMvQMHlywJYWYy3p4wtbJVT4JE4/1W5 JCVkAQU09Q+wqRdMl3vzwHra+YDvhk92+qWqj6230TnE= X-Received: by 2002:a17:902:ebc2:b0:2ba:6ffa:bde0 with SMTP id d9443c01a7336-2beb065b797mr204911245ad.19.1779807237030; Tue, 26 May 2026 07:53:57 -0700 (PDT) X-Received: by 2002:a17:902:ebc2:b0:2ba:6ffa:bde0 with SMTP id d9443c01a7336-2beb065b797mr204911065ad.19.1779807236553; Tue, 26 May 2026 07:53:56 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56c4f8fsm126715195ad.26.2026.05.26.07.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 07:53:56 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Anna Maniscalco , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v10 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Tue, 26 May 2026 07:50:36 -0700 Message-ID: <20260526145137.160554-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260526145137.160554-1-robin.clark@oss.qualcomm.com> References: <20260526145137.160554-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Y8HaVX5bjdnxHOoM8DTUsPHsNrqRL6vx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDEyNyBTYWx0ZWRfX0qdq/cXtZWb5 VneLD4R9DGiEXN1klc+pZRqybu5Py3lk5LaU2tcOPX6PTBDUddLLglgVZHCHuqcFDwvFfWywXzL fCpsq8Q+wUY0e+oVua8jVxe9GCLMBdwuy0csiFsGXqYHxeaI2bRFPg1tUKFRy8xl9staX3LNTBj +Yk6Q3ht0TkFiV7BO+nSvkylT5owPbYqWmAykmBB88lDrDDPVUOIqN6UqL4XOyaRwPiC5eFSvr0 1auVoWRyFISSmYgMqYt/5h8fr6ilZEvWamSdlYnAsRS1roMgOARTO9Mr/dp2067ALOwjrqThruN p+YH074UQZjfTsrN14NR6iNZw6EAaO7IzM4CMxl3vVeBU/oJPi+gs8Jx3KTA+W6pKHSXtcXdtwF IF30D2MSFaWdPHJWKopQan+Rdq+a6EC1RroDc3S0CYzNyq8rONj0LVZAte3STGa3vZ4aa3Snjsq DrAQGPNwJr5QvSqX9Cw== X-Authority-Analysis: v=2.4 cv=VPHtWdPX c=1 sm=1 tr=0 ts=6a15b405 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=RIk3oTIWcAeXYnX0VHsA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: Y8HaVX5bjdnxHOoM8DTUsPHsNrqRL6vx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-26_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260127 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Anna Maniscalco Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0