From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9606630C610 for ; Tue, 26 May 2026 15:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779808792; cv=none; b=elxw+mLZjy+LoQu2miSY+p2qiA1jAMdk8a3uKL0WKCWFDxlqmpVTYNlfRggOr5PyJmWhGPdSN5WhJ/sUUtHrFU7AMBspVeOkeZ5H2+JFG+JwqXg7fTKX8Wykrjo4SJyZPL/evszr/qjsh2lnmHdp1EQm7CJ2kdF5V/eqpdSLDKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779808792; c=relaxed/simple; bh=Lnu2EVY7kGgMFYCr5nzfpDHkYvIQQ8dedbk4JRz62MQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uJKzeD7NHllk5+ifRXkp37belMJtaoU7qi3SCtIkXtxOZ69LaMCAEhqa5ke+YTeyua2drcm7unNGD6cFo5BW03+hjGFoFBIOPhNHQCtDFO4TlI4W7+vI+JgM1Jd8fbeuk53Y3f+lH5EetZ8b0d+mzFcSY4Rcgzhf1kLTw7g5iOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fjzpQh3b; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fjzpQh3b" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-49045243094so62019535e9.2 for ; Tue, 26 May 2026 08:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779808789; x=1780413589; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=UUC6GCpgb9EEQ0qn5/HP42C7vK2niyP/8gA1+StmENE=; b=fjzpQh3bkhaJx7nMiz2/sIeLo6jh2npa34MazVt9T+tH/p8Nbrhd2C1n3H+OSpLoXq 12o2d4LQZFulw/TPoq1gZbc3K/uJ3LLGfxS06LVqM56cQq+YMxk8mDkj+Qx+UHhPK4gi XzHg/gRusVjLkWVQ46TvOXyNzF4S7mbGZKckS4RexIPgwN988BDP7IvSuFn3dER2uCVt bikr/TiOdS4Jcux5B7FawRDVqzkgwVg3CPug9B6rPR74eEKJGwcPdvE1KnBq3xNUT3CJ FKfspiMuK0ZX2w3rwm1UofPHtn+6wTqZxtF2Wg3b6xRUWTfrMKx3iZjGWwpOaEJIWzbu YfsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779808789; x=1780413589; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UUC6GCpgb9EEQ0qn5/HP42C7vK2niyP/8gA1+StmENE=; b=Fnng+GfhwYnhBkxJidK6qyQY/71cWTs9S9BnCAzWSPd82mHbWQlgocYTEf6dvwy4AL oBzRmQH2sz3Gv5HNCXWNhgBKqX33aZKfTkXqa35AHu2/lYFIMusdYN9nYlsfVmPZWTxP 6uYe4xJJCW/V9Cq9nhb13S+kqi4yZMPj87I6U/cjyNUF/j/2+CI8ysPwbXIeIS4aFNsx DCJbw+Qn1s/QgcikoF1nastQdis70kce+bN1k7DU3gu4RPFr1+Y4/FuCC0+aOjAjsEyz bq254VmZIcm+xeVhObsAFtGNZOAecHOjlrtBYrPRPaPUR6/sSt0GL6UDuxDF3j39i+3y aELA== X-Forwarded-Encrypted: i=1; AFNElJ+/bVajVyafy63X1wlVpy7ZsyvCEKHUBllY0gZOBdcxq7vO8YU1CMc8mOR4odXzkvM3gCjypoUwzxLDQgg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/4anBl1c80rRi6zxH3yRlgahk6vAOsGBn7xXre4Qztuds6CrO SZzWzgx/Oz1Jtf9O9YrwxkpcWGetKvHI8B7pgOmrBGKoMAWHFvGmf9hcqdKwOXxEZGyn3AV8BFX J9JjV0MePjN4KcA== X-Received: from wmgb20.prod.google.com ([2002:a05:600c:1514:b0:48f:de5b:469b]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3488:b0:490:6869:7d8b with SMTP id 5b1f17b1804b1-49068697e08mr140072435e9.15.1779808788818; Tue, 26 May 2026 08:19:48 -0700 (PDT) Date: Tue, 26 May 2026 15:19:31 +0000 In-Reply-To: <20260526151934.3783707-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260526151934.3783707-1-smostafa@google.com> X-Mailer: git-send-email 2.54.0.746.g67dd491aae-goog Message-ID: <20260526151934.3783707-4-smostafa@google.com> Subject: [PATCH v5 3/6] firmware: arm_ffa: Fix Endpoint Memory Access Descriptor offset calculation From: Mostafa Saleh To: op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, jens.wiklander@linaro.org, sumit.garg@kernel.org, sebastianene@google.com, vdonnefort@google.com, sudeep.holla@kernel.org, Mostafa Saleh Content-Type: text/plain; charset="UTF-8" From: Sebastian Ene Use the descriptor's `ep_mem_offset` to calculate the start of the endpoint memory access array and to comply with the FF-A spec instead of defaulting to `sizeof(struct ffa_mem_region)`. This requires moving `ffa_mem_region_additional_setup()` earlier in the setup flow. Also, add sanity checks to ensure the calculated descriptor offsets do not exceed `max_fragsize`. [@Mostafa Harden error checking] Signed-off-by: Sebastian Ene Reviewed-by: Sudeep Holla Signed-off-by: Mostafa Saleh --- drivers/firmware/arm_ffa/driver.c | 16 +++++++++++----- include/linux/arm_ffa.h | 2 +- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 059e2aae7ca0..bed4bd48963f 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -703,19 +703,26 @@ ffa_setup_and_transmit(u32 func_id, void *buffer, u32 max_fragsize, struct ffa_composite_mem_region *composite; struct ffa_mem_region_addr_range *constituents; struct ffa_mem_region_attributes *ep_mem_access; - u32 idx, frag_len, length, buf_sz = 0, num_entries = sg_nents(args->sg); + u32 idx, frag_len, length, buf_sz = 0, num_entries = sg_nents(args->sg), ep_offset; + u32 emad_size = ffa_emad_size_get(drv_info->version); mem_region->tag = args->tag; mem_region->flags = args->flags; mem_region->sender_id = drv_info->vm_id; mem_region->attributes = ffa_memory_attributes_get(func_id); + + ffa_mem_region_additional_setup(drv_info->version, mem_region); composite_offset = ffa_mem_desc_offset(buffer, args->nattrs, drv_info->version); + if (composite_offset + sizeof(*composite) > max_fragsize) + return -ENXIO; for (idx = 0; idx < args->nattrs; idx++) { - ep_mem_access = buffer + - ffa_mem_desc_offset(buffer, idx, drv_info->version); - memset(ep_mem_access, 0, ffa_emad_size_get(drv_info->version)); + ep_offset = ffa_mem_desc_offset(buffer, idx, drv_info->version); + if (ep_offset + emad_size > max_fragsize) + return -ENXIO; + ep_mem_access = buffer + ep_offset; + memset(ep_mem_access, 0, emad_size); ep_mem_access->receiver = args->attrs[idx].receiver; ep_mem_access->attrs = args->attrs[idx].attrs; ep_mem_access->composite_off = composite_offset; @@ -725,7 +732,6 @@ ffa_setup_and_transmit(u32 func_id, void *buffer, u32 max_fragsize, } mem_region->handle = 0; mem_region->ep_count = args->nattrs; - ffa_mem_region_additional_setup(drv_info->version, mem_region); composite = buffer + composite_offset; composite->total_pg_cnt = ffa_get_num_pages_sg(args->sg); diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h index 81e603839c4a..62d67dae8b70 100644 --- a/include/linux/arm_ffa.h +++ b/include/linux/arm_ffa.h @@ -445,7 +445,7 @@ ffa_mem_desc_offset(struct ffa_mem_region *buf, int count, u32 ffa_version) if (!FFA_MEM_REGION_HAS_EP_MEM_OFFSET(ffa_version)) offset += offsetof(struct ffa_mem_region, ep_mem_offset); else - offset += sizeof(struct ffa_mem_region); + offset += buf->ep_mem_offset; return offset; } -- 2.54.0.746.g67dd491aae-goog