From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A58E366542; Tue, 26 May 2026 16:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779811659; cv=none; b=qBVxWYYV0WSAAcVE7kdfQTjPyuIlKZDXWkvFc1lNFPSdytBbMJuP+4EU599iC/VdoF+mgIzYhE5u1nfw0zhue4auBu5KC2BWmd+/L8Y87AGSXpZtkGfjX+ZrWdugWpRdSpVAnFvP5t1qb/QQ9Bs2tDY7NndbRIshbX7ETwK/884= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779811659; c=relaxed/simple; bh=kb154U3+DNAckJiQFLM0klBHRdbqCz70jsGUNm6c/4E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kpe9dcoBqx9g89TPxygpN42u1OjuSzck/pDJfqbYhk3IbeNrHCjVpwFh37GLPLIS0uk8d/ayM/RE+UXJO8TPxGR0qPzAHyX6ovCFNThmPb7tkHuEW24PVWMe+JtIfb7eeyFOUx2G+P3j8xa8OKcO2oGq8iJH1qaZb/6mipI8sX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ER3Oz2zy; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ER3Oz2zy" Received: from killaraus.ideasonboard.com (unknown [146.0.28.163]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C9760244; Tue, 26 May 2026 18:07:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1779811636; bh=kb154U3+DNAckJiQFLM0klBHRdbqCz70jsGUNm6c/4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ER3Oz2zyqbb7hy6Ghc92nNMoizfTW/4npZP18Z5Mi9g8figadeln3y8KkaalgDwxw WvrVjwGpaMwMAt5Kgl2MRZ09TNXSoGXAPmztl+2KNHuM4k7jqye1RQ0PpI+qVA3agC i4TFeIju6J0czEh6q7PfgjqTcNbhzrbVOMAtnGD4= Date: Tue, 26 May 2026 18:07:33 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: Niklas =?utf-8?Q?S=C3=B6derlund?= , Jai Luthra , Mauro Carvalho Chehab , Geert Uytterhoeven , Magnus Damm , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi Subject: Re: [PATCH] media: rcar-vin: Drop min_queued_buffers Message-ID: <20260526160733.GA422575@killaraus.ideasonboard.com> References: <20260504-rcar-vin-min-queued-buffs-v1-1-59d20ad5cd2d@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260504-rcar-vin-min-queued-buffs-v1-1-59d20ad5cd2d@ideasonboard.com> Hi Jacopo, Thank you for the patch. On Mon, May 04, 2026 at 02:43:14PM +0200, Jacopo Mondi wrote: > From: Jacopo Mondi > > The R-Car VIN driver already uses a scratch buffer to sustain capture > operations in absence of a frame buffer provided by userspace. > > There is no reason to require 4 buffers queued at all times for the > driver to operate. Drop min_queued_buffers from the VIN driver to allow > single-frame capture operations. > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > This allows to capture a single frame when the R-Car VIN is used > to feed the R-Car ISP on R-Car V4H. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c > index f9af9177e02f..73cda0e2d45a 100644 > --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c > +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c > @@ -1494,7 +1494,6 @@ int rvin_dma_register(struct rvin_dev *vin, int irq) > q->ops = &rvin_qops; > q->mem_ops = &vb2_dma_contig_memops; > q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > - q->min_queued_buffers = 4; > q->dev = vin->dev; > > ret = vb2_queue_init(q); > > --- > base-commit: d9c8c4adf23d17549c0ec9c85b99d85a0ee6cf18 > change-id: 20260504-rcar-vin-min-queued-buffs-31891f226fe6 -- Regards, Laurent Pinchart