Re: [PATCH v7 0/8] Fixes and cleanups for the AD5686 IIO driver

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 24 May 2026 11:17:00 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:

> This is the first series of three on updating the AD5686 driver.
> 
> A bigger patch series was sent before ("Extend device support for AD5686 driver"):
> 
> https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com
> 
> This one adds a number of cleanups and fixes, like:
> - Refactor include headers (IWYU);
> - Remove redundant register definition;
> - Drop enum chip id in favor of per-device chip_info structs;
> - Fix internal voltage reference control for single-channel devices;
> - Acquire lock when doing power down control;
> - Fix powerdown control for dual-channel devices;
> 
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
Series looks good to me but I think we are waiting on the fixes to be available
upstream - so might be a little while before I can apply it.

Thanks,

Jonathan

> ---
> Changes in v7:
> - Drop fixes (already accepted).
> - Use named fields in device tables.
> - Link to v6: https://lore.kernel.org/r/20260505-ad5686-fixes-v6-0-c2d5f7be32be@analog.com
> 
> Changes in v6:
> - Protect powerdown masks on read access too.
> - Minor changes to power down handling and constants.
> - Link to v5: https://lore.kernel.org/r/20260501-ad5686-fixes-v5-0-0b2f45488418@analog.com
> 
> Changes in v5:
> - Drop I2C read operation changes.
> - Create helpers for reading and writing powerdown mask bits
> - Link to v4: https://lore.kernel.org/r/20260429-ad5686-fixes-v4-0-bb8f1cbd68e1@analog.com
> 
> Changes in v4:
> - Address issues spotted by sashiko.
> - Link to v3: https://lore.kernel.org/r/20260428-ad5686-fixes-v3-0-9cff7bd67a15@analog.com
> 
> Changes in v3:
> - Misc changes like parenthesis removal and line breaks
> - Link to v2: https://lore.kernel.org/r/20260427-ad5686-fixes-v2-0-188e05199368@analog.com
> 
> Changes in v2:
> - Bring fixes first and cleanups later
> - Link to v1: https://lore.kernel.org/r/20260426-ad5686-fixes-v1-0-7c946a77794e@analog.com
> 
> ---
> Rodrigo Alencar (8):
>       iio: dac: ad5686: refactor include headers
>       iio: dac: ad5686: remove redundant register definition
>       iio: dac: ad5686: drop enum id
>       iio: dac: ad5686: add of_match table to the spi driver
>       iio: dac: ad5686: add helpers to handle powerdown masks
>       iio: dac: ad5686: add control_sync() for single-channel devices
>       iio: dac: ad5686: cleanup doc header of local structs
>       iio: dac: ad5686: create bus ops struct
> 
>  drivers/iio/dac/ad5686-spi.c |  73 ++++--
>  drivers/iio/dac/ad5686.c     | 528 +++++++++++++++++++++----------------------
>  drivers/iio/dac/ad5686.h     | 133 +++++------
>  drivers/iio/dac/ad5696-i2c.c |  80 ++++---
>  4 files changed, 418 insertions(+), 396 deletions(-)
> ---
> base-commit: bbc109ae655c8a5d4db117fea01947eb6bf51e71
> change-id: 20260426-ad5686-fixes-63ea68811bdb
> 
> Best regards,