From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC05436D9FA for ; Wed, 27 May 2026 20:10:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779912615; cv=none; b=Lf3EftSKquRrVGuZZ89mMgcfNMb1t10wvfhR9XxMHpfrJMF44M7I3SvyPEyssSrbTpiRBcL1ZRic6odHAQ6Qi+jzdphMV0gY0UrFajO9jMDNaxHm/CNQf74g39ywU1CJzjmK5vtZnOEamLvo9tjpogQtw3jW/vud190qnvFzql0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779912615; c=relaxed/simple; bh=BXyygT6KooIkATSpczru2FP9H3alp+SSLbQ+JG4TMVk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=dn3NmrqfF05W0K0df+AQ+fNDRF4dzs52zC9fwTZU8k0X0gyST8oQ8v14yXARMaZEqGWZDCZn5emtf1GQomB84SXFOkbBDCp5dC48I4f3SqQixRWwvT9PXUmRL07+ZKT4L/eUiZ6MTn5TbyHNuQWQTNVLgvgEBLUPZY7bYLA24C0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wkennington.com; spf=none smtp.mailfrom=wkennington.com; dkim=pass (2048-bit key) header.d=wkennington-com.20251104.gappssmtp.com header.i=@wkennington-com.20251104.gappssmtp.com header.b=pQ/ysguT; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wkennington.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=wkennington.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wkennington-com.20251104.gappssmtp.com header.i=@wkennington-com.20251104.gappssmtp.com header.b="pQ/ysguT" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36aa4ae1f11so2605677a91.1 for ; Wed, 27 May 2026 13:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wkennington-com.20251104.gappssmtp.com; s=20251104; t=1779912613; x=1780517413; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=oZMqsGGe14qMX5APGY1G/LDeh08IMnWvkF2G7ulrX1w=; b=pQ/ysguTBgRnIfyZrUSBVFnS0icjuxIORH1+G7Ro7tWWYFAUV2RpX8+8GKE+YQ6ga4 Ys3/eWjWNGLs5RSkPt/MLyn3zM5DUC+qr3shVlLcwnK11kuor00WvJA2k1kHuDqKEZ7P FJd1PToZPJEJYqDr7RYhTJRVST8GgMJkdM/31cTQQV4jFHavBXBIKRHF0fe5ZBSnDypC /lDqZmlbTNopayZLrxGB+eenh9WP4c6E6Cmsggj5JmaXb79GKFa/9PRMYy756LaDeO01 85NSmgnGBop+ga0g6oFCA/JB4Y6Bj8J4WEKe49YWqTjHgd3qRTE3aOjgrdN/2BtFmJA/ HUGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779912613; x=1780517413; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oZMqsGGe14qMX5APGY1G/LDeh08IMnWvkF2G7ulrX1w=; b=DMeeIWBJXtCgQSaUCHrvJWrG/z1HIcQ6nIhqBS+GEiU0Osbnr8hXUfU9Tb9riXqSLG luYwDKQZrkAkil2t7MXu3beD4BYiM6riXI0wDkrz/z5JJBBWdiiVrlRWXpdrSY9ls2Zr Use2E2GAJoS7cCKYUEAq8PsY1ki1dO0AB3dOByOqMQeHaT9j7KumwqRlhULgOSm/rQZF vfADlAP/Eb85y/1/bvsTszM1QXSGdxZQx2YbPcGJzACehAIEB8zrlfXUOuu4MbIgCntl XyEmt/39lsUj0hTJtQgpskJeSa0kkp1ySmRFwTNVPk5Xn9z6/dRjHE0YzMJwMlwe+bq4 phZw== X-Forwarded-Encrypted: i=1; AFNElJ/K4yk3pXTLpsTYq59K7xp7/W5NDHMBSK65Xy3bmxvx4CLWJUbE326g1nJ4dh3XhKY9GliGIUq9L88lXR4=@vger.kernel.org X-Gm-Message-State: AOJu0YxuH7zmv2zQhgdvQkkXyudKVpbYhmaw+BrDi7Dbw7B1rDM5nbaT 5PkphedckyP4aJ1+9TPjeyhFfhKRAtQfWPYs+Ugcs0MSRg3ws42ZQZlbYx+KVem2sBxBq7rB5DO Ki+t+kZM= X-Gm-Gg: Acq92OGnpO9SoyXEbdBhqlamjeCEEmULyMOa9//KJKZkBLxSLOwy/xztYX617ynEr3w rwEIYj1NIVJTNuThPLUeFmyzd+3wB+oPEVOYmrWdemlxlGQ/NnYSEqGXkRZpmvJRan30CvOVDpc hO5A09HTS3ePVkCdyAfJ+phog45w89G5yufmdk1ibzUKkzr1SUSF7GbUc4TSe+zSAF4O5VJpeYq aJ/tUvr2UyoTfeeoalpZr1fjZtmgWeET3Bo3GhJx1Zzj7ab3PkT4Oc3v0bDVVV6av0Pk2NFBBK9 DXKaqtHBxT60K2xuu9nepWXQSMMjgYpmYm3/ousfSFjYoxO5oUJ3l7JHwGT47WEgVJXhO3KEAOl O1GmFPic9P3uBihZGjzf3vt3QBS6nfunM0BxByrj4GA0muJSnKA8ltcGdIls2vAX6zW38XTLeb1 EqGHlpJGbkEfoIdhUJlasAprbwMfNPC1apNgJ64jSXQVj85zsiGRIvsR1RHAF0/sStE2A1RjvHw 5CkcxjAnY+wlV+Lp/G0cMg= X-Received: by 2002:a17:90b:33c1:b0:368:cefe:ddd0 with SMTP id 98e67ed59e1d1-36a6765aa6bmr21951985a91.15.1779912612799; Wed, 27 May 2026 13:10:12 -0700 (PDT) Received: from wakbuild.c.googlers.com (27.117.125.34.bc.googleusercontent.com. [34.125.117.27]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a71d9416csm21875253a91.3.2026.05.27.13.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 13:10:12 -0700 (PDT) From: "William A. Kennington III" Subject: [PATCH RESEND v5 0/4] i2c: designware: Improve device disable handling Date: Wed, 27 May 2026 20:09:48 +0000 Message-Id: <20260527-dw-i2c-v5-0-3483057f8d67@wkennington.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Mika Westerberg , Andy Shevchenko , Jan Dabros , Andi Shyti Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, "William A. Kennington III" X-Mailer: b4 0.14.3 When the I2C controller attempts a new transaction while the target controller is shutting down or restarting, it can lead to bus lockups and system bootloops if the hardware enters an inconsistent state. This patch series addresses this by ensuring that the internal state machines are properly cleared when disabling the controller if target activity is detected. Additionally, it adds a shutdown hook that gracefully sets the target disable bit before disabling the controller. This guarantees that any incoming requests from the controller are immediately NACKed during shutdown, preventing the bus from hanging. Signed-off-by: William A. Kennington III --- Changes in v5: - Fixed one last inclusive language mistake - Link to v4: https://lore.kernel.org/r/20260507-dw-i2c-v4-0-9a447b23bfdf@wkennington.com Changes in v4: - Updated language to use inclusive terms - Refactored some minor comment / code nits - Link to v3: https://lore.kernel.org/r/20260504-dw-i2c-v3-0-57e56135d602@wkennington.com Changes in v3: - Split the monolithic patch into 4 logical patches - Reverted stray formatting change in the PCI driver's dw_i2c_driver struct. Changes in v2: - Fix description footers - Fix emails --- William A. Kennington III (4): i2c: designware: Introduce shutdown exported function i2c: designware: Convert PCI driver to use shutdown hook i2c: designware: Convert platform driver to use shutdown hook i2c: designware: Handle active target cleanly drivers/i2c/busses/i2c-designware-common.c | 32 +++++++++++++++++++++++++++++ drivers/i2c/busses/i2c-designware-core.h | 1 + drivers/i2c/busses/i2c-designware-master.c | 31 +++++++++++++++++----------- drivers/i2c/busses/i2c-designware-pcidrv.c | 14 +++++++++++++ drivers/i2c/busses/i2c-designware-platdrv.c | 14 +++++++++++++ 5 files changed, 80 insertions(+), 12 deletions(-) --- base-commit: 5d6919055dec134de3c40167a490f33c74c12581 change-id: 20260504-dw-i2c-d5a1b1a0036a Best regards, -- William A. Kennington III