From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4398D383C7C for ; Wed, 27 May 2026 09:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779875680; cv=none; b=k0bih2RmQoYXmFepNxx0WGWvNpJx6e5jM1PkhdhihC5itV38rPv2jrnSE20P6FRXHIFF0nl51aWRlmn3G+WQPc893tDn8faS2I76rV2SZ4ngrJR3yjQARGz7NakzHTkKlXqgarcYvDZfrPbVpMlbxxsjVkXaBM7LNt930uzy74A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779875680; c=relaxed/simple; bh=mShQwabQxaZp3idjZ9qH8QOkK78f96MHaHF57YGQRlM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MNUMD6TrERJqHj5emaOivpB3VhcSefGtqxM9YckdORNwFMT2rdfR9XkgqLetRvRJqVt4gLyDq35awNWLgsHpdKLc2ig8NR0XA4MCksfqvzI/z2qaVDH0QqJ/Nfur0Zn0guhPEUSKSGilLc2jE3XIU3xejL8AAI9XaL/e5QClFP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c3SzGCGM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JfuL1egL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c3SzGCGM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JfuL1egL" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64R8mYMj1041506 for ; Wed, 27 May 2026 09:54:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=apwYLrYTuac I1nhRg64q6TDsz1KsgGXVT58v+eTvBlM=; b=c3SzGCGMSo+whHk35dHzP02uQR+ T5bafiGztbOPcy+mc/ESREB4R6Zu5940dixYYEnztTpuGGcK52u+4aR47WPnFpD9 ZVGvTbeUzi/Y4gyYjcKhg9rpbPcpeJ8XL/7h7Dib7auU0RMnGoW5XnV22WZK3m0z 7FFNThpod5yd6E9NRNmHeCQTR/y8FXKutCDh0VK31q4ODu8glhe5gkS/+gNBvJ+j Mnaz8cjALQ8ucUrCFHacMCOQI5QUGD44R+yGh/wZlTz5rYjL8ZlHgvu1rkWh8zdC fSFc7EOsChYCZjuxo598emfF5tOO9NDLDPyltzySV4S4N6wRXYTUdCy4E1g== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4edh17arx0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 27 May 2026 09:54:38 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c854c4b740cso817363a12.1 for ; Wed, 27 May 2026 02:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779875677; x=1780480477; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=apwYLrYTuacI1nhRg64q6TDsz1KsgGXVT58v+eTvBlM=; b=JfuL1egL4E0/vgtU3BFCHTi566rNABgihsdsrQrWfWasXIM43FkAxdt9sgaVC3XCpF ZpVdffCQRJpRQ6o+7CMCq0jE9gNOuArjWZrLcAMEfKueCuTBOVqQ9oBvaQJHUKYIUcqz WhMieR1h2az8DMUmFZJAYZML9aYweiqqCN2dCx/yjvMrcXzMnGJzZMJyg7kQxxJHm+lh CSLWgu9OtOJP6N6cAgJo6Lyag/JjYv5w8Zvfk2QThGAdLt4aK/xxWChkMHID191zMfSS 6gzjWrnpJY+Le/xTTBzOAHrRE5Uj+0TQ+E0IMgXQcAMnWu/aGT9Syisko16yoVdWIVqV p/Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779875677; x=1780480477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=apwYLrYTuacI1nhRg64q6TDsz1KsgGXVT58v+eTvBlM=; b=mRXshUwT1Swu2C2WhOjq5+soalL1vW94cgyNXXPMIAN0/8lUvxOeAjcFKHHzLVg052 y8/3KWpooq06NnO04FpVYh2X0auy7fX/gDo28mzs4d+J9xfW5wQ/nHwUziB+rLPVuXME Gc8jJ4EXUJs0KDMYhYwCh3L7QvkV0Q2tWinG6++nvLSpDrwkPFmUz23O+FF0SKvbVIq4 1oAhcrZbI0kGZDRF1tV1I/b2nzFakQjaAXIWaw5Q4pC+XUYf7sfCptyhmSAmRHv1cdDM ThUOWe4fIDCeQcBvNFegfgEvyL48b4+4fF+/aScvPpVBlu/u0Y+t5fRx5E/Xwmyt1yaw OgLw== X-Forwarded-Encrypted: i=1; AFNElJ9LuiWIDsttsjAXxtz9XtxQ/vpCan5vfAEZeW1sbTNbfaXdCYinVApCHfvw63OpavCmZa2KJqw+pSdyrVA=@vger.kernel.org X-Gm-Message-State: AOJu0YzVhjG/9KIaYYakF9G8nD77Z0DwNCGl2zwHiC9eDaQQv6GCN3Vf 5IrkZDWaGOHsiXAG8e6LmUm0kMoNgHTgb8M+BQj7s3vWd4LYOCGrRI+RCcdqw3RMAvOAX1nRM0W EAH3z4d3QcSb5W4NW5NVSlV2Qwgh8v3mHH1um1i7SEYBzznBQFB2xdsSwgBMCx/d7bOq89CbKx0 s= X-Gm-Gg: Acq92OGn/S7cv9C+XitqJbp/au2YU+FMMDYkLMSAn/B1swuhZ8Lfzj+ax/9Jc898Tv5 zqo5lhb3uKUjdAAkGcl5VUu1dyCimwYGYByuCZ/R98EvTi/5wEYSQomB1e2NFLEx8r1ysRmekM0 XI+yBcFdOZ5trnQypRaBEhyonijs8qBpm7kURXbiPeJaHo+nGN/m50F0djhO7TKh8UYztiK/06p THeCgrUxdBQfM8d8/AQ5fcP5K2swAqxoEoghGaB8HAckIqm7ON8n6R6uWsdv36jxFYo5Kv+RJk5 lPv/an7ikjt2ZufvjyyttL6kEMwdCtcHih8r0x5kogXnw7JiT/V5q+AS8pJpD+PzXq5zxJP6dIl Sr1NKKma2nxKo6sTN5AzQ5H6+ANf2KqCRLFGNQZI/dxJd8oO83uUYo+J++vk= X-Received: by 2002:a05:6a00:430d:b0:838:af72:fb1f with SMTP id d2e1a72fcca58-8415f0e43d6mr21472656b3a.2.1779875677045; Wed, 27 May 2026 02:54:37 -0700 (PDT) X-Received: by 2002:a05:6a00:430d:b0:838:af72:fb1f with SMTP id d2e1a72fcca58-8415f0e43d6mr21472623b3a.2.1779875676342; Wed, 27 May 2026 02:54:36 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d70f17cbsm1809325b3a.45.2026.05.27.02.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 02:54:36 -0700 (PDT) From: Mukesh Ojha To: Thomas Gleixner Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Dmitry Baryshkov Subject: [PATCH v2 2/4] irqchip/qcom-pdc: Tighten ioremap clamp to single DRV region size Date: Wed, 27 May 2026 15:24:24 +0530 Message-ID: <20260527095426.2324504-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260527095426.2324504-1-mukesh.ojha@oss.qualcomm.com> References: <20260527095426.2324504-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: GcoGVxAoi1bHZ4nu59XDNUolQLf3hWQz X-Proofpoint-GUID: GcoGVxAoi1bHZ4nu59XDNUolQLf3hWQz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI3MDA5NSBTYWx0ZWRfX2kgb0TdoEWqH Tpf21U3fy9z4fGn4F/9TM5sVXRcekap6ypwgdd7rlykvBDIu07YCF+JgVWoTn3+yqJ8g5S3NA9m w5SiveAZ+78+bUR3FbfPq53TOPGo3NsZ43J0eyjN4jl9p1k776gfyWPgV9n6n9jpqPYK6lOrihV cvmysThaMT+t0iGFVIg99oZ4cBNwheUGTgKirx1dFdHqWunZ+Yyp8k8RlOYAbzUuC4wDapj5j1z cLjFQsyq8E+ILQlv3pNIqVhOGed7b5SaytgcslQagpspGZ4m1N3aC7AKRXSDp1uMAB6pgcYpUK+ T797wvmTwLKDqvj1C2N8vXHiblrreJd7zNGRgkP7/dNNv0bfaMfa8YrvIoMsHmxUbIxQSiIS0O4 YEyLaKBYgsikAXy4ytr132q1/MjxNgaVcjeWCytBkc/X69N/sVuuN+WDtow0v+vXBTxBlM9ygGN QmzKJTQ1ls6AJPt+UUQ== X-Authority-Analysis: v=2.4 cv=Gc0nWwXL c=1 sm=1 tr=0 ts=6a16bf5e cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=tOrHYADZn3q5Ogi6NzYA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-27_01,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605270095 The QCOM_PDC_SIZE constant (0x30000) was introduced to work around old sm8150 DTs that described a too-small PDC register region, causing the driver to silently expand the ioremap to cover three DRV regions. Now that the preceding DT fixes have corrected all platforms to describe only the APSS DRV region (0x10000), the oversized clamp is no longer needed. Replace QCOM_PDC_SIZE with PDC_DRV_SIZE (0x10000) in the clamp so the minimum mapped size matches a single DRV region. The clamp and warning are intentionally kept to preserve backward compatibility with any old DTs that may still describe a smaller region. While at it, rename PDC_DRV_OFFSET to PDC_DRV_SIZE since the constant represents the size of a DRV region and is used as both the ioremap minimum size and the offset to the previous DRV region. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mukesh Ojha --- drivers/irqchip/qcom-pdc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index a72e32896e64..21e2b4b884ee 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -21,7 +21,7 @@ #include #define PDC_MAX_GPIO_IRQS 256 -#define PDC_DRV_OFFSET 0x10000 +#define PDC_DRV_SIZE 0x10000 /* Valid only on HW version < 3.2 */ #define IRQ_ENABLE_BANK 0x10 @@ -358,7 +358,6 @@ static int pdc_setup_pin_mapping(struct device_node *np) return 0; } -#define QCOM_PDC_SIZE 0x30000 static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *parent) { @@ -372,7 +371,7 @@ static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *pare if (of_address_to_resource(node, 0, &res)) return -EINVAL; - res_size = max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE); + res_size = max_t(resource_size_t, resource_size(&res), PDC_DRV_SIZE); if (res_size > resource_size(&res)) pr_warn("%pOF: invalid reg size, please fix DT\n", node); @@ -385,7 +384,7 @@ static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *pare * region with the expected offset to preserve support for old DTs. */ if (of_device_is_compatible(node, "qcom,x1e80100-pdc")) { - pdc_prev_base = ioremap(res.start - PDC_DRV_OFFSET, IRQ_ENABLE_BANK_MAX); + pdc_prev_base = ioremap(res.start - PDC_DRV_SIZE, IRQ_ENABLE_BANK_MAX); if (!pdc_prev_base) { pr_err("%pOF: unable to map previous PDC DRV region\n", node); return -ENXIO; -- 2.53.0