From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 809AB4279F5 for ; Wed, 27 May 2026 14:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779892525; cv=none; b=qFM/s9Ej9ivr8/jCBna9gwT9aYeK/+wecTE5tvpV+XR/7GRQfn5HDx6lGB/fBCJpdRXIu4NqlaNZkfNGIUENRph2ZGIeY5VZGOOmqO96aWhZzwzh4N8/nvZqPe5tnwetkCiF0IjfpnK0y6CgoaLTtf4AVFt150ybOl5jTVU5D8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779892525; c=relaxed/simple; bh=oDWKqtDhTF1qyHxIbD15S5vg4OO35WpqEhsWVqAUDSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iJZHGn+AuAXiFulmM5tLx2cmYGn/FxUptum558mOcqXiq4AAqZw4hR/G4j6Q+tuQQ5QcBTpFXiMKk3fTwdJBeTx//KE2jn3eT+vp0jLuhHrexFZmEhOrw2r4A3xmEo1RlgU28uRO6THK/hgAsApiVQqaD1eluNugzTPP+WGRaqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RoG+FgdL; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RoG+FgdL" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4891c0620bcso75369405e9.1 for ; Wed, 27 May 2026 07:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779892522; x=1780497322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vn57LpZx1VKSH9/vRJzOE7/6rh8rI01XjeBWgZUoy7c=; b=RoG+FgdLKrtK1jTsy5RAddq13AfKNprgBuI9MLyAeKup5P5xmw8HJ3YjW9zCahlmAx GWjkNW4/5rdOmwYPTFC4UDU3FzPbPxjmxyo7tPBX8QHl/yew3iLA7bkhp9kTrJ6I+qZU PPPyaJ90JBbEV9LgaSdCW7bvY8ZgfRIAoS9JWxXQiODESVLXX8J15XQb70q1q3wR49lV OqxWjNmnuhdQ4kDkp+siSkkZlFZhFSebWys4u7EyzAzrlTdVLMBLmYH7su//GfLshYOU tsiFwZqvNLbFxubfPUXUhIgH0tO7IfPdtWK6PTQRzP1qtxPUfZrc1y9alpEPzjfgf7kk nh+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779892522; x=1780497322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vn57LpZx1VKSH9/vRJzOE7/6rh8rI01XjeBWgZUoy7c=; b=Xczr4u8sQ6V+2v/pRjL74gGS//9h0B6e3gbJg7UcJasOXhtDgJE48tt50+NY4hC3AY IZeC2DSDOvxUoEx7THh3Y8i3qOKudbR4HvwYtmbb03G7XcU+2vEaZ37ubEQbLvvtIIMS Wk3do0ByPk6Jd+wEmNXD9UK+FLUHOMZeWPlrEFixR0l7TzyX9SWPtvymicLe0Dc/x6T5 pqaK99Kxnr1rcXIruAobYwDR/ykOFXrOglivnfextylesduuzoo5w7Z9aE5T7WejrZqL CFSoJjljZhYHdwgS53rEzV88n2m9Pr/3UVtJVPqqAmPcijiLRwWrLeb8LFji+ZDtHI8Z LTXw== X-Forwarded-Encrypted: i=1; AFNElJ8fW0JpMHsAl9md1QJLuG9JXB1t9ofLb/O+H1IBbpdZnhmsoftd8yyAdGcT3JSfRWPsIQwbWprXVZoo0tI=@vger.kernel.org X-Gm-Message-State: AOJu0YxRtatgPGPnjKeVx+9/lMrKmkQ3uAnj2Kf2HF8Rw1Qop+FiIMFN M6sFqr0X16WGFu8eX7swSpl6TgZqb7tbaud9eG4cksns4a3LffOj4ELt X-Gm-Gg: Acq92OEOT94m64+4jDrJClQ5ycfl2D+XmDcxW6H+BT0LZ2V0Y6luAQPePtU74roMkom bjirsuDt97aUZ9qV9lkjt8kw5cnlBtMOKmiGdxoM4stgVle5pbjWvJeJC5VLiOmnuzfxU68aFcU 0QK0FPL6UkgcjoxEeb5CrbvM40hcXr/sePAet6UtnfSIrT7ev6wDDjVRtmoJdbpPZdgJ8UtFp+K Wf3yJK7D+8+s4hG8qq5BgViOKi4aiXcfzwseyWG0OWiNGDM9Ccj1Q82bYi5eMOBMcLVGsYbwQuK oFnS2eYaXsiE2k4nKB/YvFBH537O1X8yBb7pzdEWiyMjMAF8Kt/I1tWYXwILU1ecCvYcIAGZbVV QDYvTuli0dLSJxNOUftBGIEC8ZLrL3y0o1eAWSAcCmeo1c2AYNQ12sV+QQkbqe9cOFhow7uRYkP Fi7bhw X-Received: by 2002:a05:600c:458b:b0:490:47e3:929a with SMTP id 5b1f17b1804b1-49047e394a6mr366016045e9.6.1779892521796; Wed, 27 May 2026 07:35:21 -0700 (PDT) Received: from sefo-laptop ([2a02:8071:50c5:5c0::361b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45edb5584b8sm6239763f8f.11.2026.05.27.07.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 07:35:21 -0700 (PDT) From: Wadim Mueller To: Jonathan Cameron Cc: lars@metafoo.de, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux@roeck-us.net, jdelvare@suse.com, ak@it-klinger.de, linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 2/4] dt-bindings: iio: flow: add Sensirion SLF3x liquid flow sensor Date: Wed, 27 May 2026 16:35:02 +0200 Message-ID: <20260527143515.102794-5-wafgo01@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260526171930.0db4125e@jic23-huawei> References: <20260524205112.26638-1-wafgo01@gmail.com> <20260524205112.26638-3-wafgo01@gmail.com> <20260526171930.0db4125e@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 26 May 2026 17:19:30 +0100 Jonathan Cameron wrote: > > +description: | > > + Family of digital liquid-flow sensors from Sensirion with I2C interface. > > + The same register map is shared by all family members; sub-types differ > > + only in the flow scale factor exposed by the device and are detected at > > + probe time via the product-information register. > > Because that doesn't work for fallback compatibles, we often give devices > their own compatibles anyway. Fine to also detect in driver but if we get > something that falls back to an SLF3S-0600F I don't think there is any reason > to think the subtype will match, so we have to trust DT to have given us > all the necessary info. Done in v2. Per-variant compatibles (sensirion,slf3s-0600f, sensirion,slf3s-1300f, sensirion,slf3s-4000b) plus a generic "sensirion,slf3s" fallback. The driver picks the variant from compatible / id_table .data and uses the product-info sub-type only as a sanity hint - unknown sub-type on a recognised compatible is dev_dbg() now, which makes the fallback story work for future SLF3S parts. > > +properties: > > + compatible: > > + enum: > > + - sensirion,slf3s > > If you don't expect to add more sensors this in near future would be fine > as a const rather than an enum. The enum stays (per-variant + fallback now), expressed as `oneOf:` of `const:` and a list. > > + reg: > > + maxItems: 1 > > There seems to be an irq. Given bindings should be complete that should > be here even if the driver doesn't use it. Done in v2. Optional `interrupts:` (maxItems: 1) - active-low data-ready signal. Driver doesn't use it yet, but the binding now matches the hardware. > > +required: > > + - compatible > > + - reg > > vdd-supply presumably needed for device to function so should be here. > From dt-binding point of view we don't care about the kernel providing > stub regulators etc. The supply documentation should reflect what must > actually be supplied. Done in v2. vdd-supply is in `required:`, paired with devm_regulator_get_enable() (no _optional) on the driver side. Thanks, Wadim