From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B0A33EAF3 for ; Wed, 27 May 2026 14:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779892528; cv=none; b=jsdYNeWaTXCm+sVrUFkUENcf3tiDc3jWjCJ1hvxT33saoEtex23t5HVvywmdR2XRTRVp3wRxFLtN7PKTl8C8p1bWPc0fDVdjnl2UOsy8WSZZg9eTtL1EjDzbpIWRwuiG+55ATJd0drIL1P+ovMryqVBjLRDkeIvIMwRquTXBUZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779892528; c=relaxed/simple; bh=WTcPO5jx3m8I3dAcwWfqNAsiqQwEq6XdVKR3O/E/HPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sx0ImwYE2vyxLDmH1rzUBEmbhdOyUDsGbETIz6fxVVHfTPUIAqvStvAxwVpA8QB/OU4XcEmqBBk1RN+6dFNUFofpHoUTdosJaBoBBpHDeiWIKO8cxoWXiufFAC415/BoiM60E7dCagCZLP2HdOZm/Hz3dYr7UpeVtNTJ+VgXacQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nS6EeIFz; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nS6EeIFz" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-441209fb77eso7310166f8f.1 for ; Wed, 27 May 2026 07:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779892524; x=1780497324; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mGLUdia9Sn33UtIAjIRo2viP4FX9Z32Gv1ySJx1Aq8o=; b=nS6EeIFz2mphXjAba0hsnvpPilXsQFyq8V5Cv6k20E93+3vK/fNGaaWQSibUZTNNyr NpKlXTSoeh96uEID4c20on51llVXZbkfs94N7cJyyLT1G+DAHsAb9BAnY1JZEsIfNgvu PtL69EY0qz9kVWbXQFPlZ3wOjDAdLVF7+NTZR65qZuP22D7c4Xud8grECU2dH2/n4UKq ACrF6mk7MbQbiTLYhdL80bnwzVq5cM3yxFa6QNe87lwDtSIzEIPlewhrKMriqZBbQnAz XxetIqi6e0Y/HqmsLjbzNl2oTCp9MPUg6KIquwQUyAJeNYdupb5x8emvFMYtk3ykhpOy sjbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779892524; x=1780497324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mGLUdia9Sn33UtIAjIRo2viP4FX9Z32Gv1ySJx1Aq8o=; b=PCr7Y/+4glkEhJt6YDeVNXWlOB5JBc2DeK483+q+Hqt7VejeE6VWZWIpT53eByU3S/ vhhmBsPrD8ZVU7UVdYQUFoEMH0uEfa5DXAD2XPtltyf8szyxXNtMH7R7VcxPfnKsMbBk s8EPd0NcBoPtEUvTgRBXAoEWKUMhuC1HwBQhZ+9LGQvuEzA32En4aBgdX9O447jm96tk lWZItwztJj0eEs8RarH0sbwZhv9e1io/cpyjMbFXq5UoRIUVdT9Kzc0+Mrth4gBDTMt4 U0yWBeJaMkA+qbG1rs2YkAp3BCPd+TNbL4gmu4LJUkNZR+IkyahKfsNbHDcxwrYOtLEy D+4A== X-Forwarded-Encrypted: i=1; AFNElJ8h+DEYVuMM1iEEb862i7yGTyakFAy8ibuTWJ5hkV01Pgnr/gZgL9AHUfcrU3aSwdMqJ/jS4GdA+YKNAV4=@vger.kernel.org X-Gm-Message-State: AOJu0YxGHK50z6V9ejl3zJ9AmeEIXSrUCdklv3SuTLYO6GI6GJFZ/vIz NQMBOVCTAX4EAisjMxDOZaA0pKeveu6Nfrq9zx6WlZOFjm1+UUhUnFWk X-Gm-Gg: Acq92OEggvfJZqJ00sQXqixrRP+qVyuTDLJk5uW5kjFHGreh4LjzjrBBpRmtdiU43hP ZctMP4abfjCK1W0RASDZ/Gu/D9vYKPqISh+EQ5nEAhw0Tc5BHEnUk5JcG69yZg0wtmvir803FxT YuWgycsIrwK9yNyXs0wIMMcPmuKoJmE1flRgiSDqsg+SiRlB1IHbFoTHU82pYTkNaRychxYh9u8 lj6C8ihdcSbbrA/xVXBPxGwDk5ZgvwSB7IBu92CVWq0sYYK6LNGbtG4aJ+9UxvU/KUiIZfiWjbW ZSbhLHcNVLQrJxFr14lB1swIqDpsZDajfHSOd5qzlAd/xdBHhln4SuWGda2q/iQI6iuPm0k4RzW HIgndKd8ofqjPFAsCjghArMYwdgikYNJoIQfTamyL9QsnmBXPYDp6On+hkgag6pv7rLz94wQYQb yjTc56Vg84Qwx7m8Y= X-Received: by 2002:a05:6000:26c4:b0:453:9897:76aa with SMTP id ffacd0b85a97d-45ea31a36d2mr42115457f8f.21.1779892523971; Wed, 27 May 2026 07:35:23 -0700 (PDT) Received: from sefo-laptop ([2a02:8071:50c5:5c0::361b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45edb5584b8sm6239763f8f.11.2026.05.27.07.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 07:35:23 -0700 (PDT) From: Wadim Mueller To: Jonathan Cameron Cc: Guenter Roeck , lars@metafoo.de, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jdelvare@suse.com, ak@it-klinger.de, linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 3/4] iio: flow: add Sensirion SLF3x liquid flow sensor driver Date: Wed, 27 May 2026 16:35:04 +0200 Message-ID: <20260527143515.102794-7-wafgo01@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260526170618.14f45e2d@jic23-huawei> References: <20260524205112.26638-1-wafgo01@gmail.com> <20260524205112.26638-4-wafgo01@gmail.com> <4349f634-dd7b-468a-912c-5ceb8a283954@roeck-us.net> <20260526170618.14f45e2d@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 26 May 2026 17:06:18 +0100 Jonathan Cameron wrote: > > > What does the "X" refer to ? Why not "S" ? > > Absolutely - no wild cards in file names or indeed in variables etc. > Just pick a part to name after. Wild cards go wrong far too often! Done in v2. Renamed everywhere: slf3x.c -> slf3s.c, SLF3X_* -> SLF3S_*, CONFIG_SENSIRION_SLF3X -> CONFIG_SENSIRION_SLF3S, MAINTAINERS and binding titles too. > > > + dev_err(&client->dev, > > > + "unexpected device family 0x%02x\n", > > > + buf[SLF3X_FAMILY_BYTE]); > > > + return -ENODEV; > > Similar to below. This can't be an error or we break fallback > compatibles in DT. There are historic drivers that do this that > we haven't fixed up yet - but no new ones please! Done in v2. Unexpected family byte and unknown sub-type both go to dev_dbg() now; the driver keeps the variant the compatible / id_table selected. Only CRC failures and bus errors fail probe. > Given the need to support fallback compatibles from device tree we don't > fail at all on mismatches as that prevents use supporting a new fully > backwards compatible (other than IDs) part in older kernels. > > Whether a dev_info() or dev_dbg() is appropriate for such a case is > less obvious but definitely dev_err(). Went with dev_dbg() for the unknown-sub-type / fallback path - silent by default, discoverable when chasing a quirk. Thanks, Wadim