From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1863EDE69 for ; Wed, 27 May 2026 18:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779906683; cv=none; b=cfqFAnWkL+aQ0RX5gKi7rFijlbUrQIUVbGsL/X2q5sifQwc5yMX5Cv9bxVoI24z2mTVtXi6w0kammqNFLWqZ7nqV6OyTsalf8VUU8bxAx+CnsXhDuKb9V4+6A4xcTO15QnK1PbWBPpAsG3zIE7dNw4b7jOd+a+jlyd/mtH3/nH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779906683; c=relaxed/simple; bh=r94AZzJnXSbMnbxI4Zpr0SaVeS+ejS57fzXN72xSV0o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xr4AE+uFguzH8tUycByERAf8F6U6jkdA59g9uEG17R3pgYm4Ksn+luYwJ0T6/yQFiBmp//TT03KpuqSDTRYjl6zgPcvWK87n2TTZb594xLdqpX+whX09Ekg6fn0A/I2H7xme/IeX6DVmmt3xJdsk/4ZKNWsGmPibdQdEhK8rxe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ix5kqDsV; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ix5kqDsV" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-45ed9336049so1703249f8f.0 for ; Wed, 27 May 2026 11:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779906681; x=1780511481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v2TLbDUJP7Tpmwrt9EebylXvF9EPT9xRZzNZOi9eErg=; b=Ix5kqDsVq1UppMd5pv/mhX/nf1bKZwn8OtLU7KJvsQihhTJD03PbMDNTEIihKw37p2 sn2uY0VTPbDBpwbt++3zyhlpcsPWBpTKfpaImKv+bCzqGVT5lciTMWpP0yc9YY6zWK/k HXQr9ftE2USst1agDAaPkWI8257Lisi1ZiYaDXAlhwYhIMGWWhCyYdfDr578BVulxfFD QMbzQb+mCKYXGfCGZJsvuh8k+ChtOya0uQE+R4bmvLYx1CVEsijiSHNmCWHwXwzanYIR Ab4uVPiH7NihuzT8Ia2uevzDb89sxqfHF/ABuoh9UkRRTZMyPsTjXZRKWA9tGnHDEh65 vRng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779906681; x=1780511481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v2TLbDUJP7Tpmwrt9EebylXvF9EPT9xRZzNZOi9eErg=; b=jX+kYy7xKQNQ565NJuwjGiNmFFVDq99G/bw1PK4nXrmj7AZNwVFaU2hbnKhfWohRz+ n1ILh3x2BDfN7pX+BzuupOTjchcA8Vm3ZXa9E68mu2M3XOCOGQ8TucCm9GlbIB0XN0mO jeyqOvizmtM3so8mLn8Ama3sjCC/GK+QhBfB8WLE4zvdIjJTG+BlJCzrBv8Bs8Y/6Azh 8UV6POnwuwHg6a4cakBN+JGoBr19ul6Uz3ZUrawfj/EIa3gHFRLo5rl4UNioXYII+nQ5 U0R2jLT5dx9F6grswOVosMZjxLoXNw+3jhCVXdBV3wjp/k32bGxswOma/8ZKaPDIZOX6 R/Cw== X-Forwarded-Encrypted: i=1; AFNElJ9DNDV51RZTE15McwZdCjBCXy1Ozt6Flhnk5WVO58FPmmcK/PbnH34GOiSSosgVJ6tIjfHcxAzttp8hkbw=@vger.kernel.org X-Gm-Message-State: AOJu0YxgrLdH1UzFG9gVhAA8J3GymkNcEhexo/IMrt84PNha6IpPpA7X 97akXZXTDvsN/j001syl5ejavSy0CUcaxzFqdZzQhAI7o/F7keK6BX6P X-Gm-Gg: Acq92OFmmvnp2+NtPcofv75JzchOkEu7Yo8P85Fy0yBdx9cl5pHhjt+0qhTtaqoW3GO nfEJI8xT0/p37H7tljKEZmAA2pHAlpKty1iv7VoXgk9pnVP+eTcmQjlwoqH+F1+Zh0rf8PZHWvt TrQyKcsZh452jyojVSRVaL5uQ+bW1uX+WNxAD1b1ZI7KZQyiCIXhc7rOA323zQdRYfnFkV/6ruG QuOBXEmypJaIG/8YnGdjSEqzeVb6GcwAXOZE0O+6aDqIRUgr7hile5bldTIOB4F+kHOnHRamEdH WYrHmZ/q5d0cWccX4ONFOMvyxkwz4TAhDP/IF47BYHUlWrIauumTYvcB94zwLUV9slwszVVc1pu OOV4YEOOBGtE+fqyaIMe7Q7IitcPdJRaLpUa5NvRBWC+yEuQqdnxNA8i90T/AWbYgHT6wzdfKMB AbGNVzAtLhuH78hxXcwUlzMH+QgTIWGw== X-Received: by 2002:a05:600c:4510:b0:48a:53ea:140b with SMTP id 5b1f17b1804b1-490428ddf15mr379350205e9.28.1779906680441; Wed, 27 May 2026 11:31:20 -0700 (PDT) Received: from localhost ([212.73.77.104]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4908b5a7a48sm573105e9.22.2026.05.27.11.31.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 11:31:19 -0700 (PDT) From: Askar Safin To: jkoolstra@xs4all.nl Cc: brauner@kernel.org, cmirabil@redhat.com, cyphar@cyphar.com, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [RFC PATCH v5 1/2] vfs: add O_CREAT|O_DIRECTORY to open*(2) Date: Wed, 27 May 2026 21:31:15 +0300 Message-ID: <20260527183115.2251894-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260525202937.466497-2-jkoolstra@xs4all.nl> References: <20260525202937.466497-2-jkoolstra@xs4all.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Jori Koolstra : > +static inline umode_t o_create_mode(struct mnt_idmap *idmap, > + const struct inode *dir, umode_t mode, bool create_dir) > +{ > + return create_dir ? vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0) > + : vfs_prepare_mode(idmap, dir, mode, S_IALLUGO, S_IFREG); checkpatch says here: WARNING: Symbolic permissions 'S_IRWXUGO' are not preferred. Consider using octal permissions '0777'. #4361: FILE: fs/namei.c:4361: + return create_dir ? vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0) -- Askar Safin