From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4813161AD for ; Wed, 27 May 2026 18:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779907689; cv=none; b=gmfBskv6wWRKdn/WX8LAaoxLG7uVQk4XGaS2v3sVL6As3gJ1Zqt10yZkJ3DMboTv6STX5BM8lEgR0++zNDlzkM6xFTI/0sb2wgLIG/2fCH2oTt/p/88VVmtQ1nY6Ja3a1v/8Yb6/tvxFib+MN6yYA+tRvEZOInrEvbN0ddq/7q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779907689; c=relaxed/simple; bh=4cIsa04PN1OdjLGHfj5sUlYjZlutQyUTFbZvwJNN9vs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BpirW2TPoHieO+kLRbtohSgpnyfYjVKVbZcl6eZCslL4YrONzyMa7CRQIlFyx77qnkarwTdAs8J/PHQjv5sKRHTpefBq96UfdyJS7vG0y60MyBB9WkTpS3jpHWtebV1nEluhfORQd3klWlclSuxjRE7Z3wz/ZywZtu+6iSdB7ck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MydiH42z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MydiH42z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 200E11F00A3D; Wed, 27 May 2026 18:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779907687; bh=07ezutEcInVG//yT0ldXpRUrdrAzNSr842HzE2J9pPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MydiH42zD2bX1JV7tCa3KUOOt4FutOpXpMqIykH5OrWBjIlX80mFOaFz/iCyq89Dy p6Tp8luXT72Tq+Km8mCwL0b/DxrsAtIknnypO8kh666+qL7Tv5vV6UGlyN9+X9haaw Oy5/1x+wWonkUSdl2+dHuSjyBWDDvc6PrZm456vfAUhXs2Dcr+VNM8J5memLbt94+O 9Wr97k8aBGuueLEyI8SLfiAo79l49ah9ioUQyYmNLBOjAw6Ff+12JSHR9HQbsZdajC fk5PtvmP3vYKzub50UpAcyCQT52xTt4TPJ0R70irEgsu6Vtv7pMrd5oSj22Gc9vFD9 eqLQsHv1g22WQ== From: Mike Rapoport To: Andrew Morton Cc: David Carlier , David Hildenbrand , Heechan Kang , "Liam R. Howlett" , Lorenzo Stoakes , Michael Bommarito , Mike Rapoport , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] userfaultfd: remove redundant check in vm_uffd_ops() Date: Wed, 27 May 2026 21:47:51 +0300 Message-ID: <20260527184751.4147364-4-rppt@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260527184751.4147364-1-rppt@kernel.org> References: <20260527184751.4147364-1-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Mike Rapoport (Microsoft)" Lorenzo says: static const struct vm_uffd_ops *vma_uffd_ops(struct vm_area_struct *vma) { if (vma_is_anonymous(vma)) return &anon_uffd_ops; return vma->vm_ops ? vma->vm_ops->uffd_ops : NULL; } This is doing a redundant check _and_ making life confusing, as if !vma->vm_ops is a condition that can be reached there, it can't, as vma_is_anonymous() is literally a !vma->vm_ops check :) Remove the redundant check. Suggested-by: Lorenzo Stoakes Fixes: 0f48947c4232 ("userfaultfd: introduce vm_uffd_ops") Signed-off-by: Mike Rapoport (Microsoft) --- mm/userfaultfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 2872c71bbf36..80cc8be5725f 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -68,7 +68,7 @@ static const struct vm_uffd_ops *vma_uffd_ops(struct vm_area_struct *vma) { if (vma_is_anonymous(vma)) return &anon_uffd_ops; - return vma->vm_ops ? vma->vm_ops->uffd_ops : NULL; + return vma->vm_ops->uffd_ops; } static __always_inline -- 2.53.0