From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF123126D0; Thu, 28 May 2026 03:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940019; cv=none; b=WEfp0Iawb/G7W0UUN1m/yKH6xGbKOXF15TTmfF4PEzKZmx2dSO315yEnssieY3AR3j5W5QpRs1Ru7Yiyxl/0mMko5c7mIHU52Qpoi7mMKtlaxjhQgouPAKlHj3ikOBDQ9O4qfAhf/Qgk8nCGfuV/fxCTGGD2tS+OgwEYA0CBFYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779940019; c=relaxed/simple; bh=XAYwosETQlgTdWFDYwvk1cIdE1sPk2gmVdWmA3M7CUE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=K6/58qOMc144IPt0T232IxF1eGhP0aKsZxuwtVMdUm3pMS7bv498At+ze1cylvnHjdafc/VEW51sV+zmesS/Iqq6oJoGrWX4N1CPjjOCctN143H2eDqAJe+hr7mTWDe9ewqkT6Lb+BzPhQ3lMk02TyZJpsGyeiefqbuDOgkv1GM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=ecgDFNMl; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="ecgDFNMl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1779940019; x=1811476019; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=XAYwosETQlgTdWFDYwvk1cIdE1sPk2gmVdWmA3M7CUE=; b=ecgDFNMlkHFr3ANqsIGGUZaIdEQdJiGAeBY0d9vVKHNDyeJVdns90vtM lH9RWILLETqevdXcluEEmGr0FqIFYtgjkiWlZRB0ikc/osdiO5o76rWXZ 0v9ADRBQAjG4NnGMd7EX+b87mcRy1gjrXYisNmdxG1VhzM7isITR2a7xR PDFBWhP4XHZSDsYu2r2f5gWLOl2Tca9eZQAllpIoGjFRgKzVQesUiR3je gCCd2Rz9avkuIvJcult14HkRnv/hb+XVbfpj5aiULCsfVVV7I4IzUHLZ4 xng6ugUGd6mxvMKhVA2HP4woXw3v2NDuAUv6Tm+tdM9g7F6ihtryv8fiu Q==; X-CSE-ConnectionGUID: QqRB4jt9Rnec6qn95pzP2g== X-CSE-MsgGUID: mEsV2YGsQn2Iq6l9+eToTQ== X-IronPort-AV: E=Sophos;i="6.24,172,1774335600"; d="scan'208";a="289548683" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 May 2026 20:46:53 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Wed, 27 May 2026 20:46:51 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 27 May 2026 20:46:48 -0700 From: Balakrishnan Sambath Date: Thu, 28 May 2026 09:16:44 +0530 Subject: [PATCH 1/4] rtc: palmas: convert to dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20260528-cleanup-dev-err-probe-rtc-v1-1-29dc9cb6c3f0@microchip.com> References: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> In-Reply-To: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com> To: Alexandre Belloni , Baolin Wang , Chunyan Zhang , "Orson Zhai" CC: , , "Balakrishnan Sambath" X-Mailer: b4 0.14.3 Use dev_err_probe() in place of dev_err() and return, which communicates the error type and helps debugging hardware issues. No functional change. Signed-off-by: Balakrishnan Sambath --- drivers/rtc/rtc-palmas.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index aecada6bcf8..25fe7a8b73a 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c @@ -242,10 +242,8 @@ static int palmas_rtc_probe(struct platform_device *pdev) /* Clear pending interrupts */ ret = palmas_clear_interrupts(&pdev->dev); - if (ret < 0) { - dev_err(&pdev->dev, "clear RTC int failed, err = %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "clear RTC int failed\n"); palmas_rtc->dev = &pdev->dev; platform_set_drvdata(pdev, palmas_rtc); @@ -280,10 +278,8 @@ static int palmas_rtc_probe(struct platform_device *pdev) ret = palmas_update_bits(palmas, PALMAS_RTC_BASE, PALMAS_RTC_CTRL_REG, PALMAS_RTC_CTRL_REG_STOP_RTC, PALMAS_RTC_CTRL_REG_STOP_RTC); - if (ret < 0) { - dev_err(&pdev->dev, "RTC_CTRL write failed, err = %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "RTC_CTRL write failed\n"); palmas_rtc->irq = platform_get_irq(pdev, 0); @@ -292,18 +288,15 @@ static int palmas_rtc_probe(struct platform_device *pdev) &palmas_rtc_ops, THIS_MODULE); if (IS_ERR(palmas_rtc->rtc)) { ret = PTR_ERR(palmas_rtc->rtc); - dev_err(&pdev->dev, "RTC register failed, err = %d\n", ret); - return ret; + return dev_err_probe(&pdev->dev, ret, "RTC register failed\n"); } ret = devm_request_threaded_irq(&pdev->dev, palmas_rtc->irq, NULL, palmas_rtc_interrupt, IRQF_TRIGGER_LOW | IRQF_ONESHOT, dev_name(&pdev->dev), palmas_rtc); - if (ret < 0) { - dev_err(&pdev->dev, "IRQ request failed, err = %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "IRQ request failed\n"); return 0; } -- 2.34.1