From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7458B34FF40 for ; Thu, 28 May 2026 07:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779952259; cv=none; b=MsqYEl3lajoG8LE6wd0JwGDmM2a8U/IjLBZHqJ7Difq7AYvQs8C9NxBEqXSN6R8UCy6EOurcvE/hKdEl4c/+wHMM1lTqr17DXGkzXOVj9mGAMEiJiMdvzBy29tpI25mFLeNi5F1u+4PDUKAHR3UZn+pKNA7SnLC+zQunkqHAoNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779952259; c=relaxed/simple; bh=uaisOO81wUqXM57ZY+50E+vgpCZk+fmw3L+QuSoJRis=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O428dLRVbD1kEubL5m763c+cPCKFZ4zxnSthcbFkbTb14PpW7bT941YEjld5hknusEcbyCJZnuKyLFqPEMYVQnqNNMsbjR3+D4kA9ANtlwJuEccaHWQnD9fxSfqhSZ4jomPW7/SymeAWVKkENA8wMlgvPY2F8orujDI/+qBrgiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fKgYbzC5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dw4jMGiN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fKgYbzC5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dw4jMGiN" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S6jF9F4188865 for ; Thu, 28 May 2026 07:10:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dnqi4A1Nw9iq1rCq6bx9iMLW6imbL+bAYQJUwKQDVEA=; b=fKgYbzC5CpKmUqWd s7XIxzYb1hUGvkCKRZ4W7hY3Sndz0TBo8qQn+8+0+gLO2Y/YILTTtpBqAEd2LV+N 2ztBNFVXtqF1V8PuLuntECmwQRd4Wz7OUmfem0mm3nmMLzxFNQne7oR+KTreQ6Jx DyiIeXEUEoiHG6mKWsE6nL1uHxg41IpOaGuI/nGb2viLmoBxILAGyWZRFg3oE80/ oH3DBCvCQPuxa3TwAoMfZ4mIHPsEtDZ6md45qn1yLhjJNwzlMAnjxs3u/+H/tJY4 EYmL8iENxk6h2lYPhtD/sqBGxJxLOtJwgJbDLnJB/2/4re2bCKQhAPxNyv3vQijO pUXUJg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7y2spye-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 07:10:57 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-516d58f74b0so72453231cf.0 for ; Thu, 28 May 2026 00:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779952257; x=1780557057; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dnqi4A1Nw9iq1rCq6bx9iMLW6imbL+bAYQJUwKQDVEA=; b=dw4jMGiNYkWOr+2YCeIhPgiT/QYfowl6+A7AOccVRztmna8P65gmrLk5Tav2Mms+59 MnZ4t0hVIi32zlKFwMi2AkW8S7TR1ELuPc7l+dEeMYMCC4Cb3NOnWjVeb+bwUc7M7wph 5cwgeMeZZlROxjd95VLVfbb7U6n3vvYV9F1RcWoaOgwDeWPS8H83KRGB3ah67ApFmzpO 5aTFheRLvXUr6Zf/rBke+XAMsO5fSEjuY4iInpyonxa2OVQuslB5TeTzlAxMeEN+ywLH 6H9ACyEJtqcBxQqgC7iPfafkUHDLXH/xJ3DkufalrXk0rBDghStL3WHp64daKUO1shaE bKvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779952257; x=1780557057; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dnqi4A1Nw9iq1rCq6bx9iMLW6imbL+bAYQJUwKQDVEA=; b=KsyVqIySpotHQvn5PM+ImqiRd1AEB0CVHdGt3GjHuJPAbD7jP0n10isW/eclmQy9Q2 r92BXFVJnslXn/RgiuP50IC/tbj130fP+AB95BMjsbZj1yQmOYSZ8qScO4j51jr5vnk+ WCRzPsJ8GfI7bACQD5YQYShBGQh74FLinF1aXvQ6FPaDZ7GiyDprqKg/frOZYP/mbjMj 8pC6hEE6rOdO91I3OsFVyP0dG8PF+QHhxylzIf9TlNx4jOrTnyqfqSz9NEtN64oxs1+e jTUSLR5xeckZiyJHW25ya0CNr9UgIOkQepFu7+McT4PdzjNjbFyxwXKA9cha482sy8yh psXg== X-Forwarded-Encrypted: i=1; AFNElJ+06PlvJlEecuw8qJGt0euSdIBNP0fSNgELdmXoblW8ag82b5Lg2pCtetiiS8DIfjg6v9basQ3MIsVBUpw=@vger.kernel.org X-Gm-Message-State: AOJu0YxV+z3wpRWUDCs2od9GIKMxJNJ0F1J+HwSbhctj9HkJepIAEfvn Jjq4fK6dsaBHxRp/Rcwav9zHRdAH+OFA+ZYMFMVmHo0rTqpjqWbuRBB0I/UDZeg76TryH2dHFUD PuonmTzKmFD6kn4jZP2jXKHXrylgQbyKQleMZ915cb3fXC8Ay/yC80C1zp2QeDsgybnQ= X-Gm-Gg: Acq92OHRJieLWu7JfcQpw9IxaBRWhww6ByFpCfIgl01UPC8cJOv/0nUm4ASG9rjmsrR VHEMsfafADuyYBxo+5/+4erxAHTcP2KW+03lq21DQTCw76D5fp+3JNQAx7ejZiA8euMV8hjYAwv VEeLzyiOs8dzF1w62OPmgMJjADmekKuL6mKuJufWbeeg8lOWb8k3+Dp1lGIA+qitp/uxDeHGhdh bxzYdqRUKswdoJJKg2mePp3xfTzjMuRPis9csFT/IKSDkdXjaLwIuuu6t7t1EzTYJmsOMYTwILM fvAPpMVywzaDZPslNNcnVA/cI3vWWP38maqz7bjteykQl03LOwEgeEclDFyXq4f4owKl+r54gX4 LwX6fOImyhAS30djsKpl/gSxTmp5uJ+HoVTskC8cdOyvmZyRODZFcCiDcHimmT+j9OHs4C7ZZ5s btLejYUdFXmHLh/suEbAOREt2C9/0kJyteynSHCjEnOT883Q== X-Received: by 2002:a05:622a:1e90:b0:516:da42:43df with SMTP id d75a77b69052e-516da424757mr302438551cf.30.1779952256628; Thu, 28 May 2026 00:10:56 -0700 (PDT) X-Received: by 2002:a05:622a:1e90:b0:516:da42:43df with SMTP id d75a77b69052e-516da424757mr302438141cf.30.1779952256114; Thu, 28 May 2026 00:10:56 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395dcc0a54fsm37416161fa.20.2026.05.28.00.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 00:10:53 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 28 May 2026 10:10:49 +0300 Subject: [PATCH v3 2/3] drm/bridge: display-connector: don't autoenable HPD IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260528-dp-connector-hpd-v3-2-d656eb1079b7@oss.qualcomm.com> References: <20260528-dp-connector-hpd-v3-0-d656eb1079b7@oss.qualcomm.com> In-Reply-To: <20260528-dp-connector-hpd-v3-0-d656eb1079b7@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Tomi Valkeinen , Boris Brezillon , Sam Ravnborg , Sebastian Reichel , Yongxing Mou , Jonas Karlman Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2194; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=uaisOO81wUqXM57ZY+50E+vgpCZk+fmw3L+QuSoJRis=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ5b4q8qq3JJW1qxqoaf3TG7M+vuw07FkuUXaQ71p5utv2 0nxy1d1MhqzMDByMciKKbL4FLRMjdmUHPZhx9R6mEGsTCBTGLg4BWAib804GFoUpdRv7G37xRVT fMz9m7CV3nGJYBHt6x1uGX/+bXjx99nfxd0Rz6w1C906YqTeerdac9e+q2C9F1Azn8Op52aN0vb bL6uXWIip12t3K16+llj2eWeF4NL6vc/1t8acfMk7dUZ6pf2hPKuuGHvbmMNmLFN3yLvYWDM9/3 zkiqDvRCXX/AzfaQvWLbCV62zolUl7/7RccIpyp/vHymWCV763aiVuq1Lq2mGuZLs5PLt4Z7Aes /xsjrC6oo8P3CKZ9rgU3/n7XL5u7YHQ0mNtm5Nb9t5hXNX/mkVr65qWp79XsRnl8x3yUeJKj5S/ Fvz5+qpdErNnqocHcHrd1Ow0E960ZPP9Ek5u+1IrM34A X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=VeXH+lp9 c=1 sm=1 tr=0 ts=6a17ea81 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=n8oM3ScPHa2hF6C7bkkA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDA2OSBTYWx0ZWRfX20eMqV0qB4qc OBDTl7crl7OOvu8qhOhERaeFl/N/d/VNkhDD9oGIeWvqXpRcbhrnyjoCZM9Y6TQhCDg4hg+c55H KW5Mo24W7aJ7y2s8Z5/JHVcdKxouJ7Tg0MjMupWksC6IsEZpjm1H9zs96opucKBl2MqTHAaUPcb /wSyYa8EvDPtGXUDibc0Kv9bnJzgkNVecVkgzrbNuZLzC7N8U46QEB2izoGbBpgQKm0iSyafNKR 4OqAalx+Sec72Otyek3JIziCWuoNYh9LyZLX3Mk1soFDsI+tCNlQ3pR16uLJUbP8QnlHCZkNwk0 KnSrNrWUFvtIUcoTwN6vEnh6ttIMsJf2h+bmueE6E93NE2HBnLOs3bNAJgl68JcmPwS5P6UZIFv VFYH7WTTUQuWOU0f977natZTOuAGoZyGdT2ocl5g2qdK4KBrftm9fl4y9oiUple7+RBG07iCwfy SeSaJFOrCqlPftVknTA== X-Proofpoint-GUID: XMT0z0ssfkmFW7P3-MSpl5xZ4eYVal28 X-Proofpoint-ORIG-GUID: XMT0z0ssfkmFW7P3-MSpl5xZ4eYVal28 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_02,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280069 If HPD IRQ is enabled in the display_connector's probe, it can be triggered too early, before the DRM connector is completely setup. Use the enable_hpd / disable_hpd callbacks to control enablement of the HPD IRQ. Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/display-connector.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c index 16c0631adeb1..6bb1134f75c3 100644 --- a/drivers/gpu/drm/bridge/display-connector.c +++ b/drivers/gpu/drm/bridge/display-connector.c @@ -87,6 +87,20 @@ display_connector_bridge_detect(struct drm_bridge *bridge, struct drm_connector return display_connector_detect(bridge); } +static void display_connector_hpd_enable(struct drm_bridge *bridge) +{ + struct display_connector *conn = to_display_connector(bridge); + + enable_irq(conn->hpd_irq); +} + +static void display_connector_hpd_disable(struct drm_bridge *bridge) +{ + struct display_connector *conn = to_display_connector(bridge); + + disable_irq(conn->hpd_irq); +} + static const struct drm_edid *display_connector_edid_read(struct drm_bridge *bridge, struct drm_connector *connector) { @@ -178,6 +192,8 @@ static u32 *display_connector_get_input_bus_fmts(struct drm_bridge *bridge, static const struct drm_bridge_funcs display_connector_bridge_funcs = { .attach = display_connector_attach, .detect = display_connector_bridge_detect, + .hpd_enable = display_connector_hpd_enable, + .hpd_disable = display_connector_hpd_disable, .edid_read = display_connector_edid_read, .atomic_get_output_bus_fmts = display_connector_get_output_bus_fmts, .atomic_get_input_bus_fmts = display_connector_get_input_bus_fmts, @@ -307,6 +323,7 @@ static int display_connector_probe(struct platform_device *pdev) NULL, display_connector_hpd_irq, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | + IRQF_NO_AUTOEN | IRQF_ONESHOT, "HPD", conn); if (ret) { -- 2.47.3