From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5455F3C1F54 for ; Thu, 28 May 2026 10:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964897; cv=none; b=AmtWfZPGAlbYCcW5WNI/KrMjRs7ciGDFOCRTdiMIkxXd5Zxidjqmc4S2cwIWwLsfS+L73Ywna/u6Zd1s7z5hcGnOm3n8NQTRIrJc24sEvKkYMX4Qzu0xD3cuXQUnrKLOWwNsESVmMrwdSEg0oylmY/KxQS8vQ4ifMQGt5lI8gcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964897; c=relaxed/simple; bh=4TJKG8RTz4R+dv3UNXgRl/mjeEf45SUuZJzked/IkbU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NbQmVN6hLJ61KjAaVivxRn3Psla5hBwf/NvgafcdhZ4CEAq5ZGkGd+5MH/KbzG8lUeupDuwBomsfFrLB0yRwk9oaqONbmAlOqBpUSE7V0q6qOW+FoXzVJbiSqQYht2J1+dqIvmsBEd1kQkbUuPFRDy8lYzpZ2wKpAXn2i4frvSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X8UFai0+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P2AbVBd8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X8UFai0+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P2AbVBd8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S8vl32298257 for ; Thu, 28 May 2026 10:41:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=X8UFai0+9MuaAWsB tIK2fdVnaHnbQQpyp+mCqUUUcwy/Eep/HgeLjKDkjtUmoEl62qAVxXgMqGMo4VXv GI3up3BaHEqibRKV/SPGf2IeBPSnN0oAcM91PIQmKUJ9HEvcvrIn3UMegeBqIfQ5 xj9gMFb6aBIUf+DSsES2/0JaHBqS1ynM3d1ntqfACuulRvyFdO0cvjsjSeilEUs1 crNCdfoaQfjpLtG0rCijSKpxZiGP7iTloDSYNfV6qnis3u3g0iTtrqEw9WVKggRw m6mGKPAJuv0ZewLwdjiTsdxJEKmhU73RLvYzQWTv2T5M11Y62bto4HPJ4KKQxgrD pga+nw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7yajd5e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 10:41:35 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-91382222f94so2415257285a.1 for ; Thu, 28 May 2026 03:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779964894; x=1780569694; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=P2AbVBd8M7uyCuQ+awAPvETrx1Ih4yqiSQ8lpVPR1HYw+FqyRFp2xk5RNPy92uB3R2 1pgvaNE8TGhxyIOy3nqXgYnwdNgs9aYtTI2I0oUbq+tS4bdhWy1eTr6F55SseXNSm3T3 1tFrkHMIyK21LYa+xgMa8Guj0xwInY79tqmdkHaXD33TTFNesOzfXLiS7Kq37P8a/WE5 a+KRyEepBTP1vBvjVP9uhw+YyaRjWfEYRBFemdzHcdZZqrWlKC8b96cfpLNVvuJpLO/X AqjQm9aPjSDLgmN3wJQYC90aEtBUmWqjts8n5xJ91uEixWhhVlpuHy6qzZfcxsBU2g1g MrRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779964894; x=1780569694; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sRjgMQtRt4M0KMMF63fnqZRXOOmmbwogwYrfMYQ8brA=; b=FFSn+7ImCRqaZpTd/SxVqIdZYRyfdqU51eEexN+R1p9fWxb3oVy0vbYAiuPUR32fnW xupWmdr7sonswUwOQq50Rn/QTCivPSzMU3lkqN2FXPMpnc43W+VFFfCJrQJryDOuUNJF wZYynvh8qBsgl6KUyj8vW8/USGMfVMvZsJSVUo4/H+V4YNIBKj/3fLhRzgshPKtqJBjX B+LcS8d0nfYeOC48nI+TjR9sB5HaJYiY7h+z3kl4F4qq2F4MVVVfsuXrl6adycuHAB6g Gjwbe3ExRLySrU25WlZI1+KrqvnGnEaY8ZEYpgV7mWGnh6eYr4/YqqC+55lUqYXO/Ge/ djVQ== X-Forwarded-Encrypted: i=1; AFNElJ+VDR2sxvduzw125nCPSt9aWJxoiCgHRNu+yS1GPS+D0Qfrsi6Xf+GcouIiWwzZ4iHJKgaiolRrI3Ow+sg=@vger.kernel.org X-Gm-Message-State: AOJu0YzDhRA+ZCG4eeWk8CmuVHz2T2e4An+z4TTuk4klFvXsLAfrBz4s TeHnVOM008e8JL+NfTPx5oatDlwX6muh0J7JwoGpb3Mjr39TNyi7BsT83giPi8HFMT4zOx2HO0O v2zpktfZHiYB3xnBc6JuBG0rdF4fVR0D2MczbKAr3ubaO+7r3rV8ZdZ3mtkUwV7R5/j126bBpCD Ikdg== X-Gm-Gg: Acq92OGquQU8OqFxYDnJv2WmBEBb6cddc7pb7d8jVRRUht8/nXL5FlDhBs404n2YrIL ZMPXVdUPaFHY9sq2IRH5Fe1suqbvvHWfMqwQAbLBa6otUimfBcpMYdZmXcyL1yjrM2Ls3rWrzON EiU4k4464Ia95VOgUYcJL6NH/iO0E++WsVVyash1kPyF/8IYndloC1p0y4s28MRp+ferH+X/zOk 3EEm/45lx3S1fMWA8S108RTTsKUuZDy2RzBshClpvIo6WOMM+HhOEea+y3fVS/cw0AuRzgjEVQv fwSSwI1lUUr+zRMCWQaxv+UxMW28JAf6Mv3g76OELj6NqwW+DrcmbKyLiJCh6g3XJkmP/eaCVHt ntnlSG5RB0IIXN7vIrFkksWoVH9d+sNiKaeiUgDUTdH45UAg6ZSe3GOQWYORWUrgJG5wrpOW7pg M3LZSFrXQpRq3d92GrrQ== X-Received: by 2002:a05:620a:4608:b0:8ef:3953:7ab with SMTP id af79cd13be357-914b4974690mr3816770185a.40.1779964894480; Thu, 28 May 2026 03:41:34 -0700 (PDT) X-Received: by 2002:a05:620a:4608:b0:8ef:3953:7ab with SMTP id af79cd13be357-914b4974690mr3816766885a.40.1779964894022; Thu, 28 May 2026 03:41:34 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86fffddsm755148485a.12.2026.05.28.03.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 03:41:33 -0700 (PDT) From: Yongxing Mou Date: Thu, 28 May 2026 18:40:33 +0800 Subject: [PATCH v5 12/15] drm/msm/dp: simplify link and clock disable sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260528-dp_mstclean-v5-12-a9221c1f1f3b@oss.qualcomm.com> References: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> In-Reply-To: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779964831; l=1745; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=4TJKG8RTz4R+dv3UNXgRl/mjeEf45SUuZJzked/IkbU=; b=O2vDyy28Q7m7hkeaHk95FcqK8jDLNnDpdGRxSppdMbe8o4dOhJ9Tlri//9/rgsR4+pALPGcry hGSxUNPZVS4BGE82XwS86BiSvY//xdZxMeVXzMHqTznPpXMmplATIXV X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-GUID: sgf4pfYT5SXZK4JjGVCpjqhTP2PaPWyZ X-Proofpoint-ORIG-GUID: sgf4pfYT5SXZK4JjGVCpjqhTP2PaPWyZ X-Authority-Analysis: v=2.4 cv=CaE4Irrl c=1 sm=1 tr=0 ts=6a181bdf cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=W1j8KJVysGQzs9t885kA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDEwOCBTYWx0ZWRfXyy+sJSdC1OnO 2tP0kXsIPmYoR91mciguubi4RL4mtjMtKUQ1o0/BvHRJaK7Q3RHAPOud+L7hMtZ+w8LBTWihDTS snJP6bd8CWB9VfYHx/QDzqI/oxnSdeHxYaabNhFkHljSnrU5Ck+XEOh7a/CpnG/sK7TI63xB9Vn v1dGEzpUbNw/+4FEcrkOhJc9kNGZVrTjtttKE+YIUpSxgjr7GAw0946ixIzm/H61fySIHbPc7eD AdI5SSdd2ERFEEAcqFkk9EmSdk2qIrEO/IpwlH1+SyB5OxltmVEc7508ZSYWe9TJkWELyKGpOVB ST250V7toecSqO3ynVCsoCaqk4NC+PQH+Wu5cz8zxNoPof1wNZ1SdpKBpZoP9fprszM4Hvjn/CF 9kfOKbWjAKmet+/w9+iTxrOk1liwF5cShjbwL+hlm2ZZ+G+MjrDULQfZnvNoRR2Kx+zJA1ZjrHy xsA16HK91TDKxs2mWrA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280108 Move the common disable steps out of the sink_count check to make the flow easier to follow. No functional change intended. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 8f472633da82..63e5b191f95c 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -716,27 +716,19 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) msm_dp_panel_disable_vsc_sdp(dp->panel); - /* dongle is still connected but sinks are disconnected */ - if (dp->link->sink_count == 0) { - /* - * irq_hpd with sink_count = 0 - * hdmi unplugged out of dongle - */ + msm_dp_ctrl_off_pixel_clk(dp->ctrl); - /* set dongle to D3 (power off) mode */ + /* dongle is still connected but sinks are disconnected */ + if (dp->link->sink_count == 0) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); - msm_dp_ctrl_off_pixel_clk(dp->ctrl); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + + msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + + if (dp->link->sink_count == 0) + /* re-init the PHY so that we can listen to Dongle disconnect */ msm_dp_ctrl_reinit_phy(dp->ctrl); - } else { - /* - * unplugged interrupt - * dongle unplugged out of DUT - */ - msm_dp_ctrl_off_pixel_clk(dp->ctrl); - msm_dp_ctrl_off_link(dp->ctrl, dp->panel); + else msm_dp_display_host_phy_exit(dp); - } msm_dp_display->power_on = false; -- 2.43.0