From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1EA3C1F51 for ; Thu, 28 May 2026 10:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964912; cv=none; b=lWlHolZXNjhB4ZhZ5JabrSZvXhwttk1yD95EceuvPQ5ew0Pw8+oDcyM4TUxCxsIU+G41tnELJJh73UvgDIEI1KDjtnmhIltIDYIZPZwoH9LPai3OfKsPoZsTreMuqgeVvjZx/V5yodm7YB1+CuTO1sc9icbpl9CnHef+97oxH+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964912; c=relaxed/simple; bh=9RrNuNwTk/ww6iYx0SuggmHq9TFnipSUNnQOBEesNk0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=orE/mgQmGed8zrtLBlz7MCUGD5sCj9c+uZ4D3QVTnXY8e9YE89F7aZRnUdOuDgxc1Xy9km00eDAP4Hzlweg9a/OJKf6i4WBR5wmYIz/zBmdFc6cLhRzQCExkMBbbejpvOPIi3agbHXrO4F7ACRB40+FdmfHwQ8C6xk3rQLEK+nQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kQG+Juk9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HL2dDMEM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kQG+Juk9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HL2dDMEM" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S8wNGh382558 for ; Thu, 28 May 2026 10:41:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tpsE/BLJmEgKnrnJMIR8sDLnWgNFGNEPlGiP1+qAsFQ=; b=kQG+Juk9SVHTotYL Czw2ZdEwNgLUIbA/J/QDHH6g4V/R96HodONjjJal42NCCypvvp72fccz7oJ3QsZJ oDpAY+Wz/MohKfweQZWGYPtJ4nmdcG0aK1B6FoZMg/xIl66NNwRg2kcKNQaVU8Bh gYHNF/JUnBoWs4GoeAFTKRmE/dKbi5AlrStEzcr4i6ceKaWzZfJbFw4lO+fUzQon xIDfWUrgeFEW+EzN7Yq6UC078+soP81MsBF4S7fHXmgITJFiQlvKcTSQgbLKVL/D raPCpPYRt/c2foL+wzYA7Yzx0jFHWH9BAKqor4NsSDXK3EAM147zBueMUstek2tU u66uiw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7yrje8f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 10:41:49 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9112b2756fbso2438887385a.0 for ; Thu, 28 May 2026 03:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779964909; x=1780569709; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tpsE/BLJmEgKnrnJMIR8sDLnWgNFGNEPlGiP1+qAsFQ=; b=HL2dDMEMa7jd+g1QJc3XCuPzg5lGRw/Bb6DMNsPGyand8vX0+g2/M5+bqnm9DBZGGd wGxRHJrxUvavU/cq4FMv6ur3LitbCvFtaB3iqNWNNYN62qsw2oCwXCwxBwrHQKBpbYGn /Utmh22m4llVKRRlkk2n0KdDRgQEFdM9LeGMbmE6yRqHxIiE+DDCXw82I7ewoQ7M+8zq hDK4CgVCcrjWgBo0oEQFWJPF/5epLeB1zbU0s+kq9J+59nLydeXTrGa9mI7WB3OwTVEZ yyCZIY4hue2o84Xbf0+fYAjBURUDfWVd+X+jnzIPTj6eSMYQqelfG4kyS1jrvigFy/Us J5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779964909; x=1780569709; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tpsE/BLJmEgKnrnJMIR8sDLnWgNFGNEPlGiP1+qAsFQ=; b=AQewuSaqmZJkY3f5y05jyQseuLQo/tH+hJgvw+xkCUzF6JcYhR555CJT4ZVuj2OfEf BywrjmVfo5C1xS+upqW2NxxyHvK7WoO7fjSjtccv/srxAQQi3ZEQasjkNw3mDfUuqJ66 wStc2o5P0UOvDPITgnL9yD6Mfyeo/TxcJcxsceo+AHM3u2u/rZgvGrHZpOOwfCV1qv09 1xgJXw/cLCQbjJkd2zHvltwODNwpTKNf1jOneQqJEI7A0c9q/ug3v0ack6i4rneN8FvU hv31DKzjR/WlWgunU42DD1RglLShj/zReEsv3s29xBbRG8Shg3LhW/LZlwxjdFtjgKYp 2rzQ== X-Forwarded-Encrypted: i=1; AFNElJ9oE4vyEBzvJIg2zH4KLGl7gScOFA4dCf8gKEHbKpBQLC+uWjYZNqJKwozntJ12CFJb9SvEqULUY3jnWu8=@vger.kernel.org X-Gm-Message-State: AOJu0YxALib4sTnXrjteWhXkYyirIFMWGtfvRl72mjRTbABV5/CKhsvF fa0bl05mS4vJ1vdmklMT2fNVUpxfu9p3pfIhMstrPNfCSkl37ZTlbJ4488HwlPOZX1Ki9QJnO5p FtdGZKLofX7iUjnS1eeH9YWNYY5ryy73rvX3mDO650UCFDEqP63mb9HqXu+33Lzso+EU= X-Gm-Gg: Acq92OFuYkCWFp5VkKGGLrnqA/NR18jDrJc/4MwXJ26QCXG8naawOpkD8O5hbn1+YRo m/Pw908QQzEkfSznZoXF+agqEq7vfpF1L5VU4SnYypA/0mJSJ3JYabtpItPWMDbtf49mXZRNswn uXXzLmgB10vTmk/0kkQOJ3RtKCF6qNz5w7cfRUVKZC0+/o9pC6P4MwH8V0lFUfoWY5l2qK/LEBG 9WXhxPM1oy/uB9pr1Rg4BC/awuWyrZMUipw9A+iHM+a0ugfJz0lvVd7az8U34qowZw5NIUho8G2 hNz467Z1D0pWet2e07vL1u57HvWm6mDRBIqAX+2hyv3o3HFukzbYs1h/eWQWWkJ/ghAa5+BpwBM HUM7ZvIFRs2e18MQwYa+Zx5ChhMpE024Y0xqiIBA7UQJxc1FL20sdLwKmSVJl+fSmJjlnjjx178 qZjoGOWSoVYUirz9Ocrw== X-Received: by 2002:a05:620a:1a0c:b0:914:c01e:6f92 with SMTP id af79cd13be357-914c01e80b6mr2782525385a.18.1779964908810; Thu, 28 May 2026 03:41:48 -0700 (PDT) X-Received: by 2002:a05:620a:1a0c:b0:914:c01e:6f92 with SMTP id af79cd13be357-914c01e80b6mr2782521885a.18.1779964908368; Thu, 28 May 2026 03:41:48 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86fffddsm755148485a.12.2026.05.28.03.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 03:41:48 -0700 (PDT) From: Yongxing Mou Date: Thu, 28 May 2026 18:40:36 +0800 Subject: [PATCH v5 15/15] drm/msm/dp: pass panel to display enable/disable helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260528-dp_mstclean-v5-15-a9221c1f1f3b@oss.qualcomm.com> References: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> In-Reply-To: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779964831; l=3051; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=9RrNuNwTk/ww6iYx0SuggmHq9TFnipSUNnQOBEesNk0=; b=NUSYehlP04crvps+VPP259ZW5+AW1qkFK0Wi1t/AyhuKVspU510X+GVtKQ1PDP4N7qLZ9NfWQ uzd4MMW4C9gDsqvx+ZO39rdNfAIQjku5I/1EtfrdTdFiOT/K5fvu3H5 X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDEwOCBTYWx0ZWRfXzdloEEbWX9K0 iPTwf8vUPrS/VnR/vCWMGUax/gS50KhRAU6NplVRHBgsCqsU+eTvbHnKwYeVuV5baJCI/XBXONM VJEyHVOFVr885GL/VpI9p8pGAGWoNAvRNn2rXovHoktyfbcBoVqgFtEpvT16XersVOBPuUhE2nr ux77dDzjTkgz0S7Zxg2oFMz/VLXbKTfnvslA+3MvxGachBY0ppQUy38NmYFsde87hqwY3TyfdWa ZxyLzw8XfoE7H2Ao3WSa0DG6zZbL/SsWex+LTWSbnzOhpb2pcv4Nb/k1prj4J9YVWUXG32P6TII gt83Mhx9dbFu+8fsWb4FqIlas2iU5lpfPdeoSzvI/Mrp17BIgRPxzcjXAvQ8I5uDl9uwq+YeHa9 3d/PbtQFtFx7ZZRDI/lfdIzXODU4bcr2AKxPBKINe9nm0hGx1v3W9Np0pAqzHjck2aLYF+f89F4 rmkNOxrjzw+LqzdETqg== X-Authority-Analysis: v=2.4 cv=PLo/P/qC c=1 sm=1 tr=0 ts=6a181bed cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=Kfrt2GjMPgVQdVN7MJkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: gjiTknW9yzkiS01AtDXXMujHcXoVpKc8 X-Proofpoint-ORIG-GUID: gjiTknW9yzkiS01AtDXXMujHcXoVpKc8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_03,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280108 Pass struct msm_dp_panel to the display enable/disable helpers to make them easier to reuse for MST stream handling. Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index cd1f2899b733..bea5bfb22967 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -650,7 +650,8 @@ static int msm_dp_display_prepare_link(struct msm_dp_display_private *dp) return msm_dp_ctrl_prepare_stream_on(dp->ctrl, dp->panel, force_link_train); } -static int msm_dp_display_enable(struct msm_dp_display_private *dp) +static int msm_dp_display_enable(struct msm_dp_display_private *dp, + struct msm_dp_panel *msm_dp_panel) { int rc = 0; struct msm_dp *msm_dp_display = &dp->msm_dp_display; @@ -661,7 +662,7 @@ static int msm_dp_display_enable(struct msm_dp_display_private *dp) return 0; } - rc = msm_dp_ctrl_on_stream(dp->ctrl, dp->panel); + rc = msm_dp_ctrl_on_stream(dp->ctrl, msm_dp_panel); if (!rc) msm_dp_display->power_on = true; @@ -707,20 +708,21 @@ static void msm_dp_display_audio_notify_disable(struct msm_dp_display_private *d msm_dp_display->audio_enabled = false; } -static int msm_dp_display_disable(struct msm_dp_display_private *dp) +static int msm_dp_display_disable(struct msm_dp_display_private *dp, + struct msm_dp_panel *msm_dp_panel) { struct msm_dp *msm_dp_display = &dp->msm_dp_display; if (!msm_dp_display->power_on) return 0; - msm_dp_panel_disable_vsc_sdp(dp->panel); + msm_dp_panel_disable_vsc_sdp(msm_dp_panel); msm_dp_ctrl_off_pixel_clk(dp->ctrl); /* dongle is still connected but sinks are disconnected */ if (dp->link->sink_count == 0) - msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); + msm_dp_link_psm_config(dp->link, &msm_dp_panel->link_info, true); msm_dp_ctrl_off_link(dp->ctrl, dp->panel); @@ -1437,14 +1439,14 @@ void msm_dp_display_atomic_enable(struct msm_dp *msm_dp_display) dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); - rc = msm_dp_display_enable(dp); + rc = msm_dp_display_enable(dp, dp->panel); if (rc) DRM_ERROR("DP display enable failed, rc=%d\n", rc); rc = msm_dp_display_post_enable(msm_dp_display); if (rc) { DRM_ERROR("DP display post enable failed, rc=%d\n", rc); - msm_dp_display_disable(dp); + msm_dp_display_disable(dp, dp->panel); } drm_dbg_dp(msm_dp_display->drm_dev, "type=%d Done\n", msm_dp_display->connector_type); @@ -1479,7 +1481,7 @@ void msm_dp_display_atomic_post_disable(struct msm_dp *dp) msm_dp_display_audio_notify_disable(msm_dp_display); - msm_dp_display_disable(msm_dp_display); + msm_dp_display_disable(msm_dp_display, msm_dp_display->panel); msm_dp_display_unprepare(msm_dp_display); } -- 2.43.0